C#•2y ago

Help with Generics

Here is my current code:

StatAttackRange/StatAttackDamage inherit from CharacterStat

private StatAttackRange _attackRange;

public void SetCharacterStats(List<CharacterStat> characterStats)
        {
            foreach (CharacterStat characterStat in characterStats)
            {
                if (characterStat.GetType() == _attackRange.GetType())
                {
                    _attackRange = (StatAttackRange)characterStat;
                }else if (characterStat.GetType() == _attackDamage.GetType())
                {
                    _attackDamage = (StatAttackDamage)characterStat;
                }
            }
        }

private StatAttackRange _attackRange;

public void SetCharacterStats(List<CharacterStat> characterStats)
        {
            foreach (CharacterStat characterStat in characterStats)
            {
                if (characterStat.GetType() == _attackRange.GetType())
                {
                    _attackRange = (StatAttackRange)characterStat;
                }else if (characterStat.GetType() == _attackDamage.GetType())
                {
                    _attackDamage = (StatAttackDamage)characterStat;
                }
            }
        }

I feel like it's inelegant, and I believe the solution is to use generics. But when I try to make a generic function (see below) I'm doing something wrong and I'm not sure what.

https://i.imgur.com/tTW44Y9.png

Imgur

Angius•3/8/24, 5:14 AM

Or better yet, just use
Ah, wait

Angius•3/8/24, 5:14 AM

You also cast to , huh

ZekeOP•3/8/24, 5:15 AM

Yeah I have two potential stats inheriting from CharacterStat

ZekeOP•3/8/24, 5:15 AM

Oh I messed up, T should be StatAttackRange (sorry!)

Angius•3/8/24, 5:15 AM

maybe?

Angius•3/8/24, 5:15 AM

Ur, wait, why even have

ZekeOP•3/8/24, 5:15 AM

I updated my image sorry

ZekeOP•3/8/24, 5:16 AM

T and U are two separate inherited types

ZekeOP•3/8/24, 5:16 AM

And I save them as fields as their types

ZekeOP•3/8/24, 5:16 AM

Angius•3/8/24, 5:16 AM

Yeah, but do you pass both to the method?

ZekeOP•3/8/24, 5:17 AM

The initial list im passing in is full of inherited stats

ZekeOP•3/8/24, 5:17 AM

Not base classes

ZekeOP•3/8/24, 5:17 AM

So I needed to throw away stats like health : CharacterStat or attackspeed : CharacterStat

ZekeOP•3/8/24, 5:18 AM

Sort through anyway

Angius•3/8/24, 5:19 AM

Seems like

Angius•3/8/24, 5:19 AM

would be enough

Angius•3/8/24, 5:19 AM

Or, well, an if and else-if instead of a switch

ZekeOP•3/8/24, 5:19 AM

The solution you linked is similar to my own non generic version, but I thought this was a perfect case for generics. I'm mostly trying to learn

ZekeOP•3/8/24, 5:20 AM

I got scolded in a class once for using "-variable- is Type" and was told "use generics you silly goose" lol

Angius•3/8/24, 5:20 AM

I don't see a use case for generics here tbh

Angius•3/8/24, 5:21 AM

It probably wouldn't be how I handle character stats in a game either tbh, but that's another thing

ZekeOP•3/8/24, 5:21 AM

Fair enough. Appreciate the insight