app deprecation / new app version

i'll open a post here, since the other posts get lost/burried in the chanlels. i have made a "new" app home assistant with app exposure. @Nicolas told me the steps https://discord.com/channels/976934649643294750/976934650104676448/1205577175252869202 and i answered https://discord.com/channels/976934649643294750/976934650104676448/1206526316875227156 in short : i followed the steps. BUT that deprecation message only is shown when you click uninstall on the app, than the message is shown in the same menu where i just uninstalled the app - it was not shown when still running the deprected app. i can then install the deprecated version again from the same tab, the message points out "breaking change ... still use this version ...." but it will not show the deprecation message if you just use the app. you would then have to head over to the appstore, where you only find the new version. is this the intended way?
14 Replies
Nicolas
Nicolas10mo ago
It is normal yes, when deprecating an app we cannot magically edit the user's files and add a field to their config.json (the process of installing an app is to copy it from the store). So to deprecate an app you will just bump the tipi_version and add deprecated: true the user will see an update and when they update they'll see it's deprecated. Another version should be available for them if wanted. The deprecation doesn't mean it should be hidden for them I would say you did it correctly from what you described
InfBoumcyCastle
InfBoumcyCastleOP10mo ago
would it make sense, to have the deprecated app also being updated (tipi versio pushed by one) - so they see the deprecation warning? maybe with an migration guide, when applicable?
Nicolas
Nicolas10mo ago
Yes that's how we should do it imo, push the tipi version by one when deprecating
InfBoumcyCastle
InfBoumcyCastleOP10mo ago
ok, tested it succesfully and made PR #2455 tests show error at "Each app should have a different port" deprecated / new app in mealie / mealie-1 i see different ports. wht is your preference regarding to a another port either one of the apps? tagging @Stavros since he made a suggestion for a port at my last PR i use port 8209 for the homeassistant-1 app - thats the next port that i dont find in the official app repo by searching for "port:"
Stavros
Stavros10mo ago
Port? Ohh Well the app I think should have the same port Because if you migrate you don't use the old
InfBoumcyCastle
InfBoumcyCastleOP10mo ago
no cant, tests will fail
Stavros
Stavros10mo ago
Oh yes indeed Well use a different one for now
InfBoumcyCastle
InfBoumcyCastleOP10mo ago
yes used a new one
Stavros
Stavros10mo ago
It would be cool to make an auto port generator @Nicolas Should be very easy?
InfBoumcyCastle
InfBoumcyCastleOP10mo ago
there are a lot of things to be aware of - but all tests are green now - if i am in the mood i will write up what i had to do
Stavros
Stavros10mo ago
Ok ok
Nicolas
Nicolas10mo ago
Nice @InfBoumcyCastle looks good Just one thing about the port I left you a comment Doesn't work for me with the internal port 8209
InfBoumcyCastle
InfBoumcyCastleOP10mo ago
fixed. change to the standard port required an addition to the configuration.yaml inside the app as well. tested on 8209 as well one mom, all that port changing is not necessary at all :/ i am revoking that completely and only use another APP_PORT - the way it is intended - works @Nicolas any updates on the PR? should all be fine by now
Nicolas
Nicolas10mo ago
Hello, thanks I'll take a look this evening
Want results from more Discord servers?
Add your server