Did someone managed to use generic sms provider?
I've tried to implement two generic sms provider to avoid developping a provider (Brevo for SMS there is only Email for now, and SMSMode)
It seems to have a mandatory date field in the response that I don't have in one of the API. I also don't need to have authentication by token, and when switching off, and saving, it seems to be mandatory.
27 Replies
@Pawan Jain @Moderator do you have experience with that?
Can you share the generic provider config image? (Without any credentials)
@Nao Ohira
Could you please share the response example of sms provider?
I see there is some bug with
Authenticate by token toggleHi there, I'm trying to config these two providers:
https://developers.brevo.com/reference/sendtransacsms (the one with no date in response)
Base URL: https://api.brevo.com/v3/transactionalSMS/sms
API Key Request Header: Api-Key
API Key: the one I get from brevo
Secret Key Request Header : <empty>
Secret Key : <empty>
Id Path : messageId
Date Path : I don't have on in response but mandatory
Authenticate by token (I tried to disable this but I got this field error: Please enter a authenticate by token), I have to set it enabled
Auth URL : <empty>
Authentication Token Key : <Empty>
For SMS Mode
https://dev.smsmode.com/sms/v1/home
Base URL: https://rest.smsmode.com/sms/v1/messages
API Key Request Header: X-Api-Key
API Key : the one I get from SMSMode
Secret Key Request Header : <empty>
Secret Key : <Empty>
Id Path : messageId
Date Path : acceptedAt
Authenticate by token (I tried to disable this but I got this field error: Please enter a authenticate by token), I have to set it enabled
Auth URL : <empty>
Authentication Token Key : <Empty>
I want to add that I'm using self hosted Novu 0.22.0
@Nao Ohira, you just advanced to level 1!
Thanks @Nao Ohira for sharing all details
We will fix this issue in 0.23.0 release.
For date, we will make it optional and use current date as fallback
Thanks for your investigation 🙂
I will try to implement provider for SMSMode and Brevo (SendInBlue) SMS so I can use it and if it works, I will make a PR for sure. Nice product by the way
Thanks for the feedback Nao
Would you like to share how you are using Novu? Few use cases where Novu fits pefectly
We're using novu on premise with multi tenancy and as it's our customer that provide licence key for the provider that they contracted with. Novu itself fits our needs (especially recently with multi tenancy, variants, ...). And for providers, it's normal that you don't have every existing provider implementation. As long as your API allow us to implement provider that doesn't exist, I think it fits perfectly. 🙂
What channels you are using?
Did you try digest, delay and subscriber preferences feature ?
We are for now using mail and sms but we choose Novu especially to extends communication by in app and push notification, and have more event driven notification than just triggerd by user actions.
We also planned to use digest to prevent sending too much notifications. We didn't started to add subscriber preferences as we have both important notification and notificaiton that can be disabled, but it's something that we have also in mind, for selecting prefered channels
Thanks for sharing Nao 🙂
You're welcome. I'm very excited every release bringing new features. It's evolving really fast and each time it respond to at least my needs. I'll be glad to add feedbacks and also dev contribution for new providers and maybe other things 🙂
Hi there.
I've added several PR for some provider that I didn't manage to get it run properly with generic sms provider:
smsmode
brevo-sms
better proxy with sendinblue
GitHub
feat(provider): add smsmode provider by nohira · Pull Request #5066...
What change does this PR introduce?
Add smsmode provider implementation
Why was this change needed?
This provider is used in my product
Other information (Screenshots)
GitHub
feat(provider): add brevo-sms provider by nohira · Pull Request #50...
What change does this PR introduce?
Add brevo (SendInBlue) sms provider. Novu already has brevo mail provider but don't support sms provider.
Why was this change needed?
Needed my product
Other...
GitHub
fix(provider): add better proxy support for brevo mail provider by ...
What change does this PR introduce?
Add better proxy for brevo mail provider as axios may leads to 502 error when having proxy over HTTPS
Why was this change needed?
Using actual provider leads to ...
Thanks @Nao Ohira
Would you like to write documentation also for these providers
I've just followed the add provider guide. Canyou please tell me where do I have to write documentation?
@Nao Ohira, you just advanced to level 2!
Sorry, it's my first contribution to this project. I'm surely missing something 🙂
Hmm, I was looking for a way to update documentation. Maybe you're the provider sub project README.md?
Sorry for delayed response
We have different repo for documentation
GitHub
GitHub - novuhq/docs: Novu documentation - The Masterpiece
Novu documentation - The Masterpiece. Contribute to novuhq/docs development by creating an account on GitHub.
Hi again,
Don't worry for the delay 🙂
I hope it should be ok, please tell me if something is wrong 🙂
brevo doc
smsmode doc
I've fixed PR for new providers as well due to previously merged sms provider. After merging one of the PR, I'll fixed the second one as it will result in conflicts afterwards 🙂
Thanks Nao Ohira 🙏🏻
Hi, I've updated the documentation with at least the logo and a step by step guide for getting api key. As we're not the owner of the account (my use case is mostly multi tenancy and api usage), I didn't take any capture of the interface. However, the step by step guide are using the right UI wording. 🙂
I'm rebasing provider implementation also to be as ready as possible 🙂
Thanks Nao 🙂
Do you need any more modifications for merging?
Thanks Nao
I see both PR is merged 🙂