Unable to override "from" field for FireText provider
Hi All,
We've reported an issue in the past where we could not override the "from" value when sending a FireText SMS. This was supposed to be fixed here: https://github.com/novuhq/novu/pull/4168
However, I tried today and this is still not working unfortunately (see attached picture). The "from" value being used is the one set in the FireText integration but I am expecting it to be overriden by the one from the request. Did I miss something or potential bug?
Thanks,
Boum
GitHub
feat: add support for sms overrides by mahendraHegde · Pull Request...
What change does this PR introduce?
added support for overriding SMS
Changed worker/send-sms-usecase to support overrides
added types to node SDK
updated relevant docs
Why was this change needed?...
40 Replies
@Boum, you just advanced to level 2!
This merged PR will only become active in the next shipped release.
@unicodeveloper thanks, when would be the next release?
Sometime next week I think @Boum
Awesome, thanks @unicodeveloper, I'll keep an eye on it
Hi @Support - it seems that this fix was included as part of v0.20.0. However, it's still not working for me using the FireText provider. So my questions are:
- Is overriding the "from" sender id of FireText supposed to work?
- How can I ascertain what version of Novu is actually live? It's unclear if it's version 0.19.0 or 0.20.0
Thanks.
See my very first message on here for context.
Actually these changes weren't included as part of https://github.com/novuhq/novu/pull/4478/files as suggested from what I am seeing
GitHub
V0.20.x by scopsy · Pull Request #4478 · novuhq/novu
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)
The fix was in
apps/worker/src/app/workflow/usecases/send-message/send-message-sms.usecase.ts but there's no change on that file in version 0.20.0.
Unless this was supposed to be released in the next version (i.e. 0.21.0)?@Boum I see above PR commits are in main branch, so it is released in 0.20.0
Is it not working for you?
@Pawan Jain No, unfortunately it's not. I've tried the overrides object as seen in the screenshot of the PR which has the fix: https://github.com/novuhq/novu/pull/4168
The Sender ID being used is still the default one set in the FireText integration. I'd like to be able to override it to send SMS messages on behalf of different customers.
GitHub
feat: add support for sms overrides by mahendraHegde · Pull Request...
What change does this PR introduce?
added support for overriding SMS
Changed worker/send-sms-usecase to support overrides
added types to node SDK
updated relevant docs
Why was this change needed?...
Also, there is barely any information on how the
overrides object should be set to, it would be nice if the documentation was a bit descriptive:
And the documentation does not have version 0.20.0 in it
Hence when I said earlier it's unclear what version of Novu is currently live
We have not added v0.20.0 yet because we still need to add some specific docs and launch the release notes on GitHub
The overrides is provider specific, and the fields should be available in the page about a specific provider
Thanks all for the replies. @unicodeveloper Are you able to confirm if the overrides object is supposed to work for FireText and if not, when would this be available please?
@Raikas I can't find this page you are referring to so I might be missed something. Could you please send me a link to this for FireText?
Cheers,
Boum
@Boum
Since I have non uk phone number. I have reached out to their support email for assistance to sign up and use firetext
As soon as I receive reply from them, I will quicly test this and give you an update.
@Boum
Overrides are working with novu sms and AWS SNS provider.
Thanks @Pawan Jain - I doubt this is an issue with FireText (we don't use SNS). Reason is if I get Novu to send an SMS using the FireText integration in which the "From" value would be set to something (see screenshot), it works as expected.
However, if I trigger a workflow using the FireText integration when sending an SMS but want to override the "From" value from the FireText integration like so:
I still get an SMS with the Sender Id that is set in the integration which should not happen looking at this line:
@Boum Thanks for sharing
Could you please check if
to and content override is working with firetext?@Pawan Jain No worries. I just tried the
to override and it's actually working. Only the from override does not work so far. I'll try content.@Boum, you just advanced to level 3!
@Pawan Jain Ok so I tried again all three fields:
-
to works ✅
- content works ✅
- from not working ❌In this image, you used
Test Sender Id as from value.
When you receive the message it is showing?
Few countries (not sure UK) makes it mandatory to have senderId or from address to be verified to prevent spamNo it's not showing, instead the sender ID set in the FireText integration is used (see screenshot above). If the sender Id in the override would be invalid or filtered out, I would expect the SMS to never be received? It's still being sent but with the default
From value in the FireText integrationThat's the sender Id used when I get the SMS
Thanks for looking into it @Pawan Jain, would be cool to get to the bottom of it and have a fix for it soon 🙏
Sure.
We will check if provider throws (like firetext, twilio) any error with unverified
from. If yes we will add this error in activity logsHello everyone, I am also experiencing this issue - has there been an update on the situation?
@Josh, you just advanced to level 1!
Hi @Support - just wondered if you guys had a look at it by any chance? Thanks.
@Engineering
As
from is dependent on sms provider, whether from address is authorized and verified
Few sms providers. does not throw any error on using unauthorized from
Can we handle this case?
What do you suggest?one possiblility is to make an api call to the view sent massage endpoint to see if it was actually sent.
https://www.firetext.co.uk/docs#reports-view
SMS API Documentation | FireText
SMS API Documentation and Software Development Kit that provides you with an SMS gateway for sending and receiving SMS text messages with your FireText account.
I am not sure of any other option if they do not check it when they making a transactional message request.
Was this an accident?
@BiswaViraj
Lol yes, sorry 😅
Hi @Engineering @Support - I'm still encountering some challenges with the override logic and I'm quite sure that it's not related to FireText. I'd be really keen to share my findings and would appreciate the opportunity for a brief call to discuss this further. Would it be possible to arrange this? It's important for us to understand if there's a solution on the horizon, as this will help us decide our next steps. Thanks a lot for your assistance!
Sent you a DM @Boum
Hi @Boum
Thanks for your time
I fixed
from value not picked from override issue in this PR
https://github.com/novuhq/novu/pull/4845
There were few more sms providers with firetext that were showing same issue.
I will keep you posted once it is available in our SaaSHi @Pawan Jain - thank you for the very quick turnaround! It was very helpful to chat about it. Looking forward to seeing this fix go live 🚀
@Boum
I missed updating you in this thread
Above fix is available in Novu Saas