Unable to override "from" field for FireText provider
Hi All,
We've reported an issue in the past where we could not override the "from" value when sending a FireText SMS. This was supposed to be fixed here: https://github.com/novuhq/novu/pull/4168
However, I tried today and this is still not working unfortunately (see attached picture). The "from" value being used is the one set in the FireText integration but I am expecting it to be overriden by the one from the request. Did I miss something or potential bug?
Thanks,
Boum
GitHub
feat: add support for sms overrides by mahendraHegde · Pull Request...
What change does this PR introduce?
added support for overriding SMS
Changed worker/send-sms-usecase to support overrides
added types to node SDK
updated relevant docs
Why was this change needed?...
40 Replies
@Boum, you just advanced to level 2!
This merged PR will only become active in the next shipped release.
@unicodeveloper thanks, when would be the next release?
Sometime next week I think @Boum
Awesome, thanks @unicodeveloper, I'll keep an eye on it
Hi @Support - it seems that this fix was included as part of v0.20.0. However, it's still not working for me using the FireText provider. So my questions are:
- Is overriding the "from" sender id of FireText supposed to work?
- How can I ascertain what version of Novu is actually live? It's unclear if it's version 0.19.0 or 0.20.0
Thanks.
See my very first message on here for context.
Actually these changes weren't included as part of https://github.com/novuhq/novu/pull/4478/files as suggested from what I am seeing
GitHub
V0.20.x by scopsy · Pull Request #4478 · novuhq/novu
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)
The fix was in
apps/worker/src/app/workflow/usecases/send-message/send-message-sms.usecase.ts but there's no change on that file in version 0.20.0.
Unless this was supposed to be released in the next version (i.e. 0.21.0)?@Boum I see above PR commits are in main branch, so it is released in 0.20.0
Is it not working for you?
@Pawan Jain No, unfortunately it's not. I've tried the overrides object as seen in the screenshot of the PR which has the fix: https://github.com/novuhq/novu/pull/4168
The Sender ID being used is still the default one set in the FireText integration. I'd like to be able to override it to send SMS messages on behalf of different customers.
GitHub
feat: add support for sms overrides by mahendraHegde · Pull Request...
What change does this PR introduce?
added support for overriding SMS
Changed worker/send-sms-usecase to support overrides
added types to node SDK
updated relevant docs
Why was this change needed?...
Also, there is barely any information on how the
overrides object should be set to, it would be nice if the documentation was a bit descriptive:
And the documentation does not have version 0.20.0 in it
Hence when I said earlier it's unclear what version of Novu is currently live
We have not added v0.20.0 yet because we still need to add some specific docs and launch the release notes on GitHub
The overrides is provider specific, and the fields should be available in the page about a specific provider
Thanks all for the replies. @unicodeveloper Are you able to confirm if the overrides object is supposed to work for FireText and if not, when would this be available please?
@Raikas I can't find this page you are referring to so I might be missed something. Could you please send me a link to this for FireText?
Cheers,
Boum