Changes in code not getting reflected
Hi @unicodeveloper I have added a email provider template, but it just doesn't reflect in the UI. can you please help me?
I have added handler, added it to mail.factory.ts and similarly for email.ts too, but its just not reflecting
37 Replies
Please can you provide more context? Where are you in all the steps you followed? Have you added the logos for the new email provider, both dark and light?
first I ran and setup the provider template, I also created all the files within which I will be working, for example: emailProvider.handler.ts, factory, ... I mean I have setup all the files, I need to only work on Provider and handler function now
Images also have been added in the respective folder and configured as well
I think one possible issue is I think I need to install dependencies at the newProvider folder
I think you need to ensure you are done with all the processes, installation and code so it's easier to debug and reflect
also do you think I need to install dependencies for the provider? /provider/emailProvider
@ninja7, you just advanced to level 4!
yes, because you need to install whatever library you are using to send the email itself for the new provider
I have written all the code necessary, now I am confused about the next step
So are you running it and getting any issues? because you need to run it, see it in the UI, test the flow.
I mean do I do again?
You need to run the api service and also run the web in your terminals.
run “pnpm start” from the api directory (to ensure the api is running successfully) on one terminal and run "pnpm start" from the web directory in another terminal to ensure the web UI is running successfully
make sure you build from the root directory first with something like
pnpm build@madd hey there, i need your help bro
Sorry for delay, what is the problem?
You can also build from
/providers/your-provider and there are two scripts:
and
Avery change code in your provider will rebuild provider.no worries, I have successfully built but how do I determine if its working or not?
I mean if I am able to send any email or not
here is what I did so far:
1) added all necessary files, images and code everything
2) successfully ran 'npm run setup:project' again and also ran test
@unicodeveloper can you please help me on this matter?
You need to now follow the normal step of adding a provider, making it a primary provider and then triggering an email notification via code.
Put yourself in the shoe of a user that is trying to use Novu with the new provider you just added
for example, follow this quickstart and use it to test your own provider you just added to see if your work is actually working https://docs.novu.co/quickstarts/nodejs
Novu
Node.js - Novu
Learn how to use Novu to quickly send multi-channel (SMS, Email, Chat, Push) notifications with Node.js.
OR better still
Just ensure you have access to the Novu dashboard locally, Login and create a new workflow, add an email channel, ensure you have setup the provider (your new provider) from the integrations store. And then there is a test button on the workflow section where you can trigger a test notification
I went with usingg Novu dashboard locally, it goes good until above screen
Once I click on 'Set up Digest workflow', it shows error
Please create a normal workflow
No need for a digest workflow
Click on go back to take you to creating a blank workflow
same problem with blank workflow too
I can confirm its not working, all i see is above screen
@unicodeveloper
is the api service running
yes sir
Hmmn that's weird
no wait, I see error on API and workers' ongoing terminal
This is worker terminal
@unicodeveloper This is API's terminal
@Pawan Jain can you help me sir?
@unicodeveloper should I just make a PR?
Hi @ninja7
Yeah that would help
Please create a PR
we will review and suggest the issue
yeah let me do that in an instant
just did sir
Thanks
I will check over the weekend 😀
Someone please go through my PR @unicodeveloper @Pawan Jain
https://github.com/novuhq/novu/pull/4442
i think i needn't add pnpm-lock.yaml file
@ninja7, you just advanced to level 7!
Hi @Zac Clifton I have resolved the conflicts like you suggested
GitHub
Add/hashmail email provider by bibaswan7 · Pull Request #4442 · nov...
What change does this PR introduce?
It adds hashmail email provider to Novu
API reference: https://docs.hashmail.dev/docs/trigger-notifications-with-api
Why was this change needed?
Solves #4337
Oth...