K
Kord•2y ago
tmpod

Getting all messages in chronological order

I've been using the MessageChannelBehavior#messages flow (which is documented as being in chronological order) for a while, but always with the default EntitySupplyStrategy (cacheWithRestFallback). Since I now want to grab all messages in the channel, I changed by code from channel.messages.collect { ... } to withStrategy(EntitySupplyStrategy.rest).messages.collect { ... } (I am aware it may be performance intensive), however, messages now come in reverse chronological order.... Any idea what is wrong here?
5 Replies
tmpod
tmpodOP•2y ago
I've been looking at the code, and don't understand why that would be so
LustigerLurch
LustigerLurch•2y ago
it seems like discord always sends messages requested with this endpoint ordered from newest to oldest, no matter if requesting messages before or after some id so kord needs to sort the messages in each page (if requesting more than 100 messages) to have the documented order, which isn't done rn you can see this by running this code: 
val channel: Snowflake = TODO("some channel id")
val afterId: Snowflake = TODO("some message id")
val after = kord.rest.channel
    .getMessages(channel, Position.After(afterId), limit = 100)
    .map(DiscordMessage::id)
println(after == after.sorted()) // false
println(after == after.sortedDescending()) // true

val beforeId = Snowflake(after.first().timestamp + 1.milliseconds)
val before = kord.rest.channel
    .getMessages(channel, Position.Before(beforeId), limit = 100)
    .map(DiscordMessage::id)
println(before == before.sorted()) // false
println(before == before.sortedDescending()) // true

println(after == before) // true
val channel: Snowflake = TODO("some channel id")
val afterId: Snowflake = TODO("some message id")
val after = kord.rest.channel
    .getMessages(channel, Position.After(afterId), limit = 100)
    .map(DiscordMessage::id)
println(after == after.sorted()) // false
println(after == after.sortedDescending()) // true

val beforeId = Snowflake(after.first().timestamp + 1.milliseconds)
val before = kord.rest.channel
    .getMessages(channel, Position.Before(beforeId), limit = 100)
    .map(DiscordMessage::id)
println(before == before.sorted()) // false
println(before == before.sortedDescending()) // true

println(after == before) // true
so the actual behavior for MessageChannelBehavior.messages isn't what's documented because of wrong assumptions about the api response
tmpod
tmpodOP•2y ago
right mmm I'll have to do some rethinking then It may not really be feasible to get all messages in memory, then reverse them Thanks!
LustigerLurch
LustigerLurch•2y ago
not really, i think this should be fixed in kord instead because rn the order is neither cronological nor reversed cronological, it's some weird mix because of pagination
tmpod
tmpodOP•2y ago
ah true Completely overlooked that for some reason

Did you find this page helpful?