F
Filamentβ€’16mo ago
kerbylav

Bug in https://filamentphp.com/plugins/filament-spatie-tags

Didn't find any other way to communicate about plugin specifically, so write here. In SpatieTagsInput.php during saving you have such part $this->saveRelationshipsUsing(static function (SpatieTagsInput $component, ?Model $record, array $state) { if (! (method_exists($record, 'syncTagsWithType') && method_exists($record, 'syncTags'))) { return; } if ($type = $component->getType() && ! $component->isAnyTagTypeAllowed()) { $record->syncTagsWithType($state, $type); return; } $component->syncTagsWithAnyType($record, $state); }); It looks like you forgot to group $type = $component->getType() assignment in condition and hence $type is always either true or false instead of real type. Please fix it πŸ™‚
2 Replies
awcodes
awcodesβ€’16mo ago
If you know the problem and have a solution, why not submit a PR to fix it. πŸ™‚
kerbylav
kerbylavOPβ€’16mo ago
Ah, now I see how to do it. Was kind of confused that repo is readonly and stuff. Will do!
Want results from more Discord servers?
Add your server