Double rendering of Armor with AzureLib

Got a report of Armor being rendered at the Curser when wearing armor or looking at armor when using my Geckolib fork AzureLib. After doing some digging, it seems to be down to this line here: https://github.com/AzureDoom/AzureLib/blob/1.20/Fabric/src/main/java/mod/azure/azurelib/renderer/GeoArmorRenderer.java#L281 and having Real-Time Shadows on.

Any suggestions would be welcome.

Daedelus•9/6/23, 11:33 AM

Hello @Head Developer , this issue effecting thousands of players in a consistant manner.
Could you reply to the github issue by shedding some light on the potential ways to resolve it?

AAzureDoom Got a report of Armor being rendered at the Curser when wearing armor or looking...

IMS•9/6/23, 12:48 PM

Any armor or specific armor?

IMS•9/6/23, 12:50 PM

if it's specific armor i need a mod that causes it

IIMS Any armor or specific armor?

AzureDoomOP•9/6/23, 12:51 PM

It's any armor that's done using the GeoArmorRender (this is seen both in Geckolib itself and my fork AzureLib). Daedelus found it in his mod wizards and I was able to produce it with a test armor in my fork, I can push a version with that test armor if you'd like.

IMS•9/6/23, 12:52 PM

no, i can just put wizards in the dev env it's fine

IMS•9/6/23, 12:52 PM

just needed to know that

AzureDoomOP•9/6/23, 12:52 PM

Alright! It's got a lot of dependencies just a heads up.

IMS•9/6/23, 12:52 PM

hm, it's saying it wants geckolib specifically

IMS•9/6/23, 12:52 PM

so maybe i will need that test build actually lol

AzureDoomOP•9/6/23, 12:53 PM

Give me about 10 minutes here and I'll have it up on my maven for you!

IMS•9/6/23, 12:54 PM

I'm building your mod to make it easier to debug

IMS•9/6/23, 12:54 PM

so just source works

AzureDoomOP•9/6/23, 12:54 PM

Ah, the test armor wasn't pushed to my github, let me do a branch for that real fast.

IMS•9/6/23, 1:04 PM

you can ping me when it's up

IMS•9/6/23, 1:04 PM

and i'll take a look

AzureDoomOP•9/6/23, 1:08 PM

@IMS https://github.com/AzureDoom/AzureLib/tree/1.20-iristesting here you go! Just need to add Iris and Sodium to the runs mod folder (it's what I do anyway).

GitHub

GitHub - AzureDoom/AzureLib at 1.20-iristesting

Based off Geckolib but now just for my own needs. - GitHub - AzureDoom/AzureLib at 1.20-iristesting

AzureDoomOP•9/6/23, 1:09 PM

https://www.complementary.dev/shaders-v4/ is the shader I'm testing with as well.

Complementary Shaders v4 | Official Site

Complementary Shaders Version 4 is the original Complementary Minecraft Java Edition shader pack based on Capt Tatsu's BSL Shaders. The goal of Complementary v4 is being good at everything. Performance, gameplay, beauty, compatibility; you name it. Complementary v4 will try to provide you with the most issueless experience possible within limita...

IMS•9/6/23, 1:09 PM

IMS•9/6/23, 1:09 PM

v4 is actually being removed on friday fyi

IMS•9/6/23, 1:09 PM

does it happen with reimagined?

AzureDoomOP•9/6/23, 1:10 PM

Oh, let me test real fast

IMS•9/6/23, 1:11 PM

got the bug

IMS•9/6/23, 1:11 PM

this seems like a pretty standard case of shadows being rendered in the wrong image

IMS•9/6/23, 1:12 PM

though I wouldn't know why

IMS•9/6/23, 1:13 PM

lemme see what i can do

AzureDoomOP•9/6/23, 1:16 PM

Alright!

IMS•9/6/23, 1:17 PM

IMS•9/6/23, 1:17 PM

this really doesn't seem right

IMS•9/6/23, 1:17 PM

why are you not just using the world tick?

AzureDoomOP•9/6/23, 1:25 PM

That was something from both Gecko/Tslat. That's a good point though and I'll test that out.

IMS•9/6/23, 1:29 PM

either way, the issue seems to be is retained from the shadow pass

AAzureDoom That was something from both Gecko/Tslat. That's a good point though and I'll te...

IMS•9/6/23, 1:31 PM

It seems the core issue just lies with the fact you can't call render twice in one frame and have it work

IMS•9/6/23, 1:31 PM

and you need to do something with

IMS•9/6/23, 1:31 PM

that won't work, because the shadow pass kinda relies on that idea

IMS•9/6/23, 1:34 PM

for some reason your armor is taking the shadow pass's but nothing else

IMS•9/6/23, 1:51 PM

OK i think I know what's going on

IMS•9/6/23, 1:51 PM

somehow, you're grabbing the player's in what should be a shadow call

IMS•9/6/23, 1:51 PM

this defers whatever you're trying to render to happen way later than it should

IMS•9/6/23, 1:51 PM

the is what's replacing the correct RenderBuffers

IMS•9/6/23, 1:51 PM

which is why it seems like that's the bug

Daedelus•9/6/23, 1:52 PM

Clarification:

AzureLib is a fork of GeckoLib
The issue happens any armor is rendered using GeoArmorRenderer (from either AzureLib or GeckoLib)
Wizards is specifically using GeckoLib.