How to i increase the size of the heroicons in admin sidebar in v3? Just same size as v2 will do

I upgraded 1 of my sites to filament v3 and now the heroicons look very small now. Is there any configuration I can change to increase the heroicons size in the admin side bar?
No description
17 Replies
pocket.racer
pocket.racerOP16mo ago
In v2 it looked like this by default, which u can see is bigger
No description
Kenneth Sese
Kenneth Sese16mo ago
That looks like a bug. I bet it's missing flex-shrink-0 on the icons Yes, confirmed...I can reproduce it when I have my scrollbars turned on and adding flex-shrink-0 fixes the problem. Well, that fixes the icon shrink, but it doesn't fix the button hover background...you'll have to play with the padding. I'd create an issue so Zep can look at it since it's more indepth than just adding flex-shrink-0. And be sure to mention you have scroll bars always turned on since that's what's causing the issue
pocket.racer
pocket.racerOP16mo ago
button hover background? What do u mean?
Kenneth Sese
Kenneth Sese16mo ago
Your issue (small icons):
Kenneth Sese
Kenneth Sese16mo ago
No description
Kenneth Sese
Kenneth Sese16mo ago
With flex-shrink-0 on the icon. But notice the background on hover is way too small. The padding isn't applying since the scrollbar took up the needed area
Kenneth Sese
Kenneth Sese16mo ago
No description
Kenneth Sese
Kenneth Sese16mo ago
And what it should look like (scroll bars are hidden):
Kenneth Sese
Kenneth Sese16mo ago
No description
Kenneth Sese
Kenneth Sese16mo ago
Most likely having scrollbars always on along with so many icons that its scrolls was a scenario that was missed during development
Dennis Koch
Dennis Koch16mo ago
Can you PR the fix?
Kenneth Sese
Kenneth Sese16mo ago
Will do.
Dennis Koch
Dennis Koch16mo ago
Thanks
Kenneth Sese
Kenneth Sese16mo ago
I take that back. It seems like the sidebar has changed since 3.0.27 (demo) and the most recent release. For example looks like Zep swapped out grid for flex, and some of the negative margin is gone. Also I was diving into the code and there are a lot of edge cases, like tenancy, side bar collapsed, etc. that I think will need Zep to look into. I'm happy to give it a shot tomorrow/Monday if it helps, but I know sometimes "helping" isn't really helping. I know he's spent a lot of time on this. Just let me know.
Kenneth Sese
Kenneth Sese16mo ago
@pocket.racer @Dennis Koch Submitted a PR and did my best to test every configuration I could. https://github.com/filamentphp/filament/pull/8116
GitHub
Fix collapsed sidebar icons when scrollbars are present by archilex...
Currently when 1) sidebars are collapsed and 2) scrollbars are always turned on, the icons will shrink due to there not being enough space for them expand. This PR fixes this by adding items-center...
pocket.racer
pocket.racerOP16mo ago
Thank you for the PR! I see that it is merged However updating it to 3.0.46 the problem still exist
No description
Kenneth Sese
Kenneth Sese16mo ago
Hi. This was actually reverted due to a flicker when a collapsible sidebar isn’t used, which is why it’s still not fixed, BUT I just submitted another PR to fix the flicker.
Want results from more Discord servers?
Add your server