C#•3y ago

❔ Program showing unwanted entries after multiple uses

When I run my code that returns entries from my database, if I run it multiple times it starts to add entries to the top that I don't want in the first place. I can't figure out why this is happening, looking over my code I can I'm guessing it is a problem with my menu class, but I'm not sure.

Screenshot explanation: I ran my showContacts() method 4 times, and it wrote an unwanted entry every time i ran the method

pastebin:
https://paste.mod.gg/wfrhxghnoxws/1

BlazeBin - wfrhxghnoxws

A tool for sharing your source code with the world!

Angius•7/24/23, 9:59 PM

I see this method as not working properly the first 3 times, and working correctly only the 4th time

Angius•7/24/23, 9:59 PM

Since it fetches all the contacts, and yet, the first 3 times it displays only a single one

REAL STUNNAOP•7/24/23, 10:00 PM

i think i explained it wrong

REAL STUNNAOP•7/24/23, 10:00 PM

REAL STUNNAOP•7/24/23, 10:00 PM

first time i use the method

REAL STUNNAOP•7/24/23, 10:00 PM

REAL STUNNAOP•7/24/23, 10:00 PM

second time i use the method

REAL STUNNAOP•7/24/23, 10:01 PM

the functionality is weird, sometimes it sticks with one extra entry at the top and then other times it will have 3 or 4

Angius•7/24/23, 10:01 PM

Could be because you have methods here and there?

Angius•7/24/23, 10:01 PM

If it's largely unpredictable, I'd say async issues

Angius•7/24/23, 10:01 PM

And is a glaring one

REAL STUNNAOP•7/24/23, 10:02 PM

oh is async void not supposed to be a thing

Angius•7/24/23, 10:02 PM

Correct

Angius•7/24/23, 10:02 PM

Those methods need to be

Angius•7/24/23, 10:02 PM

And they need to be ed when called

REAL STUNNAOP•7/24/23, 10:03 PM

oooooh

REAL STUNNAOP•7/24/23, 10:03 PM

is it alright if I have variables that call the await function instead of just having it by itself?

Angius•7/24/23, 10:03 PM

Variables don't call functions

REAL STUNNAOP•7/24/23, 10:04 PM

or i mean hold it

Angius•7/24/23, 10:04 PM

Or do you mean

REAL STUNNAOP•7/24/23, 10:04 PM

the value that results from the function

REAL STUNNAOP•7/24/23, 10:04 PM

is that a better way to do it?

REAL STUNNAOP•7/24/23, 10:04 PM

right now i have

REAL STUNNAOP•7/24/23, 10:04 PM

just that

REAL STUNNAOP•7/24/23, 10:04 PM

var foo = await FooAsync()

Angius•7/24/23, 10:05 PM

Asynchronous methods return a

Angius•7/24/23, 10:05 PM

Or a

Angius•7/24/23, 10:05 PM

To get a value from a it needs to be ed

Angius•7/24/23, 10:05 PM

Similarly, to ensure that a has been actually completed, it needs to be ed

Angius•7/24/23, 10:07 PM

So:
a) Preferable

b) Acceptable

c) Unacceptable

d) Unless for fire-and-forget reasons, but then it's better to use a discard to be explicit

REAL STUNNAOP•7/24/23, 10:07 PM

oh awesome

REAL STUNNAOP•7/24/23, 10:08 PM

def gotta do more research on async methods if i dont even know i was supposed to return a task

Angius•7/24/23, 10:09 PM

If a method s something inside, it needs to be
If a method is it should be ed
If a method is it needs to return or

Angius•7/24/23, 10:09 PM

Those are the three most important rules of thumb

Angius•7/24/23, 10:09 PM

Anything else is nuance

REAL STUNNAOP•7/24/23, 10:09 PM

perfect thanks

Jimmacle•7/24/23, 10:10 PM

huh somehow i missed that the first time i looked it over

Jimmacle•7/24/23, 10:11 PM

if you really want it async, you can change the entry point to and bubble the s down through the rest of your code

Jimmacle•7/24/23, 10:12 PM

but given the application i don't think there's any point in using async/await

JJimmacle if you really want it async, you can change the entry point to `static async Tas...

REAL STUNNAOP•7/24/23, 10:12 PM

can you explain what you mean by bubble the awaits down

Jimmacle•7/24/23, 10:13 PM

so your main is marked which allows you to other methods called in it

Jimmacle•7/24/23, 10:13 PM

by bubble down i just mean do that for all of your other methods in your code that need to be async

Angius•7/24/23, 10:13 PM

Async code is, uh, infectious

Jimmacle•7/24/23, 10:14 PM

but since you aren't actually doing anything in parallel, async isn't giving you any benefit here so it's not worth the overhead and having to change all your other code to be async

Jimmacle•7/24/23, 10:17 PM

your DbContext has synchronous variations of all of the current async methods you're calling on it (just remove the )

Jimmacle•7/24/23, 10:18 PM

the main benefit of async/await is to avoid consuming CPU resources when you're waiting on IO bound work, but you don't have any other code that needs CPU while you wait for your async calls to finish

REAL STUNNAOP•7/24/23, 10:19 PM

yeah that makes sense since im not oding anything else

REAL STUNNAOP•7/24/23, 10:20 PM

but lets say there is a frontend

REAL STUNNAOP•7/24/23, 10:20 PM

i would then want to use async right?

Jimmacle•7/24/23, 10:20 PM

correct