isToggledHiddenByDefault not working 2.17.29
What changed that caused this feature to quite working. If I log out and log back in all columns are showing again.
13 Replies
I have confirmed it works as expected on 2.17.28
Can you check which version it broke by stepping forward?
it's 2.17.29
2.17.28 works fine
PR 6299 updated the logic a bit which is probably why this is happening
GitHub
Persist table filters from request in session by nevinkaonline · Pu...
Stores filtering options in the session when those options were received from request when redirected from another page. Without this, the filter is only saved in the session when it is changed dir...
Looks like the defaultColumnToggles is only being set when there is a session key and if there isn't one it's setting it to the current layout
That lines up with what I'm seeing.
I think that portion of the PR might need to be reverted.
ToggleColumns are a little different than other table settings like search, column search, sorting, since toggledColumns are always persisted. Toggle columns don't have a separate persist method. I'll see if I can throw together a PR to fix this
Thanks for the education. A little out of my scope. I'm going to remain on .28 until we see some movement.
Just submitted a PR which reverts this: https://github.com/filamentphp/filament/pull/6341
GitHub
Revert toggle columns by archilex · Pull Request #6341 · filamentph...
PR #6299 changed the logic of toggle columns breaking toggle columns default. With the change, on the first page load it would load all the columns since the session didn't have a toggleColumnS...
@.schrader Dan just tagged a new version with the PR reverting this.
Thanks for helping with this!
.30 fixed 2 of my sites but not the last 1, so i think the fix is not complete yet
In case someone comes here and doesn't see the chat, the problem is that .29 stored the empty toggleColumn array in the session so even after updating to .30, that empty array is still in the session. If you're having this problem you'll need to clear your session. If you're using a session database you can delete all the sessions after 1682599924 which is before .29 was released. This will log out those users and clear their sessions.