Slideshow Mod compatibility issue in Iris 1.6.1

After 1.6.1 update has been released, there have been compatibility issues with the slideshow mod. Screenshots soon
41 Replies
AndyWithCatz
AndyWithCatz2y ago
1.6.1
No description
AndyWithCatz
AndyWithCatz2y ago
1.6
No description
AndyWithCatz
AndyWithCatz2y ago
one shader named Photon even crashes when theres a slideshow image nearby
IMS
IMS2y ago
yeah the slideshow mod needs to implement BlendingStateHolder I can implement a small workaround, but it won’t be good
AndyWithCatz
AndyWithCatz2y ago
ill notify the mod maker then
IMS
IMS2y ago
another solution is to make their render type extend CompositeRenderType instead of RenderType
3TUSK
3TUSK2y ago
@IMS Former SlideShow dev here. I learnt this report through other channel and would like to know more about this. Specifically the BlendingStateHolder part, because I couldn't find it anywhere. (A remark: op is using a fork of SlideShow which ports SlideShow from Forge to Fabric. I am the former dev of the original one which is Forge only for now; still, I believe fixing it on upstream is worth it.)
IMS
IMS2y ago
BlendingStateHolder is an interface that tells Iris what stage of translucency an render type renders in Iris uses this for batched entity rendering to properly sort objects so they’re not invisible compositerendertype has a default implementation of this, but rendertype does not
3TUSK
3TUSK2y ago
Interesting, but where is this interface (?) located at? Vanilla? Iris itself? Somewhere else?
IMS
IMS2y ago
Iris
3TUSK
3TUSK2y ago
Now this is strange
No description
IMS
IMS2y ago
weird it’s in net.coderbot.batchedentityrendering.impl iirc
3TUSK
3TUSK2y ago
Found it, so it's GitHub search index broke And we have CompositeRenderType implemented it via Mixin, got it Thank you for your heads-up!
Zbx1425
Zbx14252y ago
Umm isn't CompositeRenderType final?
Want results from more Discord servers?
Add your server