C#•2y ago

❔ Any way to optimize this? Task.WhenAll

This takes anywhere from 6-14 seconds, Any way to make it faster?

   private async Task HandlePhaseAudioFileStorage()
    {
        var tasks = new List<Task>();
        foreach (var phase in _currentLesson.Phases)
        {
            // Generate default bot audio if not provided
            if (phase.BotAudio is null)
            {
                phase.BotAudio = await _googleApiManager.TextToSpeechAsync(phase.BotText, _srcLanguageCode);
                var defaultBotBlobKey = _azureBlobStorageManager.GenerateBlobKey();
                phase.DefaultPhaseBlobFileId = defaultBotBlobKey;
                var botAudioWithTranslation = new AudioAndTranslation(phase.BotAudio, phase.BotText);
                tasks.Add(_azureBlobStorageManager.SaveServerGeneratedFilesBytesAsync(defaultBotBlobKey,
                    botAudioWithTranslation));
            }
            if (phase.BotResponseTextOnSuccess is not null)
            {
                var successBotBlobKey = _azureBlobStorageManager.GenerateBlobKey();
                phase.SuccessPhaseBlobFileId = successBotBlobKey;

                var botSuccessAudioTask = phase.BotResponseAudioOnSuccess is not null
                    ? Task.FromResult(phase.BotResponseAudioOnSuccess)
                    : _googleApiManager.TextToSpeechAsync(phase.BotResponseTextOnSuccess, _srcLanguageCode);

                tasks.Add(botSuccessAudioTask.ContinueWith(async (botSuccessAudioTaskResult) =>
                {
                    var botSuccessAudio = await botSuccessAudioTaskResult;
                    var botSuccessAudioWithTranslation =
                        new AudioAndTranslation(botSuccessAudio, phase.BotResponseTextOnSuccess);
                    await _azureBlobStorageManager.SaveServerGeneratedFilesBytesAsync(successBotBlobKey,
                        botSuccessAudioWithTranslation);
                }));
            }

            }
        }

        await Task.WhenAll(tasks);
    }

   private async Task HandlePhaseAudioFileStorage()
    {
        var tasks = new List<Task>();
        foreach (var phase in _currentLesson.Phases)
        {
            // Generate default bot audio if not provided
            if (phase.BotAudio is null)
            {
                phase.BotAudio = await _googleApiManager.TextToSpeechAsync(phase.BotText, _srcLanguageCode);
                var defaultBotBlobKey = _azureBlobStorageManager.GenerateBlobKey();
                phase.DefaultPhaseBlobFileId = defaultBotBlobKey;
                var botAudioWithTranslation = new AudioAndTranslation(phase.BotAudio, phase.BotText);
                tasks.Add(_azureBlobStorageManager.SaveServerGeneratedFilesBytesAsync(defaultBotBlobKey,
                    botAudioWithTranslation));
            }
            if (phase.BotResponseTextOnSuccess is not null)
            {
                var successBotBlobKey = _azureBlobStorageManager.GenerateBlobKey();
                phase.SuccessPhaseBlobFileId = successBotBlobKey;

                var botSuccessAudioTask = phase.BotResponseAudioOnSuccess is not null
                    ? Task.FromResult(phase.BotResponseAudioOnSuccess)
                    : _googleApiManager.TextToSpeechAsync(phase.BotResponseTextOnSuccess, _srcLanguageCode);

                tasks.Add(botSuccessAudioTask.ContinueWith(async (botSuccessAudioTaskResult) =>
                {
                    var botSuccessAudio = await botSuccessAudioTaskResult;
                    var botSuccessAudioWithTranslation =
                        new AudioAndTranslation(botSuccessAudio, phase.BotResponseTextOnSuccess);
                    await _azureBlobStorageManager.SaveServerGeneratedFilesBytesAsync(successBotBlobKey,
                        botSuccessAudioWithTranslation);
                }));
            }

            }
        }

        await Task.WhenAll(tasks);
    }

71 Replies

Florian Voß•2y ago

not sure if my suggestions will make it faster but some things I would give a try @AntiMatter : - try rewriting your code to use Parallel.ForEach() - await only when the result of the async operation is needed. You are awaiting everything directly which is not always needed, e.g. you await TextToSpeechAsync() before you do other operations even tho you need the result (phase.BotAudio) after those other operations, you can await it later when you really need the result. - maybe you can make sync work that you have async too? such as GenerateBlobKey(), try making that async

JakenVeina•2y ago

private Task ProcessItemsInParallelAsync(IEnumerable<T> items)
    => Task.WhenAll(items
        .Select(async item =>
        {
            ...
        }));

private Task ProcessItemsInParallelAsync(IEnumerable<T> items)
    => Task.WhenAll(items
        .Select(async item =>
        {
            ...
        }));

if you're on .NET 6+, you also have access to Parallel.ForEachAsync() which gives you a few more under-the-hood mechanical optimizations, which might help if you have very large workloads

await Parallel.ForEachAsync(items,
    async (item, cancellationToken) =>
    {
        ...
    });

await Parallel.ForEachAsync(items,
    async (item, cancellationToken) =>
    {
        ...
    });

in your code, you're not actually running everything in parallel you've got an await in the first if block that forces some or all of those elements to serialize, instead of running in parallel

Florian Voß•2y ago

@AnievNekaj what do you think bout my suggestions, are they good? if we do all three things: 1. parallelize 2. await later when result is needed 3. make sync work async too it should get a lot faster right?

Gaming

Programming

❔ Any way to optimize this? Task.WhenAll