C#•16mo ago

❔ Any way to optimize this? Task.WhenAll

This takes anywhere from 6-14 seconds, Any way to make it faster?

   private async Task HandlePhaseAudioFileStorage()
    {
        var tasks = new List<Task>();
        foreach (var phase in _currentLesson.Phases)
        {
            // Generate default bot audio if not provided
            if (phase.BotAudio is null)
            {
                phase.BotAudio = await _googleApiManager.TextToSpeechAsync(phase.BotText, _srcLanguageCode);
                var defaultBotBlobKey = _azureBlobStorageManager.GenerateBlobKey();
                phase.DefaultPhaseBlobFileId = defaultBotBlobKey;
                var botAudioWithTranslation = new AudioAndTranslation(phase.BotAudio, phase.BotText);
                tasks.Add(_azureBlobStorageManager.SaveServerGeneratedFilesBytesAsync(defaultBotBlobKey,
                    botAudioWithTranslation));
            }
            if (phase.BotResponseTextOnSuccess is not null)
            {
                var successBotBlobKey = _azureBlobStorageManager.GenerateBlobKey();
                phase.SuccessPhaseBlobFileId = successBotBlobKey;

                var botSuccessAudioTask = phase.BotResponseAudioOnSuccess is not null
                    ? Task.FromResult(phase.BotResponseAudioOnSuccess)
                    : _googleApiManager.TextToSpeechAsync(phase.BotResponseTextOnSuccess, _srcLanguageCode);

                tasks.Add(botSuccessAudioTask.ContinueWith(async (botSuccessAudioTaskResult) =>
                {
                    var botSuccessAudio = await botSuccessAudioTaskResult;
                    var botSuccessAudioWithTranslation =
                        new AudioAndTranslation(botSuccessAudio, phase.BotResponseTextOnSuccess);
                    await _azureBlobStorageManager.SaveServerGeneratedFilesBytesAsync(successBotBlobKey,
                        botSuccessAudioWithTranslation);
                }));
            }

            }
        }

        await Task.WhenAll(tasks);
    }

   private async Task HandlePhaseAudioFileStorage()
    {
        var tasks = new List<Task>();
        foreach (var phase in _currentLesson.Phases)
        {
            // Generate default bot audio if not provided
            if (phase.BotAudio is null)
            {
                phase.BotAudio = await _googleApiManager.TextToSpeechAsync(phase.BotText, _srcLanguageCode);
                var defaultBotBlobKey = _azureBlobStorageManager.GenerateBlobKey();
                phase.DefaultPhaseBlobFileId = defaultBotBlobKey;
                var botAudioWithTranslation = new AudioAndTranslation(phase.BotAudio, phase.BotText);
                tasks.Add(_azureBlobStorageManager.SaveServerGeneratedFilesBytesAsync(defaultBotBlobKey,
                    botAudioWithTranslation));
            }
            if (phase.BotResponseTextOnSuccess is not null)
            {
                var successBotBlobKey = _azureBlobStorageManager.GenerateBlobKey();
                phase.SuccessPhaseBlobFileId = successBotBlobKey;

                var botSuccessAudioTask = phase.BotResponseAudioOnSuccess is not null
                    ? Task.FromResult(phase.BotResponseAudioOnSuccess)
                    : _googleApiManager.TextToSpeechAsync(phase.BotResponseTextOnSuccess, _srcLanguageCode);

                tasks.Add(botSuccessAudioTask.ContinueWith(async (botSuccessAudioTaskResult) =>
                {
                    var botSuccessAudio = await botSuccessAudioTaskResult;
                    var botSuccessAudioWithTranslation =
                        new AudioAndTranslation(botSuccessAudio, phase.BotResponseTextOnSuccess);
                    await _azureBlobStorageManager.SaveServerGeneratedFilesBytesAsync(successBotBlobKey,
                        botSuccessAudioWithTranslation);
                }));
            }

            }
        }

        await Task.WhenAll(tasks);
    }

71 Replies

Florian Voß•16mo ago

not sure if my suggestions will make it faster but some things I would give a try @AntiMatter : - try rewriting your code to use Parallel.ForEach() - await only when the result of the async operation is needed. You are awaiting everything directly which is not always needed, e.g. you await TextToSpeechAsync() before you do other operations even tho you need the result (phase.BotAudio) after those other operations, you can await it later when you really need the result. - maybe you can make sync work that you have async too? such as GenerateBlobKey(), try making that async

JakenVeina•16mo ago

private Task ProcessItemsInParallelAsync(IEnumerable<T> items)
    => Task.WhenAll(items
        .Select(async item =>
        {
            ...
        }));

private Task ProcessItemsInParallelAsync(IEnumerable<T> items)
    => Task.WhenAll(items
        .Select(async item =>
        {
            ...
        }));

if you're on .NET 6+, you also have access to Parallel.ForEachAsync() which gives you a few more under-the-hood mechanical optimizations, which might help if you have very large workloads

await Parallel.ForEachAsync(items,
    async (item, cancellationToken) =>
    {
        ...
    });

await Parallel.ForEachAsync(items,
    async (item, cancellationToken) =>
    {
        ...
    });

in your code, you're not actually running everything in parallel you've got an await in the first if block that forces some or all of those elements to serialize, instead of running in parallel

Florian Voß•16mo ago

@AnievNekaj what do you think bout my suggestions, are they good? if we do all three things: 1. parallelize 2. await later when result is needed 3. make sync work async too it should get a lot faster right?

antimatter8189•16mo ago

Well what i ended up doing is what @AnievNekaj suggested with await Parallel.ForEachAsync(_currentLesson.Phases) cut it down to 3-4 secs I cant paste the entire methode here basically :

 var tasks = new List<Task>();
    await Parallel.ForEachAsync(_currentLesson.Phases,
        async (phase, cancellationToken) =>
        {
             // Generate default bot audio if not provided
             if (phase.BotResponseTextOnSuccess is not null || phase.BotAudio is null)
             {

                 if (phase.BotAudio is null)
                 {
                     var defaultBotBlobKey = _azureBlobStorageManager.GenerateBlobKey();
                     phase.DefaultPhaseBlobFileId = defaultBotBlobKey;

                     tasks.Add(_googleApiManager.TextToSpeechAsync(phase.BotText, _srcLanguageCode).ContinueWith(
                         async (botAudioTaskResult) =>
                         {
                             phase.BotAudio = await botAudioTaskResult;
                             var botAudioWithTranslation = new AudioAndTranslation(phase.BotAudio, phase.BotText,
                                 _currentLesson.Id, phase.PhaseNumber);
                             await _azureBlobStorageManager.SaveBotDefaultAudioContainer(defaultBotBlobKey,
                                 botAudioWithTranslation);
                         }, cancellationToken));
                 }
             }

 var tasks = new List<Task>();
    await Parallel.ForEachAsync(_currentLesson.Phases,
        async (phase, cancellationToken) =>
        {
             // Generate default bot audio if not provided
             if (phase.BotResponseTextOnSuccess is not null || phase.BotAudio is null)
             {

                 if (phase.BotAudio is null)
                 {
                     var defaultBotBlobKey = _azureBlobStorageManager.GenerateBlobKey();
                     phase.DefaultPhaseBlobFileId = defaultBotBlobKey;

                     tasks.Add(_googleApiManager.TextToSpeechAsync(phase.BotText, _srcLanguageCode).ContinueWith(
                         async (botAudioTaskResult) =>
                         {
                             phase.BotAudio = await botAudioTaskResult;
                             var botAudioWithTranslation = new AudioAndTranslation(phase.BotAudio, phase.BotText,
                                 _currentLesson.Id, phase.PhaseNumber);
                             await _azureBlobStorageManager.SaveBotDefaultAudioContainer(defaultBotBlobKey,
                                 botAudioWithTranslation);
                         }, cancellationToken));
                 }
             }

@Florian Voß anything else to add to this? Im using .net 7 btw

Florian Voß•16mo ago

looks much better now, you've fullfilled the first and second point I mentioned. Third is least important one, might potentially even make it slower

antimatter8189•16mo ago

Thanks bud 😄 you too @AnievNekaj

Becquerel•16mo ago

you may also want to look into using ValueTask since there are branches in this where async work is not done (phase.BotAudio is not null and phase.BotResponseTextOnSuccess is null) if the non-async path is the most common one then ValueTask will let it run synchronously, which can be a perf boost valuetask comes with a lot of gotchas though, and i don't remember even half of them, so read the docs before trying it

JakenVeina•16mo ago

Parallel.ForEachAsync() only supports ValueTask. And ValueTask is really only valuable for work that has a high likelihood of completing synchronously. This appears to be I/O work, which has no likelihood of completing synchronously.

Gaming

Programming

❔ Any way to optimize this? Task.WhenAll