K
Kord•2y ago
tmpod

LiveCategories and child channel events

Does LiveCategory receive events for child channels? I was looking at the code and don't believe it does, but I'd like to be sure in case I'm missing something 🙃 In any case I suppose I could implement my own and override the filter method, right?
12 Replies
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
tmpod
tmpodOP•2y ago
I do not know what that is, so I'm assuming I don't
tmpod
tmpodOP•2y ago
I looked at these two classes
No description
No description
tmpod
tmpodOP•2y ago
LiveChannel filters events by exact match of the channel itself and LiveCategory doesn't override filter, just update
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
tmpod
tmpodOP•2y ago
no, I believe it should filter based on exact channel ID as well as parent ID so it gets events both for itself and its children
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
tmpod
tmpodOP•2y ago
not update but filter the events update would be too complicated imo but it should be possible to process events for child channels in its flow (or through on)
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
tmpod
tmpodOP•2y ago
I know. What I am saying is that it could (and maybe should?) check the parentId in its filter instead of just delegating it to the inherited method from LiveChannel. It's rather useful to receive events for all channels under a category. atm I'm rolling my own LiveCategory that patches that, but it would be nice to have that on upstream
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
tmpod
tmpodOP•2y ago
Will do

Did you find this page helpful?