banners broke between 1.6.0 beta 5 and release on 1.19.2
Effects all shaders I've tried. I can see the designs flickering. I tried reverting the "fix banners" commit to see if it was related, but sadly it wasn't that simple. Any help would be appreciated, thank you!
32 Replies
oh shit...
Maybe I should have tested the fix...
@IMS ?
i'm not getting this
might be a mod incompat?
oo, maybe. let me try my iris only install
it's most likely figura if so
i had to fix a few problems with figura
What were they btw
Is there a specific check?
well actually this could also be isolated to 1.19.2 idk
checking with just iris now
i am spamming illager banners everywhere
any update?
i can confirm
yeah, still happening in the iris only install
the front one is flickering a lot, the angled one showed up once i placed the one in the back
1.19.4 too?
1.19.2
i'm testing on 1.19.4 rn
i don't have a 1.19.4 install to test, but i can set one up
nah
i'll test 1.19.2
and sorry IMS
ok i got it
only on 1.19.2
so it's not super high priority
but i'll look into it
if you can point me in the right direction, i'm happy to tinker. I don't know much about rendering but i know a little java
I might have noticed it before Iris 1.6.0 was released, if I wasn't a shit.
no one would have noticed this
it only happens on one version in a specific case
nah, it's fine
this bug is probably rooted deep in the batching algorithm
which literally no one, not even me, fully understands
lol that makes me more curious, i can't promise i won't dig. if i do, i'll holler if i find anything
sounds good
thanks for the fast response!
no problem
and sorry for not noticing this
no worries
I played twice Minecraft 1.19.2 with Iris 1.6.0 betas, once to see how the banners look like...
https://github.com/IrisShaders/Iris/commit/bc17e54a40961b3958ca40a9eacfc017f30d1bc2 @IMS
It's my fault
@Lolothepro30 | Dieu 🚀🇫🇷
“I tried reverting the fix banners commit to see if it was responsible”
it wasn’t
wait...
It's not possible
This does not happen with Beta 5
wait...
This is a bug in Beta 6
it starts in this commit:
ae198d2: Setup. something to do with the new item rendering(?)pain