C#•2y ago

❔ (Unsolved) writing from binary file to listbox

My teacher gave me code to implement for a highscore thing with binary files but in the code she gave us theres 2 undefined methods and ive no idea what they are supposed to even do. Anyone have any idea?

34 Replies

cgxlmOP•2y ago

        public static void WriteEndScore()
        {
            FileStream highscoreFilstream = new FileStream("highscore.bin", FileMode.Append); // allows the scores to be appeneded
            BinaryWriter binWriter = new BinaryWriter(highscoreFilstream);

            binWriter.Write(Convert.ToString(Game.currentUsername));
            binWriter.Write(Convert.ToString(Game.currentScore));

            binWriter.Flush();
            binWriter.Close();
        }

        public static int countScores()
        {
            FileStream scoreFilstream = File.OpenRead("highscore.bin");
            BinaryReader binaryReader = new BinaryReader(scoreFilstream);
            int countScores = 0;

            while (binaryReader.PeekChar() != -1)
            {
                string username = binaryReader.ReadString();
                string score = binaryReader.ReadString();
                countScores++;
            }
            binaryReader.Close();
            return countScores;
        }

        public static void WriteEndScore()
        {
            FileStream highscoreFilstream = new FileStream("highscore.bin", FileMode.Append); // allows the scores to be appeneded
            BinaryWriter binWriter = new BinaryWriter(highscoreFilstream);

            binWriter.Write(Convert.ToString(Game.currentUsername));
            binWriter.Write(Convert.ToString(Game.currentScore));

            binWriter.Flush();
            binWriter.Close();
        }

        public static int countScores()
        {
            FileStream scoreFilstream = File.OpenRead("highscore.bin");
            BinaryReader binaryReader = new BinaryReader(scoreFilstream);
            int countScores = 0;

            while (binaryReader.PeekChar() != -1)
            {
                string username = binaryReader.ReadString();
                string score = binaryReader.ReadString();
                countScores++;
            }
            binaryReader.Close();
            return countScores;
        }

public static void ScoreArray(string[,] scoreArray)
        {
            FileStream highscoreFilstream = File.OpenRead("highscore.bin");
            BinaryReader binaryReader = new BinaryReader(highscoreFilstream);

            int arraySize = countScores();

            for (int x = 0; x < arraySize; x++)
            {
                scoreArray[x, 0] = binaryReader.ReadString();
                scoreArray[x, 1] = binaryReader.ReadString();
            }
            binaryReader.Close();
        }

        public static string[,] HighScoreArray(string[,] highscoreArray)
        {
            int countScore = countScores();

            if (countScore > 1)
            {
                SortHighScore(highscoreArray, countScore);
            }
            return highscoreArray;
        }

        public static void SortHighScore(string[,] highscoreArray, int countScores)
        {
            string username = "";
            string score = "";
            for (int i = 0; i < countScores; i++)
            {
                for (int scoreNumber = 0; scoreNumber < countScores - 1; scoreNumber++)
                {
                    if (Convert.ToInt32(highscoreArray[scoreNumber, 1]) < Convert.ToInt32(highscoreArray[scoreNumber + 1, 1]))
                    {
                        username = highscoreArray[scoreNumber + 1, 0];
                        score = highscoreArray[scoreNumber + 1, 1];

                        SetNextItem(highscoreArray, scoreNumber);
                        SetCurrentItem(highscoreArray, scoreNumber, username, score);
                    }
                }
            }
        }

public static void ScoreArray(string[,] scoreArray)
        {
            FileStream highscoreFilstream = File.OpenRead("highscore.bin");
            BinaryReader binaryReader = new BinaryReader(highscoreFilstream);

            int arraySize = countScores();

            for (int x = 0; x < arraySize; x++)
            {
                scoreArray[x, 0] = binaryReader.ReadString();
                scoreArray[x, 1] = binaryReader.ReadString();
            }
            binaryReader.Close();
        }

        public static string[,] HighScoreArray(string[,] highscoreArray)
        {
            int countScore = countScores();

            if (countScore > 1)
            {
                SortHighScore(highscoreArray, countScore);
            }
            return highscoreArray;
        }

        public static void SortHighScore(string[,] highscoreArray, int countScores)
        {
            string username = "";
            string score = "";
            for (int i = 0; i < countScores; i++)
            {
                for (int scoreNumber = 0; scoreNumber < countScores - 1; scoreNumber++)
                {
                    if (Convert.ToInt32(highscoreArray[scoreNumber, 1]) < Convert.ToInt32(highscoreArray[scoreNumber + 1, 1]))
                    {
                        username = highscoreArray[scoreNumber + 1, 0];
                        score = highscoreArray[scoreNumber + 1, 1];

                        SetNextItem(highscoreArray, scoreNumber);
                        SetCurrentItem(highscoreArray, scoreNumber, username, score);
                    }
                }
            }
        }

at the very botton its the SetNextItem(highscoreArray, scoreNumber); SetCurrentItem(highscoreArray, scoreNumber, username, score);

Angius•2y ago

at the use of BinaryWriter and Convert, but I guess teachers be teachers and they're all stuck in 1999 Judging by the name of those methods, they're supposed to set an item to some value in the array SetNextItem is probably supposed to do something like highScoreArray[i + 1] = scoreNumber Although, scoreNumber seems to be an index in the array So rather something like highScoreArray[scoreNumber + 1] = ??? SetCurrentItem seems a bit more obvious, probably something akin to

highScoreArray[scoreNumber] = { username, score.ToString() }

highScoreArray[scoreNumber] = { username, score.ToString() }

Which is kinda atrocious in its own right But, again, teachers being shit is kind of the norm

cgxlmOP•2y ago

yeah idek she gave like me and 2 others this way of doing it as the 'harder' way and honestly i dont understand arrays much cause she skipped over that when teaching so i just try and avoid them as much as possible. Ill try putting something like those you gave in to see

Angius•2y ago

Arrays are super simple tbh An array is a collection of items That's it

cgxlmOP•2y ago

yeah like i understand what it is i just dk how to use them properly

Angius•2y ago

To store multiple of the same kind of item That's their one and only use

cgxlmOP•2y ago

Yeah i mean as in like the actual code like what i write to use them, like its mainly the 2d arrays that idk

Angius•2y ago

   0 1 2 3 4
0  a|b|c|d|e
1  f|g|h|i|j
2  k|l|m|n|o

   0 1 2 3 4
0  a|b|c|d|e
1  f|g|h|i|j
2  k|l|m|n|o

arr[0, 2] will refer to k in this case That's all about a 2D array

cgxlmOP•2y ago

Ohh k when i was trying to learn them in like the theory books she gave us it was so confusing

Accord•2y ago

Was this issue resolved? If so, run /close - otherwise I will mark this as stale and this post will be archived until there is new activity.

cgxlmOP•2y ago

Ok so i have a new error now

cgxlmOP•2y ago

cgxlmOP•2y ago

cgxlmOP•2y ago

the scoreboard for some reason keeps repeating admin: 2 whn it should only be there once

private void Score_Load(object sender, EventArgs e)
        {
            listBox1.Items.Clear();
            listBox1.SelectionMode = SelectionMode.None;
            int scoresAmount = Tools.countScores();

            // Create a new array for blackjack scores
            string[,] blackjackScores = new string[scoresAmount, 2];

            // Populate the blackjack scores array
            Tools.ScoreArray(blackjackScores);

            // Sort the blackjack scores in descending order
            blackjackScores = Tools.HighScoreArray(blackjackScores);

            // Display the top 5 scores in the list box
            for (int i = 0; i < 5 && i < blackjackScores.GetLength(0); i++)
            {
                string username = blackjackScores[i, 0];
                string score = blackjackScores[i, 1];
                listBox1.Items.Add($"{username}:\t {score}\n");
            }
        }

private void Score_Load(object sender, EventArgs e)
        {
            listBox1.Items.Clear();
            listBox1.SelectionMode = SelectionMode.None;
            int scoresAmount = Tools.countScores();

            // Create a new array for blackjack scores
            string[,] blackjackScores = new string[scoresAmount, 2];

            // Populate the blackjack scores array
            Tools.ScoreArray(blackjackScores);

            // Sort the blackjack scores in descending order
            blackjackScores = Tools.HighScoreArray(blackjackScores);

            // Display the top 5 scores in the list box
            for (int i = 0; i < 5 && i < blackjackScores.GetLength(0); i++)
            {
                string username = blackjackScores[i, 0];
                string score = blackjackScores[i, 1];
                listBox1.Items.Add($"{username}:\t {score}\n");
            }
        }

and thats the code for putting it in the listbox the other methods are up above

cgxlmOP•2y ago

https://paste.mod.gg/wcsrmzqpvwba/0

BlazeBin - wcsrmzqpvwba

A tool for sharing your source code with the world!

cgxlmOP•2y ago

i cant get it to work no matter what i do ive been trying the past like 2 hours nearly hello

Angius•2y ago

Use the debugger, see what blackjackScores are

cgxlmOP•2y ago

by like putting in something like this? MessageBox.Show(Convert.ToString(blackjackScores));

Angius•2y ago

$debug

MODiX•2y ago

https://docs.microsoft.com/en-us/visualstudio/get-started/csharp/tutorial-debugger?view=vs-2022

Tutorial: Debug C# code - Visual Studio (Windows)

Learn features of the Visual Studio debugger and how to start the debugger, step through code, and inspect data in a C# application.

cgxlmOP•2y ago

Angius•2y ago

Expand it

cgxlmOP•2y ago

They all say null

cgxlmOP•2y ago

Angius•2y ago

Step forward Does Tools.ScoreArray() fill the array with values?

cgxlmOP•2y ago

this is the ScoreArray method

cgxlmOP•2y ago

cgxlmOP•2y ago

its filled with the correct values but it displays it wrong just

cgxlmOP•2y ago

it must be something to do with the sorting then cause after that line it goes to this

Angius•2y ago

Probably, yes

cgxlmOP•2y ago

        public static void SetNextItem(string[,] HighScores, int ScoreNo)
        {
            for (int i = HighScores.GetLength(0) - 1; i > ScoreNo; i--)
            {
                HighScores[i, 0] = HighScores[i - 1, 0];
                HighScores[i, 1] = HighScores[i - 1, 1];
            }
        }

        public static void SetNextItem(string[,] HighScores, int ScoreNo)
        {
            for (int i = HighScores.GetLength(0) - 1; i > ScoreNo; i--)
            {
                HighScores[i, 0] = HighScores[i - 1, 0];
                HighScores[i, 1] = HighScores[i - 1, 1];
            }
        }

its this method is where it goes wrong

Angius•2y ago

¯\_(ツ)_/¯ I'll be honest, using a 2D array here instead of good and proper array of classes/records/structs muddies the waters a little too much for my liking Use the debugger and see ig

cgxlmOP•2y ago

alright thanks for trying though

Accord•2y ago

Was this issue resolved? If so, run /close - otherwise I will mark this as stale and this post will be archived until there is new activity.

Gaming

Programming

❔ (Unsolved) writing from binary file to listbox