N
Novu2y ago
Kristof

Notification changes failing

Hi, I disable a trigger in development and then pushed the change to production to have it disabled there. I then modified the notification template in development and reenabled it. The changes showed 2 changes for the specific notification. I promoted one and when I wanted to promote the other I got a server error. The updated template went to production but the enabling of the trigger did not. Now whenever I update the template in development I get a 500 and there is no change to promote, but the change in the notification in development is persisted. Could someone help me fix this? Happy to provide more information if needed.
18 Replies
Pawan Jain
Pawan Jain2y ago
Let me try to reproduce this Hi Kristof, I tried with same steps. Could not reproduce Can you please share screen recording of steps?
Kristof
KristofOP2y ago
I cannot reproduce it, but the error persists as seen in the screen recording
Pawan Jain
Pawan Jain2y ago
can you please try reproducing after promoting all changes
Kristof
KristofOP2y ago
You want me to reproduce the whole situation with another notification or trigger the error again
Pawan Jain
Pawan Jain2y ago
whole situation with another notification
Kristof
KristofOP2y ago
I cannot reproduce either :/ Could you help me fix the broken notification? I got another notification with the same error. I cannot systematically reproduce it. There is a situation where disabling the notification and updating something, generates 2 changes. Promoting one of the 2 changes (not sure which one) causes the other one to crash and from there on it is not possible to change the notification in production
Gali Baum
Gali Baum2y ago
@Pawan Jain I wasn't able to reproduce exactly (the error and crash), but there is definitely something odd in the behavior of status change. Also, there should be only one change or have them dependent, and not have 2 rows that could create inconsistency depending on what was promoted. I think we should open a bug on this one. Wdyt? Also sending you something that I found on Sentry that might be related
Kristof
KristofOP2y ago
Ping me if you want me to retrigger the error
Pawan Jain
Pawan Jain2y ago
Thanks Gali
Gali Baum
Gali Baum2y ago
@kristofdt could you please retrigger it ?
Kristof
KristofOP2y ago
@galiainouz triggered
Gali Baum
Gali Baum2y ago
Thanks! I am opening a bug about this, I wasn't able to reproduce, but I can see something odd is happening. Will need some research here.
Linear
Linear2y ago
Issue NV-1927 created.
Kristof
KristofOP2y ago
I have 2 questions: - Can you do something to fix the specific state of the notification that is not working? - Could you make the enabling/disabling of notifications an env specific setting that does not need to be promoted? To be able to disable a notification on production without having to disable it in development first?
Gali Baum
Gali Baum2y ago
1- yes, @dimagrossman could you please help with that? 2- Interesting, I tend to agree with you. Makes sense to me @omerbenami @dimagrossman wdyt?
Dima Grossman
Dima Grossman2y ago
Yep, I think that will make sense to allow this to be changed env specific Are you using the managed cloud version?
Kristof
KristofOP2y ago
Yes
Novu_Bot
Novu_Bot2y ago
@kristofdt, you just advanced to level 4!

Did you find this page helpful?