Topics

SolidJS•2y ago

Sun「無用」

createResource returning undefined when data is fetched

I'm just learning solid and did something like a hook? maybe? dunno. Anyways, I'm just calling createResource with a fetch on it and returning it's json. But, for any reason, that fn is returning undefined, even when the data is properly fetched("tested" by logging the json). Code:

const useFetch = <T>(p: UseFetchParams) => {
  const [url] = createSignal(createUrl(p));

  const [data] = createResource<T>(async () => {
    return await fetch(url()).then(async (res) => (await res.json()) as T);
  });

  return { data, didFetch: data() !== undefined };
};

const useFetch = <T>(p: UseFetchParams) => {
  const [url] = createSignal(createUrl(p));

  const [data] = createResource<T>(async () => {
    return await fetch(url()).then(async (res) => (await res.json()) as T);
  });

  return { data, didFetch: data() !== undefined };
};

75 Replies

Sun「無用」OP•2y ago

If I do something like console.log(data()) it would be undefined, every time I try to use it.

REEEEE•2y ago

Will url have an initial value when the resource is called? I see you're calling createUrl(p) but does it return a url when the useFetch is used? My guess is that the resource isn't rerun

Sun「無用」OP•2y ago

what?

REEEEE•2y ago

If you want the resource to rerun based on the url signal then you need to pass it in as a source as the first parameter of createResource

Sun「無用」OP•2y ago

I'm not wanting to rerun it yet Just wanting for it to work.

REEEEE•2y ago

Okay, try replacing url() with a static url to fetch from

Sun「無用」OP•2y ago

...

REEEEE•2y ago

I'm trying to see where the issue is

Sun「無用」OP•2y ago

https://prnt.sc/xDQzLjJA_y_l

Lightshot

Captured with Lightshot

REEEEE•2y ago

What?

Sun「無用」OP•2y ago

. I didn't understand anything from that

REEEEE•2y ago

Okay, here try this.

const useFetch = <T>(p: UseFetchParams) => {
  const [url] = createSignal(createUrl(p));

  const [data] = createResource<T>(async () => {
    return await fetch('https://jsonplaceholder.typicode.com/posts').then(async (res) => (await res.json()) as T);
  });

  return { data, didFetch: data() !== undefined };
};

const useFetch = <T>(p: UseFetchParams) => {
  const [url] = createSignal(createUrl(p));

  const [data] = createResource<T>(async () => {
    return await fetch('https://jsonplaceholder.typicode.com/posts').then(async (res) => (await res.json()) as T);
  });

  return { data, didFetch: data() !== undefined };
};

Does this return not undefined

Sun「無用」OP•2y ago

That'll return undefined since it's the same code

REEEEE•2y ago

You tried it?

Sun「無用」OP•2y ago

It's the same code, it should have the same output. If your question is if the url is valid, yes it is correct.

REEEEE•2y ago

https://playground.solidjs.com/anonymous/604b2575-75c7-44aa-ab1f-4c487cb64dc6

Solid Playground

Quickly discover what the solid compiler will generate from your JSX template

REEEEE•2y ago

It doesn't have the same output,

Sun「無用」OP•2y ago

it should have, though.

REEEEE•2y ago

Why?

Sun「無用」OP•2y ago

. and the url is valid.

REEEEE•2y ago

The issue is the url that the resource is trying to access. Meaning, url doesn't have a valid value. If you console.log url() inside the resource before the return what do you get?

Sun「無用」OP•2y ago

A valid url. Like I said, the url is valid.

REEEEE•2y ago

the url itself that you want to fetch from might be valid. I'm saying that the url signal doesn't have a valid value yet Yes, I understand

Sun「無用」OP•2y ago

yes, it does. It literally fetchs. If I do this

createResource(async () => await fetch(url()).then(res => {
  console.log(res)
  return res.json();  
}));

createResource(async () => await fetch(url()).then(res => {
  console.log(res)
  return res.json();  
}));

This would print a valid response But the return of createResource would still be undefined

REEEEE•2y ago

okay, so where are you using the data value?

Sun「無用」OP•2y ago

In a component

REEEEE•2y ago

Could you show how you're using it? I can't seem to replicate it, so the issue could be something else Or make a reproduction in the playground

Sun「無用」OP•2y ago

const {data} = useFetch({url})}}

REEEEE•2y ago

Where is the data function being used?

Sun「無用」OP•2y ago

Im passing to other components why is that relevant?

REEEEE•2y ago

Because I can't replicate the issue, so it could be something else. If you think the issue is still createResource, can you make a minimal reproduction of the issue in the playground

Sun「無用」OP•2y ago

done

useFetch.ts

REEEEE•2y ago

Okay, putting this in the playground I don't get undefined https://playground.solidjs.com/anonymous/8e08f3af-dcea-482d-a1cd-1de21d46fbec

Solid Playground

Quickly discover what the solid compiler will generate from your JSX template

REEEEE•2y ago

So, the issue could be something else..

Sun「無用」OP•2y ago

solid problem them bc it doesnt work locally

REEEEE•2y ago

It could be how you're using the data value Could you show how you're using it? You say you're passing it to components, but how are the components using it?

Sun「無用」OP•2y ago

Im just doing prop spreading. { ...data() }

REEEEE•2y ago

okay, what if you do {...data()}

Sun「無用」OP•2y ago

I just did a typo there, not used to solid

REEEEE•2y ago

Ah okay. Hmm and console logging the data in a createEffect like I did in the playground example still prints out undefined? in the parent component that uses the useFetch

Sun「無用」OP•2y ago

yes, even if I do it outside or ir inside a createEfct

REEEEE•2y ago

outside a createEffect it will be undefined

Sun「無用」OP•2y ago

the data is just always undedined

REEEEE•2y ago

Okay, the best way for me to help you find out the issue is if you can make a reproduction in the playground I'm not getting any info to be able to tell what the issue is

Sun「無用」OP•2y ago

sec, my laptop's keyboard is a bit broken

Sun「無用」OP•2y ago

https://playground.solidjs.com/anonymous/393cfa9f-7c19-4ff9-baf6-05fb82fbf4d9 same thing as local

Solid Playground

Quickly discover what the solid compiler will generate from your JSX template

Sun「無用」OP•2y ago

Kinda same, at least

REEEEE•2y ago

https://playground.solidjs.com/anonymous/101df551-8103-47e3-a78a-adf8f8c89263

Solid Playground

Quickly discover what the solid compiler will generate from your JSX template

REEEEE•2y ago

replace use of didFetch with joke()

REEEEE•2y ago

https://playground.solidjs.com/anonymous/3771abfd-bbc5-43c3-be5e-a518ca191412 Or make didFetch a function

Solid Playground

Quickly discover what the solid compiler will generate from your JSX template

Sun「無用」OP•2y ago

? that shouldn't change anything?

REEEEE•2y ago

didFetch isn't reactive

Sun「無用」OP•2y ago

what about it?

REEEEE•2y ago

so it will always be false

Sun「無用」OP•2y ago

But if I do it without the show, it's still undefined.

REEEEE•2y ago

https://playground.solidjs.com/anonymous/28032ab3-f09c-4cb1-a969-8bca41e60d3e Without show

Solid Playground

Quickly discover what the solid compiler will generate from your JSX template

Sun「無用」OP•2y ago

Locally it goes to the fallback forever

REEEEE•2y ago

Which fallback? I removed Show in that example

Sun「無用」OP•2y ago

It just shows nothing* It's undefined. And why does a random fn changes everything?

REEEEE•2y ago

Because variables aren't reactive

const [signal, setSignal] = createSignal(1)

const nextValue = signal()

const nextValueFn = () => signal()

const [signal, setSignal] = createSignal(1)

const nextValue = signal()

const nextValueFn = () => signal()

Here nextValue won't update when the signal changes, but nextValueFn will

Sun「無用」OP•2y ago

But both are calling the signal both of them should be changed

REEEEE•2y ago

Yes, but in Solid only functions are tracked and updated It's the reason why using console.log outside a createEffect won't update

const [signal, setSignal] = createSignal(1)

console.log(signal())

const [signal, setSignal] = createSignal(1)

console.log(signal())

This will print 1 and then never print when the signal updates

Sun「無用」OP•2y ago

and wait, that doesn't work.

REEEEE•2y ago

If you want to use didFetch without using a function explicitly, you can do it this way https://playground.solidjs.com/anonymous/5ec53eb0-36be-4358-9af0-d7487f6adcad But you can't destructure the return of useFetch

Solid Playground

Quickly discover what the solid compiler will generate from your JSX template

Sun「無用」OP•2y ago

https://prnt.sc/nInWrBQEVKhl Locally.

<div class={styles.App}>
  <h1>Joke:</h1>
  <Show when={didFetch()} fallback={<p>Could not load the joke.</p>}>
    <Joke setup={joke()!.setup} punchline={joke()!.punchline} />
  </Show>
</div>

<div class={styles.App}>
  <h1>Joke:</h1>
  <Show when={didFetch()} fallback={<p>Could not load the joke.</p>}>
    <Joke setup={joke()!.setup} punchline={joke()!.punchline} />
  </Show>
</div>

Lightshot

Captured with Lightshot

REEEEE•2y ago

hmmm didFetch is a function?

return { data, didFetch: () => data() !== undefined };

return { data, didFetch: () => data() !== undefined };

Sun「無用」OP•2y ago

yes, I'm even calling it.

REEEEE•2y ago

Hmmm, and the fallback isn't showing?

Sun「無用」OP•2y ago

no, just a blank page which just means it's undefined.

REEEEE•2y ago

Any errors in the console? Because if nothing is showing up then it's something else At least Joke: should be showing

Sun「無用」OP•2y ago

No, just vite stuff.

REEEEE•2y ago

The browser console?

Sun「無用」OP•2y ago

Both.

REEEEE•2y ago

If <h1>Joke:</h1> from here is not showing up, it must be something else

<div class={styles.App}>
  <h1>Joke:</h1>
  <Show when={didFetch()} fallback={<p>Could not load the joke.</p>}>
    <Joke setup={joke()!.setup} punchline={joke()!.punchline} />
  </Show>
</div>

<div class={styles.App}>
  <h1>Joke:</h1>
  <Show when={didFetch()} fallback={<p>Could not load the joke.</p>}>
    <Joke setup={joke()!.setup} punchline={joke()!.punchline} />
  </Show>
</div>

Carlo Nyte•2y ago

Was this ever resolved?

Solid is a declarative reactive Javascript library for creating user interfaces.

12KMembers

View on Discord

Did you find this page helpful?