cc issue with SendinBlue
Hi, the latest issue broke the integration with SendinBlue. We cannot send emails since the cc field is missing. This field does not need to be set for our use case. There is also no documentation on how we can specify this. Could you please have a look?
16 Replies
After looking into the code we found that the cc is impossible to set. In the email handler the object that is the input for the provider. This object does not have any cc or bcc fields https://github.dev/novuhq/novu/blob/f6138df86a8f61f01cce2880ac7cce4b0305db07/packages/stateless/src/lib/handler/email.handler.ts#L103
Once in the sendinblue provider these properties are set accourding to the sdk specs see image. https://github.com/novuhq/novu/blob/79418d06dfac5c5e8024afd73cee3355a8b26302/providers/sendinblue/src/lib/sendinblue.provider.ts#L37
The sendinBlue sdk should allow for null values, but this is somehow not actually the case. I think only adding the property if it is present in the options should fix this?
GitHub
novu/sendinblue.provider.ts at 79418d06dfac5c5e8024afd73cee3355a8b2...
The open-source notification infrastructure with fully functional embedded notification center - novu/sendinblue.provider.ts at 79418d06dfac5c5e8024afd73cee3355a8b26302 · novuhq/novu
@davidsouthmountain
Recently worked on overrides to support cc, bcc
I will look into this as soon as I am working
GitHub
fix: optional cc and bcc in email creation by KristofDeTroch · Pull...
What change does this PR introduce?
Fix for SendinBlue cc and bcc properties
Why was this change needed?
Because we cannot send mails!
Have approved and started the tests for it
If the tests succeed, when can we expect this kind of fix to move to production?
@kristofdt, you just advanced to level 3!
I will check if this will be included in the patch next week
Hosted or self hosted?
Hosted
Okay then you will have it first
We planned on going to production with this on Monday so this is actually quite urgent
Ping @dimagrossman
I'm deploying a hotfix for it today
Sorry for the inconvenience @kristofdt!
Uploaded the fix now 🙏
Verified that it works again 👍
We are working right now on e2e against real provider endpoints to avoid this from happening in the future
Yes, I do think that would be a great improvement. We currently did not have Novu in our production environment yet, but we cannot afford to not be able to send emails for 2 days.