Sapphire - Imagine a Framework•3y ago

Eventho runIn has values Guildtext and dm, if run in guild text, error message is shown

chilliheroOP•2/8/23, 11:28 PM

Not sure where to put Bugreports, but I dont think this is intendet behaviour

ararou•2/9/23, 12:57 AM

i think thats intended by framework

ararou•2/9/23, 12:57 AM

not too sure tho

ararou•2/9/23, 12:57 AM

and what is the issue anyway

ararou•2/9/23, 12:57 AM

can you elaborate

Favna•2/9/23, 9:35 AM

It should allow both... not sure what is going on there tbh.

Favna•2/9/23, 9:35 AM

would have to look into what preconditions it creates under the hood

Favna•2/9/23, 9:36 AM

and why the DM only one triggers when used in a guild text channel

Favna•2/9/23, 9:36 AM

assuming you tried it in a guild text channel

Favna•2/9/23, 9:36 AM

so that's NOT a thread, NOT a forum post and NOT a voice text channel

Favna•2/9/23, 9:44 AM

reading the code though you should get preconditions of and but I might have an inclination where it is going wrong

@kyra ��

�� @vladdy when you look at these bits of code:
https://github.com/sapphiredev/framework/blob/main/src/lib/structures/Command.ts#L414-L495

https://github.com/sapphiredev/framework/blob/main/src/lib/utils/preconditions/PreconditionContainerArray.ts#L127-L142

do you also draw the conclusion that the preconditions are added as instead of the expected ?

vladdy•2/9/23, 10:29 AM

did you really have to use github.dev

Favna•2/9/23, 10:29 AM

vladdy•2/9/23, 10:29 AM

it does work tho

Favna•2/9/23, 10:29 AM

well yes, much easier to navigate

vladdy•2/9/23, 10:29 AM

so I'll give you that

Favna•2/9/23, 10:29 AM

there changed the urls

Favna•2/9/23, 10:30 AM

I use github.dev quite a lot tbh

vladdy•2/9/23, 10:30 AM

you are right that its an AND check right now

vladdy•2/9/23, 10:30 AM

which is...weird

vladdy•2/9/23, 10:31 AM

and making it an OR check requires either a jank parent existing for no reason, or overriding a readonly property

vladdy•2/9/23, 10:32 AM

this is why we need preconditions v2

vladdy•2/9/23, 10:32 AM

ngl

vladdy•2/9/23, 10:32 AM

(internally, not externally)

Favna•2/9/23, 10:34 AM

So I forgot the exact syntax but I think as a temporary fix what you can do is instead of using use this @chillihero

vladdy•2/9/23, 10:35 AM

uhhh

vladdy•2/9/23, 10:35 AM

yeahh and removing runIn but we should really fix this someday

vladdy•2/9/23, 10:35 AM

I'm surprised nobody found it till now

vladdy•2/9/23, 10:35 AM

@kyra ��

�� you made it, you fix it please

FFavna So I forgot the exact syntax but I think as a temporary fix what you can do is i...

ararou•2/9/23, 12:53 PM

why the extra [

Favna•2/9/23, 12:54 PM

it makes preconditions in the "or" syntax

ararou•2/9/23, 12:54 PM

wtf

Favna•2/9/23, 12:54 PM

so it's DMOnly OR GuildText AND everything beyond it

Favna•2/9/23, 12:54 PM

in JS terms

Favna•2/9/23, 12:54 PM

yeah it's not the best syntax

Favna•2/9/23, 12:55 PM

we have https://github.com/sapphiredev/framework/issues/334 open to do

GitHub

request: easier syntax for combining preconditions · Issue #334 · s...

Is your feature request related to a problem? Please describe. Currently the way to combine preconditions is using nested arrays such as: [['AdminOnly', ['ModOnly', ...

ararou•2/9/23, 12:56 PM

i use and it checks if the user is blacklisted and if not, checks the channel the commands ran in and prevents it if the channel isn't in an array of bot cmd channels

ararou•2/9/23, 12:56 PM

works well so