C#•3y ago

✅ mistery -foreach cycle executed three times for no apparently reason

Here is the code.

I checked more and more times for errors, I always putted some breakpoint in order to see into variables, and I just seeing that when the cycle arrive at the last char contained in input (that's a string), it just rest all index to 0 and start again for a total of 3 executions.

Am I committing error somewhere?

ero

E

ero•1/17/23, 2:51 PM

that's not possible

uselessxp

U

uselessxpOP•1/17/23, 2:53 PM

yeah I know, usually stupid errors are committing by beginners in cycle statement, but in this case I'm really going crazy, I'm pretty sure all it's ok

uselessxp

U

uselessxpOP•1/17/23, 2:55 PM

it's like it re-execute those rows again, out of the cycle

ero

E

ero•1/17/23, 2:56 PM

can you show more of your code?

uselessxp

U

uselessxpOP•1/17/23, 2:56 PM

the only explanation is that the whole function is called more times

ero

E

ero•1/17/23, 2:56 PM

like where that method is being called?

ero

Eero like where that method is being called?

uselessxp

U

uselessxpOP•1/17/23, 2:56 PM

I think it's so picard_facepalm

picard_facepalm

uselessxp

U

uselessxpOP•1/17/23, 2:57 PM

ero

E

ero•1/17/23, 2:57 PM

you literally call that method 3 times yourself

uselessxp

U

uselessxpOP•1/17/23, 2:57 PM

damn

ero

E

ero•1/17/23, 2:57 PM

4 times even

ero

E

ero•1/17/23, 2:58 PM

is absolutely unnecessary (and a memory leak)

Angius

A

Angius•1/17/23, 2:58 PM

Call it once, save the result in the variable, reference that variable

Angius

A

Angius•1/17/23, 3:00 PM

Since you're using an unnamed tuple, you could even use tuple reconstruction to make everything nice and named

and will be in and will be in

uselessxp

U

uselessxpOP•1/17/23, 3:00 PM

yeah I like this

uselessxp

U

uselessxpOP•1/17/23, 3:01 PM

one of the first modifies I made to the code consist in this and I didn't want to reverrse it

Angius

AAngius Since you're using an unnamed tuple, you could even use tuple reconstruction to ...

uselessxp

U

uselessxpOP•1/17/23, 3:01 PM

is better than ?

Angius

A

Angius•1/17/23, 3:03 PM

is for type inference

uselessxp

U

uselessxpOP•1/17/23, 3:03 PM

oh ok I have to use it mandatory for avoid calling twice the method

Angius

A

Angius•1/17/23, 3:03 PM

It is if you assign a short to it

uselessxp

U

uselessxpOP•1/17/23, 3:05 PM

yeah but I also noticed that

does not works with also if I use everywhere

Angius

A

Angius•1/17/23, 3:12 PM

Wym "doesn't work"?

uselessxp

U

uselessxpOP•1/17/23, 3:12 PM

what do you think about converting rows like this:

to this:

could it be a good practice or it's stupid?

Angius

AAngius Wym "doesn't work"?

uselessxp

U

uselessxpOP•1/17/23, 3:13 PM

it doesn't seems to accept it, now I try again

Angius

A

Angius•1/17/23, 3:13 PM

the method has to actually return a tuple

MODiX

M

MODiX•1/17/23, 3:14 PM

REPL Result: Success

Console Output

Compile: 672.899ms | Execution: 88.116ms | React with ❌ to remove this embed.

uselessxp

U

uselessxpOP•1/17/23, 3:15 PM

and can't a tuple have a defined type?

uselessxp

U

uselessxpOP•1/17/23, 3:16 PM

that's what I tried to do

Angius

A

Angius•1/17/23, 3:16 PM

No

Angius

A

Angius•1/17/23, 3:16 PM

Because a tuple can contain a string and an int, for example

Angius

A

Angius•1/17/23, 3:16 PM

Tuple deconstruction needs

uselessxp

U

uselessxpOP•1/17/23, 3:18 PM

ok

uselessxp

U

uselessxpOP•1/17/23, 3:19 PM

as I know, in DB a tuple is a row
I'm reading that a tuple in C# can contains multiple values, isn't like an array so?

Angius

A

Angius•1/17/23, 3:20 PM

Kinda-sorta

Angius

A

Angius•1/17/23, 3:20 PM

Something between an array and an object

uselessxp

U

uselessxpOP•1/17/23, 3:21 PM

interesting

ero

E

ero•1/17/23, 3:23 PM

or

Angius

AAngius Because a tuple can contain a string and an int, for example

uselessxp

U

uselessxpOP•1/17/23, 3:23 PM

that's make sense. but I realized I have to use also if all variables are same type

ero

Eero or `(short a, short b) = ...`

uselessxp

U

uselessxpOP•1/17/23, 3:24 PM

working in this way, but not working if I put short out, doesn't it understand that I want both short maybe

Angius

A

Angius•1/17/23, 3:24 PM

Show the code that doesn't work

Angius

A

Angius•1/17/23, 3:25 PM

Because if you're using tuples, tuple deconstruction can't not work

uselessxp

U

uselessxpOP•1/17/23, 3:25 PM

Angius

A

Angius•1/17/23, 3:25 PM

Well, yeah

Angius

A

Angius•1/17/23, 3:25 PM

Because it's not a

Angius

A

Angius•1/17/23, 3:26 PM

It's

uselessxp

U

uselessxpOP•1/17/23, 3:26 PM

that's ok

uselessxp

U

uselessxpOP•1/17/23, 3:26 PM

but

uselessxp

U

uselessxpOP•1/17/23, 3:26 PM

why at this point not requiring

Angius

A

Angius•1/17/23, 3:27 PM

Sure, you can

Angius

A

Angius•1/17/23, 3:27 PM

But why if you can

using System.Collections;
using System.Text;

namespace AOC_2015_1
{
    internal class DayOnePartTwo
    {
        static void Main(string[] args)
        {
            string? input;
            Console.WriteLine("Where should I delivery the next gift?");
            Console.SetIn(new StreamReader(Console.OpenStandardInput(), Encoding.UTF8, false, 8192));
            input = Console.ReadLine();
            if (GiftDelivery(input).Item2 == 1337) Console.WriteLine($"Final floor is {GiftDelivery(input).Item1} and Santa never entered the basement");
            else Console.WriteLine($"Final floor is {GiftDelivery(input).Item1} and the first time when Santa enter the basement is {GiftDelivery(input).Item2}");
        }

        static (short, short) GiftDelivery(string input)
        {
            short floor = 0;
            const char floorUpChar = '(';
            const char floorDownChar = ')';
            short x = 0; //for the cycle
            short y = 0; //for the basement check
            List<short> basement = new();

            foreach (char c in input)
            {
                if (floor == -1)
                {
                    basement.Add(y);
                    Console.WriteLine("asd " + basement[x]);
                    x++;
                }
                if (c == floorUpChar)
                {
                    floor++;
                    y++;
                }
                else if (c == floorDownChar)
                {
                    floor--;
                    y++;
                }
            }

            if (basement.Count == 0) return (floor, 1337);
            else return (floor, basement[0]);
        }
    }
}

using System.Collections;
using System.Text;

namespace AOC_2015_1
{
    internal class DayOnePartTwo
    {
        static void Main(string[] args)
        {
            string? input;
            Console.WriteLine("Where should I delivery the next gift?");
            Console.SetIn(new StreamReader(Console.OpenStandardInput(), Encoding.UTF8, false, 8192));
            input = Console.ReadLine();
            if (GiftDelivery(input).Item2 == 1337) Console.WriteLine($"Final floor is {GiftDelivery(input).Item1} and Santa never entered the basement");
            else Console.WriteLine($"Final floor is {GiftDelivery(input).Item1} and the first time when Santa enter the basement is {GiftDelivery(input).Item2}");
        }

        static (short, short) GiftDelivery(string input)
        {
            short floor = 0;
            const char floorUpChar = '(';
            const char floorDownChar = ')';
            short x = 0; //for the cycle
            short y = 0; //for the basement check
            List<short> basement = new();

            foreach (char c in input)
            {
                if (floor == -1)
                {
                    basement.Add(y);
                    Console.WriteLine("asd " + basement[x]);
                    x++;
                }
                if (c == floorUpChar)
                {
                    floor++;
                    y++;
                }
                else if (c == floorDownChar)
                {
                    floor--;
                    y++;
                }
            }

            if (basement.Count == 0) return (floor, 1337);
            else return (floor, basement[0]);
        }
    }
}

(short item1, short item2) = GiftDelivery(Console.ReadLine());     //works
var (item1, item2) = GiftDelivery(Console.ReadLine());     //works
short (item1, item2) = GiftDelivery(Console.ReadLine());     //does not works

(short item1, short item2) = GiftDelivery(Console.ReadLine());     //works
var (item1, item2) = GiftDelivery(Console.ReadLine());     //works
short (item1, item2) = GiftDelivery(Console.ReadLine());     //does not works