N
Novu•2y ago
empe

Adding an SMS provider without a node client

I working on this issue: https://github.com/novuhq/novu/issues/30 And I see that Transmit SMS doesn't have a node client. Any ideas on how can I add the provider anyway? (Use Axios maybe? Or just by making HTTP requests separately?
GitHub
[NV-184] - Add support for TransitSMS · Issue #30 · novuhq/novu
I'm submitting a feature request Summary TransitSMS is a popular SMS provider in Australia and New Zealand. Documentation: https://developer.transmitsms.com/ Other information I'll ...
7 Replies
DavidSouthmountain
DavidSouthmountain•2y ago
node-fetch is a great library to use in this case
empe
empeOP•2y ago
@davidsouthmountain How I could test the provider?
DavidSouthmountain
DavidSouthmountain•2y ago
with an test account for tansitsms
Zac Clifton
Zac Clifton•2y ago
Why is node-fetch your choice for this instead of making an internal api wrapper for it?
DavidSouthmountain
DavidSouthmountain•2y ago
Because in 99.9% of the cases we only need one endpoint in providers api What Emil is creating is basically an internal api wrapper 😉
Zac Clifton
Zac Clifton•2y ago
Thanks for the explanation!
DavidSouthmountain
DavidSouthmountain•2y ago
No problem and with node-fetch it is easy to later on replace it with the native support in nodejs for fetch
Want results from more Discord servers?
Add your server