C#•2y ago

No route matches supplied values but values seem to match?

Hi I am getting this error on return CreatedAtAction:

System.InvalidOperationException: No route matches the supplied values.

System.InvalidOperationException: No route matches the supplied values.

            var response = new UserResponse(
                user.Id,
                user.ProductId,
                user.Username,
                user.Role,
                user.CreatedOnUtc);

            var actionName = nameof(GetByIdAsync);
            var routeValues = new {productId, id = user.Id, cancellationToken};

            return CreatedAtAction(actionName, routeValues, response);

            var response = new UserResponse(
                user.Id,
                user.ProductId,
                user.Username,
                user.Role,
                user.CreatedOnUtc);

            var actionName = nameof(GetByIdAsync);
            var routeValues = new {productId, id = user.Id, cancellationToken};

            return CreatedAtAction(actionName, routeValues, response);

[HttpGet("{id:guid}")]
    public async Task<ActionResult> GetByIdAsync(Guid productId, Guid id,
        CancellationToken cancellationToken = default)
    {

[HttpGet("{id:guid}")]
    public async Task<ActionResult> GetByIdAsync(Guid productId, Guid id,
        CancellationToken cancellationToken = default)
    {

But how are the route values incorrect when im giving it productId and the userId? To note, they also exist in the same controller and user.Id + productId are both guids (productId comes from parameter).Dont really understand what im missing here, let me know if you need me to provide more information

18 Replies

Angius•2y ago

Could be because of the cancellation token? Never in my life have I seen a controller action that would take a cancellation token

JuicyOP•2y ago

oh I just assumed its used there lmao cause I was using it everywhere else ok I removed cancellation token but I still get the same error

Angius•2y ago

Could you show the updated code?

JuicyOP•2y ago

Yep gimme a sec

    [HttpPost("register")]
    public async Task<ActionResult> RegisterAsync(Guid productId, [FromBody] CreateUserRequest request)
    {
        var user = await _userService.CreateAsync(
            productId,
            request.Username,
            request.Password,
            request.Role,
            request.Hwid,
            request.Ip,
            request.LicenseKey);

        var response = new UserResponse(
            user.Id,
            user.ProductId,
            user.Username,
            user.Role,
            user.CreatedOnUtc);

        var actionName = nameof(GetByIdAsync);
        var routeValues = new {productId, id = user.Id};

        return CreatedAtAction(actionName, routeValues, response);
    }

    [HttpPost("register")]
    public async Task<ActionResult> RegisterAsync(Guid productId, [FromBody] CreateUserRequest request)
    {
        var user = await _userService.CreateAsync(
            productId,
            request.Username,
            request.Password,
            request.Role,
            request.Hwid,
            request.Ip,
            request.LicenseKey);

        var response = new UserResponse(
            user.Id,
            user.ProductId,
            user.Username,
            user.Role,
            user.CreatedOnUtc);

        var actionName = nameof(GetByIdAsync);
        var routeValues = new {productId, id = user.Id};

        return CreatedAtAction(actionName, routeValues, response);
    }

    [HttpGet("{id:guid}")]
    public async Task<ActionResult> GetByIdAsync(Guid productId, Guid id)
    {
        var user = await _userService.GetByIdAsync(productId, id);

        var response = new UserResponse(
            user.Id,
            user.ProductId,
            user.Username,
            user.Role,
            user.CreatedOnUtc);

        return Ok(response);
    }

    [HttpGet("{id:guid}")]
    public async Task<ActionResult> GetByIdAsync(Guid productId, Guid id)
    {
        var user = await _userService.GetByIdAsync(productId, id);

        var response = new UserResponse(
            user.Id,
            user.ProductId,
            user.Username,
            user.Role,
            user.CreatedOnUtc);

        return Ok(response);
    }

Angius•2y ago

I wonder if making the return type Task<IActionResult<UserResponse>> would change anything... I don't think it would, but might be worth a shot Everything else looks perfectly fine

JuicyOP•2y ago

Alright let me try I get this

JuicyOP•2y ago

Angius•2y ago

Ah, so ActionResult<UserResponse>

JuicyOP•2y ago

oh whops

Angius•2y ago

I can never remember if it's the interface or the actual type that's generic, my bad

JuicyOP•2y ago

Ok I get the same error its been driving me nuts because it seems fine as you said I even googled examples on how to use CreatedOnAction and tried following them 1:1 lol Could something in my service be affecting it..? even though ive debugged it and it does reach all the way down to CreatedOnAction...

Angius•2y ago

Two more thoughts: 1. Try writing the action name manually instead of nameof(). Try "GetById", "getbyid", "getbyidasync", different combinations 2. In the route parameters object, try passing only one of them, either the productId or the id Trial and error is all I can come up with lol

JuicyOP•2y ago

Same issue the creation of the account goes through succesfully though

Angius•2y ago

Weird

JuicyOP•2y ago

Oh Its because of Async suffix in my action name apparently thats not allowed when using createdataction...

Angius•2y ago

Huh

JuicyOP•2y ago

https://github.com/dotnet/aspnet-api-versioning/issues/601

GitHub

Getting System.InvalidOperationException: No route matches the supp...

[HttpPost] public async Task<IActionResult> PostAsync(RequestUserDto requestUserDto) { if (ModelState.IsValid && requestUserDto.RoleId != Guid.Empty) { MOM.Data.Entity...

JuicyOP•2y ago

found this lol Yeah now it works wow

Gaming

Programming

No route matches supplied values but values seem to match?