C#•2y ago

❔ rename tuple

public async Task<(List<SalesReportEntity>, int totalSales)> GetAllSalesReportAsync(int companyId, int? SalesPage, int? Limitpage, DateTime? StartDate, DateTime? EndDate)
{
  return (sales, sales.Count());
}
obs: I cut off some lines

public async Task<(List<SalesReportEntity>, int totalSales)> GetAllSalesReportAsync(int companyId, int? SalesPage, int? Limitpage, DateTime? StartDate, DateTime? EndDate)
{
  return (sales, sales.Count());
}
obs: I cut off some lines

is returning item1: [{…}] item2: 1 How can I rename it to sales and totalSales

16 Replies

Angius•2y ago

I'd probably just use a record here instead of a tuple But return (sales: sales, totalSales: sales.Count()) should work With the return type being Task<(List<SalesReportEntity> sales, int totalSales)>

sibber•2y ago

this not necessary actually, if you specify the names in the return type

ViniciusOP•2y ago

public async Task<(List<SalesReportEntity>allSales, int totalSales)> GetAllSalesReportAsync(){
return (allSales: sales, totalSales: sales.Count());
}

public async Task<(List<SalesReportEntity>allSales, int totalSales)> GetAllSalesReportAsync(){
return (allSales: sales, totalSales: sales.Count());
}

wont change :-:

ViniciusOP•2y ago

MODiX•2y ago

Cyberrex#8052

REPL Result: Success

System.Text.Json.JsonSerializer.Serialize((allSales: 1, totalSales: 2), new JsonSerializerOptions { IncludeFields = true })

System.Text.Json.JsonSerializer.Serialize((allSales: 1, totalSales: 2), new JsonSerializerOptions { IncludeFields = true })

Result: string

{"Item1":1,"Item2":2}

{"Item1":1,"Item2":2}

Compile: 444.748ms | Execution: 52.984ms | React with ❌ to remove this embed.

sibber•2y ago

huh

Angius•2y ago

I guess STJ doesn't serialize named tuples Thankfully, solution is simple: just use a record

ViniciusOP•2y ago

you right

ViniciusOP•2y ago

ViniciusOP•2y ago

return new SalesResume(sales, sales.Count());

ViniciusOP•2y ago

idk if I did best way

Angius•2y ago

I'd just keep the record next to the method tbh, no need to make a whole separate file for it But, sure, it works either way

ViniciusOP•2y ago

Interface need to be typed as well

namespace Epilefinho.Domain.Repositories
{
    public interface ISaleRepository
    {
       
        Task<SalesResume> GetAllSalesReportAsync(int idCompany, int? NumberPage, int? Limitpage, DateTime? StartDate, DateTime? EndDate);
 
    }
}

namespace Epilefinho.Domain.Repositories
{
    public interface ISaleRepository
    {
       
        Task<SalesResume> GetAllSalesReportAsync(int idCompany, int? NumberPage, int? Limitpage, DateTime? StartDate, DateTime? EndDate);
 
    }
}

I'd prefer but I couldnt

Angius•2y ago

Yeah, understandable

ViniciusOP•2y ago

thanks

Accord•2y ago

Was this issue resolved? If so, run /close - otherwise I will mark this as stale and this post will be archived until there is new activity.

Gaming

Programming

❔ rename tuple