N
Novu•3y ago
empe

API tests are failing

@bhavikchavda experience an issue: "In my PR(https://github.com/novuhq/novu/pull/1256) API tests are failing and I found issue that it's happening because novu-test bucket is not there in localstack while running tests. Can you please say how to make novu-test bucket available in localstack while running tests?
9 Replies
Dima Grossman
Dima Grossman•3y ago
@bhavikchavda is this also happens to you locally? Or locally it passes because you created this bucket? We might need to either mock the localstack call, or add the bucket as a prerequisite of tests run in CI and I believe locally too.
Unknown User
Unknown User•3y ago
Message Not Public
Sign In & Join Server To View
Dima Grossman
Dima Grossman•3y ago
@bhavikchavda my concern with this is that people running tests locally will have to perform this aswell... Do you think it will be possible to Mock the StorageService to do it in memory instead of using localstack in this scenario ?
Unknown User
Unknown User•3y ago
Message Not Public
Sign In & Join Server To View
Dima Grossman
Dima Grossman•3y ago
Running them in a couple of minutes
DavidSouthmountain
DavidSouthmountain•3y ago
Just started the test 🥳
Unknown User
Unknown User•3y ago
Message Not Public
Sign In & Join Server To View
Pawan Jain
Pawan Jain•3y ago
Hi Bhavik, Are API tests passing now or you need more help in this?
Unknown User
Unknown User•3y ago
Message Not Public
Sign In & Join Server To View
Want results from more Discord servers?
Add your server