[Solved with PR] Custom RequestBuilder
Is there any way to patch this (https://github.com/kordlib/kord/issues/674) while the issue is dormant? I'm in need of doing such streaming, but since
RequestBuilder is final, I cannot make a different buildimplementation that returns a different multipart request that doesn't eagerly consume all stream bytes.
Any suggestions?GitHub
Add a streamed multipart request · Issue #674 · kordlib/kord
At the moment, Kord loads the entirety of an InputStream onto memory by this readBytes call. Since the Request class is sealed, one cannot make a custom request that converts just takes a ByteReadC...
11 Replies
Unknown User•3y ago
Message Not Public
Sign In & Join Server To View
it's alright
was just wondering if there was a way to patch it myself on my codebase, while I wait for it to get fixed (and then for kordex to use it ig)
Unknown User•3y ago
Message Not Public
Sign In & Join Server To View
if you want I could make the patch and submit a PR
Unknown User•3y ago
Message Not Public
Sign In & Join Server To View
https://github.com/kordlib/kord/blob/0.8.x/rest/src/test/kotlin/request/MessageRequests.kt#L18
this test no longer makes sense, because channels are only read when the request is performed. Do I just nuke it or do you want to have some other test?
GitHub
kord/MessageRequests.kt at 0.8.x · kordlib/kord
Idiomatic Kotlin Wrapper for The Discord API. Contribute to kordlib/kord development by creating an account on GitHub.
@Deleted User ^
@tmpod can you update title and description? Then I'll merge.
sry was out for a walk; it's done now 🙂
thanks
no u 😛
seeing as this is now resolved with the new PR, imma close the topic