cdegroc Comments - Answer Overflow

cdegroc

Explore posts from servers

•Created by cdegroc on 1/17/2024 in #questions

LazyBarrierStrategy/NoOpBarrierStep incompatible with path-tracking

fi: thought I'd try mvn clean install -DskipIntegrationTests=false -DincludeNeo4j as well and it also succeeds 100% with the change

12 replies

ATApache TinkerPop

•Created by cdegroc on 1/17/2024 in #questions

LazyBarrierStrategy/NoOpBarrierStep incompatible with path-tracking

when you say "path tracking is enabled", you mean a step with TraverserRequirement.PATH is part of the path, right? Just to make sure I'm not misunderstanding.

12 replies

ATApache TinkerPop

•Created by cdegroc on 1/17/2024 in #questions

LazyBarrierStrategy/NoOpBarrierStep incompatible with path-tracking

Gremlin Spark was failing due to my corp VPN (i.e. https://stackoverflow.com/questions/52133731/how-to-solve-cant-assign-requested-address-service-sparkdriver-failed-after). But now that I turned it off, all tests are passing. My local diff (compared to master branch) is just

diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java
index 1a51ea0685..c8b96d88cd 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java
@@ -82,7 +82,7 @@ public final class LazyBarrierStrategy extends AbstractTraversalStrategy<Travers
         // which made it so that a Property is equal if the key/value is equal. as a result, they bulk together which
         // is fine for almost all cases except when you wish to drop the property.
         if (TraversalHelper.onGraphComputer(traversal) ||
-                traversal.getTraverserRequirements().contains(TraverserRequirement.PATH) ||
+//                traversal.getTraverserRequirements().contains(TraverserRequirement.PATH) ||
                 TraversalHelper.hasStepOfAssignableClass(DropStep.class, traversal)||
                 TraversalHelper.hasStepOfAssignableClass(ElementStep.class, traversal))
             return;

diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java
index 1a51ea0685..c8b96d88cd 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/LazyBarrierStrategy.java
@@ -82,7 +82,7 @@ public final class LazyBarrierStrategy extends AbstractTraversalStrategy<Travers
         // which made it so that a Property is equal if the key/value is equal. as a result, they bulk together which
         // is fine for almost all cases except when you wish to drop the property.
         if (TraversalHelper.onGraphComputer(traversal) ||
-                traversal.getTraverserRequirements().contains(TraverserRequirement.PATH) ||
+//                traversal.getTraverserRequirements().contains(TraverserRequirement.PATH) ||
                 TraversalHelper.hasStepOfAssignableClass(DropStep.class, traversal)||
                 TraversalHelper.hasStepOfAssignableClass(ElementStep.class, traversal))
             return;

So it could also be that this is not tested or that another factor prevents us from hitting this condition.

12 replies

ATApache TinkerPop

•Created by cdegroc on 1/17/2024 in #questions

LazyBarrierStrategy/NoOpBarrierStep incompatible with path-tracking

Thanks Stephen. I actually ran unit tests for more than that, incl. Gremlin Test and TinkerGraph Gremlin.

[INFO] Apache TinkerPop ................................... SUCCESS [  2.470 s]
[INFO] Apache TinkerPop :: Gremlin Language ............... SUCCESS [  8.322 s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [  0.784 s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [ 24.712 s]
[INFO] Apache TinkerPop :: Gremlin Annotations ............ SUCCESS [  3.797 s]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [  9.908 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [01:43 min]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [01:09 min]
[INFO] Apache TinkerPop :: Gremlin Util ................... SUCCESS [  3.524 s]
[INFO] Apache TinkerPop :: Gremlin Tools .................. SUCCESS [  0.052 s]
[INFO] Apache TinkerPop :: Gremlin Socket Server .......... SUCCESS [  5.887 s]
[INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [ 27.232 s]
[INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [01:37 min]
[INFO] Apache TinkerPop :: Gremlin Python ................. SUCCESS [  0.095 s]
[INFO] Apache TinkerPop :: Gremlin.Net .................... SUCCESS [  0.565 s]
[INFO] Apache TinkerPop :: Gremlin.Net - Source ........... SUCCESS [  0.571 s]
[INFO] Apache TinkerPop :: Gremlin.Net - Tests ............ SUCCESS [  0.193 s]
[INFO] Apache TinkerPop :: Gremlin Go ..................... SUCCESS [  0.062 s]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [01:11 min]
[INFO] Apache TinkerPop :: Spark Gremlin .................. FAILURE [ 21.574 s]
...

[INFO] Apache TinkerPop ................................... SUCCESS [  2.470 s]
[INFO] Apache TinkerPop :: Gremlin Language ............... SUCCESS [  8.322 s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [  0.784 s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [ 24.712 s]
[INFO] Apache TinkerPop :: Gremlin Annotations ............ SUCCESS [  3.797 s]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [  9.908 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [01:43 min]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [01:09 min]
[INFO] Apache TinkerPop :: Gremlin Util ................... SUCCESS [  3.524 s]
[INFO] Apache TinkerPop :: Gremlin Tools .................. SUCCESS [  0.052 s]
[INFO] Apache TinkerPop :: Gremlin Socket Server .......... SUCCESS [  5.887 s]
[INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [ 27.232 s]
[INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [01:37 min]
[INFO] Apache TinkerPop :: Gremlin Python ................. SUCCESS [  0.095 s]
[INFO] Apache TinkerPop :: Gremlin.Net .................... SUCCESS [  0.565 s]
[INFO] Apache TinkerPop :: Gremlin.Net - Source ........... SUCCESS [  0.571 s]
[INFO] Apache TinkerPop :: Gremlin.Net - Tests ............ SUCCESS [  0.193 s]
[INFO] Apache TinkerPop :: Gremlin Go ..................... SUCCESS [  0.062 s]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [01:11 min]
[INFO] Apache TinkerPop :: Spark Gremlin .................. FAILURE [ 21.574 s]
...

12 replies

ATApache TinkerPop

•Created by cdegroc on 10/24/2023 in #questions

Gremlin Driver and frequently changing servers

Sure! I'll spend some time on this. If this looks worth contributing I'll ping here or will open a JIRA with more details.

8 replies

ATApache TinkerPop

•Created by cdegroc on 10/24/2023 in #questions

Gremlin Driver and frequently changing servers

Thanks Stephen 🙇🏻 I was thinking of implementing something very similar actually (i.e. adding a refresh method to Client and Cluster, and refresh either periodically or on exception). The API is well locked so that requires copying and editing a couple classes in a tinkerpop package, but at least the linked code convinced me I am on the right track. Thank you.

8 replies

Gaming

Programming