Cloudflare Developers•3y ago

Issues with Async Failure

https://stackblitz.com/edit/node-t4hhov

Alastair Rosewood

StackBlitz

Node.js (forked) - StackBlitz

Starter project for Node.js, a JavaScript runtime built on Chrome's V8 JavaScript engine.

14 Replies

Hello, I’m Allie!OP•3y ago

@Isaac McFadyen | YYZ01, just checked, and aparently the script fails on https://stackblitz.com/edit/node-t4hhov?file=src%2Fapi%2Fproviders%2FNWS%2Findex.ts, on lines 9-13, when it is just running a fetch request... Fumbling for straws here, but it might be that hono registers routes outside of the scope of a fetch request, which makes it fail?

Isaac McFadyen•3y ago

Huh... yeah, that might be right? I've never used Hono TBH. I use Polka (Lukeed's package).

Isaac McFadyen•3y ago

https://github.com/lukeed/polka

GitHub

GitHub - lukeed/polka: A micro web server so fast, it'll make you d...

A micro web server so fast, it'll make you dance! :dancers: - GitHub - lukeed/polka: A micro web server so fast, it'll make you dance!

Hello, I’m Allie!OP•3y ago

Does it support Workers? I've seen it floating around, but I don't think I have ever actually seen someone use it in Workers...

Isaac McFadyen•3y ago

Oh wait, you're correct lul

the only other thing I can recommend then is itty-router but the API is different.

Hello, I’m Allie!OP•3y ago

Yeah, the big issue for me is the fact that itty doesn't really support middleware for stuff like CORS etc. Might have to use it though...

Isaac McFadyen•3y ago

Hmm... yeah it does? If you do a .any("*", () => {...add cors here}) then don't return in the handler I think?

Hello, I’m Allie!OP•3y ago

I was looking at it, and it looks like middleware must manually be applied to each route. Let me check...

Isaac McFadyen•3y ago

Oh, annoying.

Hello, I’m Allie!OP•3y ago

So, looks like you can run middleware, but only ahead of the final route, which means that I could modify incoming data, but not the outgoing headers... So

import { Router } from 'itty-router';
const app = Router();

app.all('/', (res) => console.log('Yo'));
app.get('/*', () => new Response('Hey'));

export default {
  fetch: app.handle,
};

import { Router } from 'itty-router';
const app = Router();

app.all('/', (res) => console.log('Yo'));
app.get('/*', () => new Response('Hey'));

export default {
  fetch: app.handle,
};

works, but it cannot modify the final response headers.

Isaac McFadyen•3y ago

Oh, interesting.

Hello, I’m Allie!OP•3y ago

Because itty-router is so simple, the second it detects that a response is returned, it stops processing middleware, and just returns the response directly, before its headers can be modified. This is why frameworks like hono and express(I believe) support the next() function, that allows you to use a middleware before a route, intercept the response from the route, and then modify it before it is returned.

Unknown User•3y ago

Message Not Public

Isaac McFadyen•3y ago

Oh sweet! Didn't know this, thanks!

Gaming

Programming

Issues with Async Failure