League of Extraordinary FoundryVTT Developers•5y ago

compendium errors upgrading to v9

hmm im not entirely sure how this will work though.. because I did just a quick smell test to my module under v9, and it broke on the compendium settings which is absolutely core to the module

and I'm not sure if whatever I do to fix it will work on 0.8.x

corporat•10/26/21, 1:15 PM

Mind sharing what errors you got?

corporat•10/26/21, 1:16 PM

I know of one change that should only produce a deprecation warning

ccjmkOP•10/26/21, 1:16 PM

i am .. not entirely sure, but I built a FormApplication on my module to have users select compendiums, and then I mapped those into an array. but the application result is now different

corporat•10/26/21, 1:16 PM

And I know of at least one bug with compendiums

ccjmkOP•10/26/21, 1:16 PM

its a little hard to explain, honestly, I would need to produce some examples and/or show you

ccjmkOP•10/26/21, 1:16 PM

but I don't recall ANY deprecation message and/or error

ccjmkOP•10/26/21, 1:16 PM

it just.. returned something different than before

ccjmkOP•10/26/21, 1:17 PM

(firing up v8)

corporat•10/26/21, 1:17 PM

There should be a deprecation warning if a pre-v9 compendium is being used in v9. The schema has changed

corporat•10/26/21, 1:17 PM

Could be causing weirdness

ccjmkOP•10/26/21, 1:18 PM

hmmm

ccjmkOP•10/26/21, 1:23 PM

I did some HB shenanigans to implement this, registered a checked helper, but it's all a little finnicky, never fully understood what I was doing honestly xD

so.. here's 0.8.9 working response.. when the FormApplication is closed, I get this formData on _updateObject(event, formData).

those arrays of booleans map to the Item compendiums the user has on the world, I map those later into their appropriate names to save them reversed (e.g. races: { 'dnd5e.races': true, ...} IIRC)

ccjmkOP•10/26/21, 1:23 PM

and what I get on v9.... (a min)

ccjmkOP•10/26/21, 1:26 PM

interestingly, this seems even easier to work with xD but I have no idea why this changed

ccjmkOP•10/26/21, 1:38 PM

i don't remember why I didn't save stuff this way directly on the setting, but I will give it a try! saving exactly which compendiums have each data instead of marking them all should probably help a little with performance when reading them

ccjmkOP•10/26/21, 2:01 PM

this is how my setting is supposed to look (i forgot I trimmed unused compendia hahah)

ccjmkOP•10/26/21, 2:03 PM

I do some complicated mappings back and forth, there might be an easier and more straightforward way of doing this :/