Actor Sheet Changes

Actor Sheet changes: -NPC, Character: systems/dnd5e/templates/actors/parts/actor-warnings.html partial that displays warnings in-sheet. -NPC, Character: AC now has a config instead of being an input. class="config-button" data-action="armor" - Vehicle: AC input now targets data.attributes.ac.flat and does not have the same config as creatures. -NPC, Character: attributable class with a data-property is what drives the AC tooltip. This can be placed on any element and the tooltip will be appended to that element. -NPC, Character Main Attribute checkbox input values did this: value={{ability.proficient}} -> value={{ability.baseProf}} -NPC, Character Skill prof checkbox input values did this: value="{{skill.value}}" -> value="{{skill.baseValue}}" (unsure why these changed, the name didn't) - cases of {{localize "DND5E.AbbreviationLbs"}} -> {{ @root.weightUnit }} - proficiency selector for the following has changed: - Armor class="trait-selector" data-options="armorProficiencies" -> class="proficiency-selector" data-type="armor" - Weapons class="trait-selector" data-options="weaponProficiencies" -> class="proficiency-selector" data-type="weapon" - Tools class="trait-selector" data-options="toolProficiencies" -> class="proficiency-selector" data-type="tool"
19 Replies
Calego
CalegoOP4y ago
@sdenec you might be interested in this thread. I'm looking through the Diff and cataloging every change I see to the Actor Sheets. @surged20 I notice in 1.4.0 the vehicle stock sheet does get the Effects Tab now.
Surge
Surge4y ago
Thanks, I must have been switching back to 1.3.x for migration testing when I thought it was still missing
Leo The League Lion
@surged20 gave vote LeaguePoints™ to @calego (#1 • 989)
Surge
Surge4y ago
@calego , I just checked again in a bare world, and 1.4.1 has no effects tab on the vehicle sheet.
No description
Calego
CalegoOP4y ago
Hmmmmm innnteresting I thought for sure I saw this in the diff Can you check if the DOM for the tab exists, but not the tab control to activate it?
Surge
Surge4y ago
like this?
No description
Calego
CalegoOP4y ago
Right, wondering about the contents of sheet-body Like I'm thinking the tab button didn't get added but the tab contents did (they're just inaccessible because of the missing tab button)
Surge
Surge4y ago
oh, ha, yes, you're correct
Calego
CalegoOP4y ago
Lol Rip
Surge
Surge4y ago
No description
Calego
CalegoOP4y ago
You wanna open a MR to fix that?
Surge
Surge4y ago
yep, will do also, fwiw, kinda related to my general vehicle AC concerns..I see a few changes on master where flat and natural calculations for base AC are added...which will make it unnecessary to use custom calc for sanely setting a vehicle base AC.
Calego
CalegoOP4y ago
Oooh nice! I remember seeing a MR from atro revamping those a little but haven't been paying close attention
Surge
Surge4y ago
yeah, I just updated all the wjmais ships to use custom calc and a fixed formula to get a effect targetable base AC now I saw that and wonder if that will hit 1.4.x and I should just wait...not yet clear to me if that's 1.5.x material or not
Calego
CalegoOP4y ago
I suspect it's 1.4.x, the milestone for 1.5 has other focuses
Surge
Surge4y ago
ok
Surge
Surge4y ago
thanks for the help @calego (trying to get you on your way to 2000 points).
Leo The League Lion
@surged20 gave vote LeaguePoints™ to @calego (#1 • 1001)
Want results from more Discord servers?
Add your server