League of Extraordinary FoundryVTT Developers•5y ago

@skimble Try this: ``` const regex = new RegExp(oldId, 'g'); text = text.replace(regex, newId); ```

@skimble Try this:

const regex = new RegExp(oldId, 'g');
text = text.replace(regex, newId);

const regex = new RegExp(oldId, 'g');
text = text.replace(regex, newId);

I suspect your construction of the regex like that is throwing off .replace

CalegoOP•5/7/21, 5:13 PM

the more i look at how to do this the more i change what i suggest

CalegoOP•5/7/21, 5:13 PM

tldr, use constructor instead of a string as the regex and it might work for you

CalegoOP•5/7/21, 5:14 PM

reading:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace
plus
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp

String.prototype.replace() - JavaScript | MDN

The replace() method returns a
new string with some or all matches of a pattern replaced by a
replacement. The pattern can be a string or a
RegExp, and the replacement can be a string or a function to
be called for each match. If pattern is a string, only the first occurrence
will be replaced.

RegExp - JavaScript | MDN

The RegExp object is used for matching text with a pattern.

Re4XN•5/7/21, 5:46 PM

It's prolly explained in the docs they linked.

Re4XN•5/7/21, 5:47 PM

I need more coffee lol

n0q•5/7/21, 6:59 PM

I do wonder. Did .8 break more things than .7? I'm curious if this ritual is normal for each milestone release.

BadIdeasBureau•5/7/21, 7:01 PM

0.8 involved a large refactor of how Entities worked. It's probably one of the more fundamentally breaking things (though a lot of effort has been put into deprecation paths). Mostly, updates only tend to break in the things that touch the specific features being improved (e.g. 0.7 broke a lot of lighting stuff, and 0.8 will break a chunk of audio stuff - because those are getting an overhaul). It's just that one of the "things being improved" in 0.8 was "the entire backend, the way the code is organised, and how data structures are handled".

n0q•5/7/21, 7:03 PM

That makes sense.

Nn0q I do wonder. Did .8 break more things than .7? I'm curious if this ritual is nor...

CalegoOP•5/7/21, 7:15 PM

Major core changes do usually have this kind of ripple effect. I've only lived through 07 and now 08, but its usually a matter of "how much wierd do you do" in your codebase, combined with "how much do you put your fingers into things at a low level" which determines how much the big hits affect you.

CalegoOP•5/7/21, 8:03 PM

Is there a way to update compendium entries without affecting the ID?

CalegoOP•5/7/21, 8:04 PM

merge by name or something?

PPhoenix Anyone seen this with async rolls turned on? Some reason I am getting duplicate ...

arcanistzed•5/7/21, 9:12 PM

What code are you using?

FloRadical•5/7/21, 9:25 PM

is anybody here familiar on how to use the class?

FFloRadical is anybody here familiar on how to use the `ContextMenu` class?

arcanistzed•5/7/21, 9:31 PM

I recently made a module that uses it, so I'm slightly familiar

BadIdeasBureau•5/7/21, 9:31 PM

I've poked it in a different context with a module so I'm confused in appropriately specific ways

FloRadical•5/7/21, 9:32 PM

do I just instantiate the class somewhere? Is it possible to open on a click instead of a right-click?

FFloRadical do I just instantiate the class somewhere? Is it possible to open on a click ins...

arcanistzed•5/7/21, 9:34 PM

What I did was hook into the hook and then modify the contextEntries argument. I don't think it would be easy to use a click instead. That would probably require making your own hook or something

FloRadical•5/7/21, 9:35 PM

ah, right. I want to make my own contextmenu in my own Formapp

arcanistzed•5/7/21, 9:35 PM

BadIdeasBureau•5/7/21, 9:36 PM

As far as I can tell, yes you just instantiate it (passing the HTML of the thing you want them to right click on), and I can't see a way to bind it to click instead.

BadIdeasBureau•5/7/21, 9:36 PM

(I have to override the function that generates it for scene-viewer since that one doesn't get a hook for the options, and it just takes in some html and then passes that html right to the constructor, with a set of options - nothing that looks like it could change what it's listening for)

BadIdeasBureau•5/7/21, 9:38 PM

is the only bit of the code that actually deals with creating the contextMenu (which then promptly vanishes into the abyss, never to be usefully referenceable again)

FloRadical•5/7/21, 9:42 PM

well you can assign it to a variable and return it

FloRadical•5/7/21, 9:42 PM

but I see