Better Auth•2d ago

Custom Plugin is not type safe.

I added the cart plugin as a client to my better auth instance, but when I try to access apiClient.cart.someMethod my IDE thinks it doesn't exist, but the method works on dev/prod instance. how can I let the IDE auto complete these types?

6 Replies

Ping•2d ago

Can you show me your cart code?

mov ecx, 420OP•2d ago

import type { BetterAuthPlugin } from "better-auth/plugins";
import {
  DEFAULT_CART_TABLE_NAME,
  DEFAULT_MAX_CART_ITEMS,
  DEFAULT_MAX_ITEM_PRICE,
  DEFAULT_MAX_ITEM_QUANTITY,
  createErrorCodes,
} from "./constants";
import { createEndpoints } from "./routes";
import { CartPluginOptions } from "./types";

/**
 * Cart plugin for BetterAuth
 * Provides shopping cart functionality with database storage
 */
export const cart = (options?: CartPluginOptions): BetterAuthPlugin => {
  // Set defaults
  const cartTableName = options?.cartTableName || DEFAULT_CART_TABLE_NAME;
  const maxCartItems = options?.maxCartItems || DEFAULT_MAX_CART_ITEMS;
  const maxItemPrice = options?.maxItemPrice || DEFAULT_MAX_ITEM_PRICE;
  const maxItemQuantity = options?.maxItemQuantity || DEFAULT_MAX_ITEM_QUANTITY;

  // Create error codes
  const ERROR_CODES = createErrorCodes(
    maxCartItems,
    maxItemPrice,
    maxItemQuantity,
  );

  // Define database schema
  const schema = {
    [cartTableName]: {
      fields: {
        userId: {
          type: "string" as const,
          required: true,
        },
        productId: {
          type: "string" as const,
          required: true,
        },
        name: {
          type: "string" as const,
          required: true,
        },
        price: {
          type: "number" as const,
          required: true,
        },
        quantity: {
          type: "number" as const,
          required: true,
        },
        image: {
          type: "string" as const,
          required: false,
        },
        createdAt: {
          type: "date" as const,
          required: true,
        },
        updatedAt: {
          type: "date" as const,
          required: true,
        },
      },
      modelName: cartTableName,
    },
  };

  // Create endpoints
  const endpoints = createEndpoints(cartTableName, ERROR_CODES, {
    maxCartItems,
    maxItemPrice,
    maxItemQuantity,
    onCheckout: options?.onCheckout,
  });

  return {
    id: "cart",
    schema,
    endpoints,
    $ERROR_CODES: ERROR_CODES,
  };
};

// Re-export types
export * from "./types";

import type { BetterAuthPlugin } from "better-auth/plugins";
import {
  DEFAULT_CART_TABLE_NAME,
  DEFAULT_MAX_CART_ITEMS,
  DEFAULT_MAX_ITEM_PRICE,
  DEFAULT_MAX_ITEM_QUANTITY,
  createErrorCodes,
} from "./constants";
import { createEndpoints } from "./routes";
import { CartPluginOptions } from "./types";

/**
 * Cart plugin for BetterAuth
 * Provides shopping cart functionality with database storage
 */
export const cart = (options?: CartPluginOptions): BetterAuthPlugin => {
  // Set defaults
  const cartTableName = options?.cartTableName || DEFAULT_CART_TABLE_NAME;
  const maxCartItems = options?.maxCartItems || DEFAULT_MAX_CART_ITEMS;
  const maxItemPrice = options?.maxItemPrice || DEFAULT_MAX_ITEM_PRICE;
  const maxItemQuantity = options?.maxItemQuantity || DEFAULT_MAX_ITEM_QUANTITY;

  // Create error codes
  const ERROR_CODES = createErrorCodes(
    maxCartItems,
    maxItemPrice,
    maxItemQuantity,
  );

  // Define database schema
  const schema = {
    [cartTableName]: {
      fields: {
        userId: {
          type: "string" as const,
          required: true,
        },
        productId: {
          type: "string" as const,
          required: true,
        },
        name: {
          type: "string" as const,
          required: true,
        },
        price: {
          type: "number" as const,
          required: true,
        },
        quantity: {
          type: "number" as const,
          required: true,
        },
        image: {
          type: "string" as const,
          required: false,
        },
        createdAt: {
          type: "date" as const,
          required: true,
        },
        updatedAt: {
          type: "date" as const,
          required: true,
        },
      },
      modelName: cartTableName,
    },
  };

  // Create endpoints
  const endpoints = createEndpoints(cartTableName, ERROR_CODES, {
    maxCartItems,
    maxItemPrice,
    maxItemQuantity,
    onCheckout: options?.onCheckout,
  });

  return {
    id: "cart",
    schema,
    endpoints,
    $ERROR_CODES: ERROR_CODES,
  };
};

// Re-export types
export * from "./types";

Ping•2d ago

Don't cast BetterAuthPlugin, use satisfies instead

mov ecx, 420OP•2d ago

ahh :PES_ThumbsUp: alright, do you have any article on why we need to do that? interested to learn about this it would be nice to have a warning in the docs, saying if you don't use satisfies typesafety won't work

Ping•2d ago

it's kind of general typescript knowledge 😅 https://stackoverflow.com/questions/78636946/what-are-the-differences-between-typescript-s-satisfies-operator-and-type-assert

Stack Overflow

What are the differences Between TypeScript’s satisfies operator ...

I've recently come across the satisfies operator in TypeScript and I'm trying to understand how it differs from regular type assertions. Both seem to provide a way to work with types, but I'm not c...

mov ecx, 420OP•2d ago

:PU_monkaShake: ahh, I guess I gotta learn typescript all over again Anyways, you are a legend man, thank you. I'll try it out soon.

Gaming

Programming

Custom Plugin is not type safe.

Did you find this page helpful?