Password not updating on resetPassword
Hi,
I have been trying out better-auth with Elysia + SurrealDB (W/ Featured Community Adapter on Better Auth Site) + SvelteKit (SSG-only) and so far everything has worked out but I have started to face a weird issue related to the forget/reset password flow that I haven't been able to exactly pin down.
I have been able to reach at the point where I am able to redirect the user to a proper page to reset the password, where I have them fill out a form, which when submitted, calls
authClient.resetPassword
which returns a {status: true} res (and no error)
But the password hash, does not update in the db.
The worst part is that there are no errors, and it's really making it difficult for me to track down the issue.
I am trying this out without any email verification implementation currently, although I don't think this should effect that.
The project is basically a way for me to explore new tech rn and is open source,
https://github.com/sosweetham/anime-api/blob/main/apps/api/src/libs/auth/auth.ts
I am sure it might help reproduce the issue.GitHub
anime-api/apps/api/src/libs/auth/auth.ts at main · sosweetham/anim...
Contribute to sosweetham/anime-api development by creating an account on GitHub.
25 Replies
It's not often we see people use Surreal DB, so it does make me suspect either one of two things:
* The adapter has some unexpected error that isn't being caught & handled
* Somewhere in BA internals, it isn't working in a Sveltekit SSG environment
Or I wonder if it's a captcha plugin issue? 🤔
Not sure, I'll try to keep looking.
https://discord.com/channels/1288403910284935179/1296058482289676320/1356347466441822229 someone else faced an issue with a Neon (Postgres) + Drizzle setup
Good to know.
So it's not an adapter issue.
Let me go read BA codebase and see if I can spot anything.
Yeah I'm not sure, the BA code looks right.
cc.@Artherel
Your code looks fine, and so does the internal code.
@bekacru Could you please help here? Thanks
Is there a db query being executed to update the password?
I am not making any manual query on my application's level to update the password/auth related stuff, I was assuming BA would handle it
https://github.com/better-auth/better-auth/blob/0d7fa1f99cee25c0f1c4cf37a8ff4b1ad376a30e/packages/better-auth/src/api/routes/forget-password.ts#L265
No from your db logs check if a query is being executed when you call reset password
found these to be relevant to what BA is doing
this part where it checks for verification for reset password
seems to have made another record
instead of update
also curiously, the accountId seems to be a string instead of a record reference in the added row, i suppose it's an issue with the adapter then
Yeah, that's definitely odd. Very likely an adapter issue.
Could you open an issue in the Surreal adapter repo?
ok i'll do that
@Ping @bekacru i have further investigated the issue by patching the adapter to log the update and create methods, the adapter has correctly implemented all the required methods from how i understand it
but BA is calling the create method instead of the update method on reset password
https://discord.com/channels/1288403910284935179/1296058482289676320/1356599184207384779
postgres+neon setup link, apparently @Wojak tested it and found the same
the log should have said "update" on the account model, but instead it has listed as a "create"
this is linked to this issue, as the adapter is a very light abstraction on top of BA ngl
BA had passed record id correctly while creating the user and account, but did not do that when resetting the password
could it be that it's not being able to find the account in the given criteria?
forget password made this record, but value isnt a RecordId
https://github.com/better-auth/better-auth/blob/df72736d36c64747155b80d16d3fb9ea62ff7f25/packages/better-auth/src/api/routes/forget-password.ts#L111
this should still be a record, not a string
i think this type mismatch leads to accounts[] being empty, although i am going off on a conjecture lol
this seems to be implemented correctly before
i think this is a commit mishap lol
@Ping @bekacru I fixed it,
it works xD
I have opened a PR for the same https://github.com/better-auth/better-auth/pull/2083
Oh wow, nice
I wonder what the reason behind the initial commit that is broken was
i have no idea, but i think it definitely wasnt added to tests correctly and i am not really sure about how tests are setup in the project lol
i tried running them but am i supposed to install the db locally?
for now i just built the patched package, added it to my application, and tried the flow, and it has worked correctly