BA
Better Auth•2mo ago
Jonathan Riche

Custom Session running twice on GET /api/auth/get-session

I'm trying out custom session to return some additonal team fields on the repsonse to use on the client side and i noticed(sinces its making a call to the db and i have the logger on) it's running the custom Session method twice for every single call to GET /api/auth/get-session is this to be expected or have i done something funky in my config my custom session looks like the following: 
customSession(async ({ user, session }) => {
            if (config.dev) console.log('custom session is running');
            const userTeams = await getUserTeam(DrizzlePgPool(config.db), user.id);
            // console.log('userTeams:', userTeams, session);
            return {
                user,
                teams: userTeams,
                session
            }
        })
customSession(async ({ user, session }) => {
            if (config.dev) console.log('custom session is running');
            const userTeams = await getUserTeam(DrizzlePgPool(config.db), user.id);
            // console.log('userTeams:', userTeams, session);
            return {
                user,
                teams: userTeams,
                session
            }
        })
on my logs you can see the request being called once but customsession is running twice? 
[wrangler:inf] GET /api/auth/get-session 200 OK (54ms)
custom session is running
Query: select "team_member"."role", "team_member"."team_id", "team"."name" from "team_member" left join "team" on "team_member"."team_id" = "team"."id" where "team_member"."user_id" = $1 -- params: ["USERID
"]
custom session is running
Query: select "team_member"."role", "team_member"."team_id", "team"."name" from "team_member" left join "team" on "team_member"."team_id" = "team"."id" where "team_member"."user_id" = $1 -- params: ["USERID"]
[wrangler:inf] GET /static/apple-touch-icon.png 200 OK (41ms)
[wrangler:inf] GET /static/favicon-32x32.png 200 OK (40
ms)
[wrangler:inf] GET /api/auth/get-session 200 OK (54ms)
custom session is running
Query: select "team_member"."role", "team_member"."team_id", "team"."name" from "team_member" left join "team" on "team_member"."team_id" = "team"."id" where "team_member"."user_id" = $1 -- params: ["USERID
"]
custom session is running
Query: select "team_member"."role", "team_member"."team_id", "team"."name" from "team_member" left join "team" on "team_member"."team_id" = "team"."id" where "team_member"."user_id" = $1 -- params: ["USERID"]
[wrangler:inf] GET /static/apple-touch-icon.png 200 OK (41ms)
[wrangler:inf] GET /static/favicon-32x32.png 200 OK (40
ms)
Solution:
OK i had to do something funky i literaly had to copy over your customSessionClientPlugin and make this change ```typescript async (ctx) => { const session = await getSessionFromCtx(ctx);...
Jump to solution
8 Replies
bekacru
bekacru•2mo ago
can you send me your auth config?
Jonathan Riche
Jonathan RicheOP•2mo ago
yes got i here its




Jonathan Riche
Jonathan RicheOP•2mo ago
Jonathan Riche
Jonathan RicheOP•2mo ago
@bekacru
bekacru
bekacru•2mo ago
yeah I don't see any issue with your config. make sure you're only calling getSession once and it's not being triggered twice by the browser
Jonathan Riche
Jonathan RicheOP•2mo ago
outside of using const session = authClient.useSession(); oneced in my layout component what else trgigers the get session i only see it firing once in the network tab* ie im using the solid js import { createAuthClient } from "better-auth/solid"; ie 
import { createAuthClient } from "better-auth/solid";
import { customSessionClient } from "better-auth/client/plugins";
import type { AuthReturnType } from "./auth";

export const authClient = createAuthClient({
    plugins: [customSessionClient<AuthReturnType>()],

});
import { createAuthClient } from "better-auth/solid";
import { customSessionClient } from "better-auth/client/plugins";
import type { AuthReturnType } from "./auth";

export const authClient = createAuthClient({
    plugins: [customSessionClient<AuthReturnType>()],

});
import { authClient } from "@lib/auth-client";
export const Layout: ParentComponent = (props) => {
    const session = authClient.useSession();

      //OTHER PARTS OF COMPONENT

return(
<Show when={session().data}>
//other compoennts

</Show>

)
};
import { authClient } from "@lib/auth-client";
export const Layout: ParentComponent = (props) => {
    const session = authClient.useSession();

      //OTHER PARTS OF COMPONENT

return(
<Show when={session().data}>
//other compoennts

</Show>

)
};
@bekacru
Solution
Jonathan Riche
Jonathan Riche•2mo ago
OK i had to do something funky i literaly had to copy over your customSessionClientPlugin and make this change 
async (ctx) => {
                    const session = await getSessionFromCtx(ctx);
                    if (!session) {
                        return ctx.json(null);
                    }
                    if (!ctx.request?.url) {
                        console.log('skipping runnig session function')
                        return { user: session.user, session: session.session };
                    }

                    if (ctx.request?.url?.includes(route)) {
                        console.log('custom session is running correctly');

                    }
                    const fnResult = await fn(session as any);
                    return ctx.json(fnResult);

                    // return ctx;
                }
async (ctx) => {
                    const session = await getSessionFromCtx(ctx);
                    if (!session) {
                        return ctx.json(null);
                    }
                    if (!ctx.request?.url) {
                        console.log('skipping runnig session function')
                        return { user: session.user, session: session.session };
                    }

                    if (ctx.request?.url?.includes(route)) {
                        console.log('custom session is running correctly');

                    }
                    const fnResult = await fn(session as any);
                    return ctx.json(fnResult);

                    // return ctx;
                }
Left everything else the same this is working now not sure where teh extra call was coiming from might be something on the hono end but its working regardless now...
Jonathan Riche
Jonathan RicheOP•2mo ago
@bekacru

Did you find this page helpful?