CI test policy
I want to mark my PR as ready for review after passing the CI tests, but it's currently pending approval.
Is there any policy regarding this?
9 Replies
<#1353543197208346655>
Category
Help needed
Product
Coder (v2)
Platform
Linux
Logs
Please post any relevant logs/error messages.
hey, could you send a link to your PR?
https://github.com/coder/coder/pull/17015
This is the PR I'm currently working on.
GitHub
feat: add API endpoint for retrieving OIDC logout URL by esifea · P...
Introduces a new API endpoint /api/v2/users/oidc-logout that constructs and returns the full OIDC logout URL.
The endpoint retrieves necessary OIDC configuration (e.g., logout endpoint, client ID, ...
Can you resolve conflicts and rebate on main.
I can approve the tests.
Also looks like your PR is still in the draft. When it's ready please mark it as ready for review
Also I would suggest elaborating a bit more on the use case you are trying to solve. Your PR body describes what it does but doesn't capture why.
Thank you 😊
@Atif
Hello, thank you for your explanation.
I’ve resolved the conflicts and updated the PR description.
The reason my PR is still in draft is that I usually mark it as ready after it passes CI tests, but if it’s okay, I can change it now.
Thanks
I approved the tests workflow
Thank you for your help!
@ESIFEA marking this as closed!
in the future i'd advise reaching out via #contributing :-)
@Phorcys closed the thread.