✅ Vertical Slice Architecture and Shared Code?
I've adapted one of my projects from using the more traditional Clean Architecture and Repositories/services, but what happens if you have logic that is used across multiple features, if VSA is against using something like a service, do you just repeat code where you need to? That seems silly to me.
But for example say you have a LoginCommandHandler and RefreshTokensCommandHandler, both would have logic for generating both an access and refresh token, so how would you go about handling that? I current still have several "services" in project for things like Tokens and Email for occasions where I know something is going to be reused in multiple features, an I'm not sure if they should be changed
45 Replies
You can still create services and shared commands/queries as needed where it makes sense, there isn't anything stopping you.
Okay, i wasn't to sure.
So this is basically how my project is setup, and should be fine? The big thing was just stopping using repositories and to use the dbContext directly in each feature slice?
└── TaskGarden/
├── TaskGarden.Api/
│ └── Endpoints
├── TaskGarden.Application/
│ └── Features/
│ ├── Auth/
│ │ ├── Login/
│ │ │ └── Commands/
│ │ │ ├── LoginCommand.cs
│ │ │ ├── LoginCommandHandler.cs
│ │ │ └── LoginCommandValidator.cs
│ │ ├── Register
│ │ ├── RefreshTokens
│ │ ├── ChangePassword
│ │ └── ResetPassword
│ ├── Categories
│ ├── TaskList
│ └── TaskListItems
├── TaskGarden.Domain/
│ ├── Entities
│ └── Enums
└── TaskGarden.Infrastructure/
├── Services/
│ ├── Email
│ └── Identity/
│ ├── TokenService
│ └── GoogleOAuthService
├── AppDbContext.cs
├── Migrations
└── Seeders
thats semi VSA but sure do what works for you
The big thing was just stopping using repositories and to use the dbContext directly in each feature slice?no thats unrelated. the big thing is putting things that are directly related to each other, together and not have them tightly coupled to anything else those are essentially what the slices are
Yeah i read that using VSA and CA together is a good idea, so i tried to keep the infra, domain, and api parts separates and then do VSA in just the application layer.
there isnt really one "good idea"
theres a very highly debated topic
id say just do what sounds good to you, and build experience so you can form opinions
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
Yeah all the examples or video explanations I see are usually one project, and usually the feature slices are one file. I can refactor it to be one project, tbh that would make things a lot simpler, since u wont have to worry about the references and where each nuget package needs to be installed.
and it would feel more of what I'm use to from other languages.
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
Okay so i merged everything into one project, there still has to be a project inside the solution correct? You can't just have everything in the root solution can you?
For example
TaskGarden - Solution name
|--TaskGarden.Api - Project Name
|----Application
|----Domain
|----Infrastructure
|----Endpoints
everything in TaskGarden.Api are just different directories not different projects like i had before.
You cant have it like
TaskGarden - Solution name (root)
|--Application
|--Domain
|--Infrastructure
|--Endpoints
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
to me Endpoints is kinda generic, i'm not against it but i would prefer something just a bit more specific like WebApi or HttpApi
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
I can change it, im open to all suggests, naming is 100% the hardest part of this whole programming thing we do.
I have that as well, do u put the endpoint for the feature in the same feature folder?
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
How do you handle your logic for slice, currently i have it all inside of the same file, but do you guys split like the logic out into a separate file? For instance i have a LoginCommandHandler class, and then in that same class I have all the private methods were i extract out logic.
So I have a private method for creating the access token, creating the refresh token, etc and then i call those functions from inside the handler, but do you guys actually make all that "helper" logic into its own class? then bring it into the Handler? Or keep all the logic for the handler within the handler file? I know its preference mostly just asking.
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
So something like creating a Todo would be something you would want to test, so that should probably be extracted out?
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
Awesome, i dont have any testing in my project yet but i took everything you guys told me and kind of spun it into my own thing. I wanna see if i can take the duplicated methods and turn them into extensions when I get some time today.
https://github.com/CydoEntis/task-garden-api
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
Ooo this is way more then anything my functions do lol, but I intend to eventually get to testing and have to do things like this. Currently most of my methods are just in the same handler file extracted into small private methods that are responsible for doing a single thing.
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
I thought about doing that, but i kind of like the way my api project is setup now, ik where everything is and why it is where it is, and i dont feel bogged done by having to make, a repository, its interface, then a service and its interface, and so on and so on.
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
Wooo, the 2 days i spent on this was worth it haha. Now too actually finish this little app 😄
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
Im using React. Mantine UI, Tanstack Query and Router.
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
I was gonna go learn NextJS but i dont really feel like theres a reason too.
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
I learned Vue as my first front end framework but went react cause more jobs
same reason i chose .NET lol
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
But Vue > imo
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
thats how i feel about next js lol
and im trying to stick with .NET for this entire year, even though Laravel has been super tempting me
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
The whole deploying to vercel thing is why i dnt wanna use next even though ik u can seslf host but its gets out of control quickly i read.
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
Yeah i look at Laravel cause of all those other builtin things like Cashier, Auth etc.
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
no blazor?
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
I see, im just trying to stay hyper focused and get good at react and .net
and find a job lol
Unknown User•2mo ago
Message Not Public
Sign In & Join Server To View
Thanks, hopefully it pays off.
Imma close this, i appreactiate everyone input and advice 😄