S
Solara•2mo ago
SeoulSKY

Custom Page for 404 Not Found

Based on the pull request here, I attempted to run the following code: 
# sol.py

import solara

clicks = solara.reactive(0)

added = False


def add_exception_handler():
    global added
    print("add_exception_handler", added)
    if not added:
        import solara.server.starlette
        from starlette.responses import HTMLResponse

        async def server_error(request, exc):
            return HTMLResponse(content="My custom 404", status_code=exc.status_code)

        solara.server.starlette.app.add_exception_handler(404, server_error)
        added = True


@solara.component
def Page():
    # add the handler after all the imports are done to avoid a circular import
    add_exception_handler()
    solara.Text("hello world")
# sol.py

import solara

clicks = solara.reactive(0)

added = False


def add_exception_handler():
    global added
    print("add_exception_handler", added)
    if not added:
        import solara.server.starlette
        from starlette.responses import HTMLResponse

        async def server_error(request, exc):
            return HTMLResponse(content="My custom 404", status_code=exc.status_code)

        solara.server.starlette.app.add_exception_handler(404, server_error)
        added = True


@solara.component
def Page():
    # add the handler after all the imports are done to avoid a circular import
    add_exception_handler()
    solara.Text("hello world")
After running the solara: 
solara run sol.py
solara run sol.py
If I visit the http://localhost:8765/invalid, it still shows "Page not found by Solara router" instead of "My custom 404". How to fix this code to make it work?
1 Reply
Monty Python
Monty Python•2mo ago
maartenbreddels
<:pull_merged:882464249119645787> [widgetti/solara] fix: if we hit a 404 in starlette, raise instead of render a 404
This allows middleware or error handlers to catch the 404 and do something custom. Example: 
import solara

clicks = solara.reactive(0)

added = False

def add_exception_handler():
    global added
    print("add_exception_handler", added)
    if not added:
        import solara.server.starlette
        from starlette.responses import HTMLResponse
        async def server_error(request, exc):
            return HTMLResponse(content="My custom 404", status_code=exc.status_code)

        solara.server.starlette.app.add_exception_handler(404, server_error)
        added = True

@solara.component
def Page():
    # add the handler after all the imports are done to avoid a circular import
    add_exception_handler()
    solara.Text("hello world")
import solara

clicks = solara.reactive(0)

added = False

def add_exception_handler():
    global added
    print("add_exception_handler", added)
    if not added:
        import solara.server.starlette
        from starlette.responses import HTMLResponse
        async def server_error(request, exc):
            return HTMLResponse(content="My custom 404", status_code=exc.status_code)

        solara.server.starlette.app.add_exception_handler(404, server_error)
        added = True

@solara.component
def Page():
    # add the handler after all the imports are done to avoid a circular import
    add_exception_handler()
    solara.Text("hello world")
Created

Did you find this page helpful?