C
C#4d ago
KidKai25

✅ convert synchronous code to async?

//Controller class
public string BindOrgUsers()
{
string result = string.Empty;
try
{
FilterModel fm = new FilterModel();
result = fm.GetUsers(Utility.GetOrgId(), Utility.GetUserId());
}
catch (Exception ex) { _logger.Error(ex); }
return result;
}

//FilterModel class
public string GetOrgUsers(int orgId, int userId)
{
string result = string.Empty;
try
{
string cacheKey = $"Users_{orgId}_{userId}";
result = CacheManager.GetOrAdd(cacheKey, () => GetUsersFromDB(orgId, userId));
}
catch (Exception ex) { _logger.Error(ex); }
return result;
}

public string GetOrgUsersFromDB(int orgId, int UserId)
{
string json = string.Empty;
DataTable dtUsers = Utility.ExecuteSqlDatatable("sp_getOrgNetwork", CommandType.StoredProcedure, paraUserReport.ToArray());
json = JsonConvert.SerializeObject(dtUsers);
}
//Controller class
public string BindOrgUsers()
{
string result = string.Empty;
try
{
FilterModel fm = new FilterModel();
result = fm.GetUsers(Utility.GetOrgId(), Utility.GetUserId());
}
catch (Exception ex) { _logger.Error(ex); }
return result;
}

//FilterModel class
public string GetOrgUsers(int orgId, int userId)
{
string result = string.Empty;
try
{
string cacheKey = $"Users_{orgId}_{userId}";
result = CacheManager.GetOrAdd(cacheKey, () => GetUsersFromDB(orgId, userId));
}
catch (Exception ex) { _logger.Error(ex); }
return result;
}

public string GetOrgUsersFromDB(int orgId, int UserId)
{
string json = string.Empty;
DataTable dtUsers = Utility.ExecuteSqlDatatable("sp_getOrgNetwork", CommandType.StoredProcedure, paraUserReport.ToArray());
json = JsonConvert.SerializeObject(dtUsers);
}
My plan is to convert BindOrgUsers to return Task
57 Replies
KidKai25
KidKai25OP4d ago
@TeBeCo
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
no it's not modern. .NET FRAMEWORK
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
public static DataTable ExecuteSqlDatatable(string commandText, CommandType commandType, params SqlParameter[] parameters)
{
DataTable dt = new DataTable();
try
{
using (SqlConnection sqlConn = new SqlConnection(connStr))
{
using (var command = new SqlCommand(commandText, sqlConn))
{
command.CommandType = commandType;
command.CommandTimeout = Convert.ToInt32(DBCommandTimeout);
if (parameters != null)
command.Parameters.AddRange(parameters);

SqlDataAdapter da = new SqlDataAdapter(command);
da.Fill(dt);
sqlConn.Close();
}
}
}
catch(Exception ex)
{
LogSQLOnException(ex, commandText, commandType, parameters);
}
return dt;
}
public static DataTable ExecuteSqlDatatable(string commandText, CommandType commandType, params SqlParameter[] parameters)
{
DataTable dt = new DataTable();
try
{
using (SqlConnection sqlConn = new SqlConnection(connStr))
{
using (var command = new SqlCommand(commandText, sqlConn))
{
command.CommandType = commandType;
command.CommandTimeout = Convert.ToInt32(DBCommandTimeout);
if (parameters != null)
command.Parameters.AddRange(parameters);

SqlDataAdapter da = new SqlDataAdapter(command);
da.Fill(dt);
sqlConn.Close();
}
}
}
catch(Exception ex)
{
LogSQLOnException(ex, commandText, commandType, parameters);
}
return dt;
}
Is this @TeBeCo
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
webapp yes mvc Utility helper class
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
I didn't write this code. But I would like your feedback, to improve for future
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
@TeBeCo Hence my original question
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
huh??? are you saying async controller actions are useless?
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
same point as to making use of async await?
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
ASYNC AWAIT WITH TASK
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
let task wait
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
I thought I finally got async await, I am super confused now
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
but who doing +1 here?
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
it makes new Thread?
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
why can't I do what normally happens(what I learned) i.e. -1 if not TASK.RUN then something else?
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
oh
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
keep it block okay
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
hmmm
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
right blocked -1 release
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
understood
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
yes
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
but i CAN'T DO anything here because at the very end it is still using THREAD.
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
hahaha
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
jcotton also said this?
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
so why jcotton said that?
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
no this
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
so jcotton mistaken?
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
api bad okay fuck thank you Tebe
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
MODiX
MODiX4d ago
If you have no further questions, please use /close to mark the forum thread as answered
Unknown User
Unknown User4d ago
Message Not Public
Sign In & Join Server To View
KidKai25
KidKai25OP4d ago
I didn't write this, I don't know

Did you find this page helpful?