C#•11mo ago

✅ Will I fall into a gotcha with this constructor?

Hi, all:

I'm trying to setup a class for managing my AWS S3 interactions, but I'm wondering if there are any issues with my definition:

C#
    public class S3Service(ILogger<S3Service> logger, IAmazonS3 s3Client) : IS3Service
    {
        private readonly ILogger<S3Service> _logger = logger;
        private readonly IAmazonS3 _s3Client = s3Client;
        private readonly TransferUtility _transferUtility = new(s3Client);
...

C#
    public class S3Service(ILogger<S3Service> logger, IAmazonS3 s3Client) : IS3Service
    {
        private readonly ILogger<S3Service> _logger = logger;
        private readonly IAmazonS3 _s3Client = s3Client;
        private readonly TransferUtility _transferUtility = new(s3Client);
...

Looks simple enough, but I'm worried about two things, TransferUtility inherits from

IDisposable

IDisposable

, will the framework properly handle the disposability of the

_transferUtility

_transferUtility

? Also, would it be more appropriate to create a new

TransferUtility

TransferUtility

object under the scope of each function that I want to use the class rather than creating a class field? For example:

C#
public Task MyUploadFunctionAsync()
{
  using var transfer = new TransferUtility();
  ... transfer files
}

C#
public Task MyUploadFunctionAsync()
{
  using var transfer = new TransferUtility();
  ... transfer files
}

I'll be expecting to upload many (~50 25MB) files at once. If the latter approach is more appropriate I can of course pass in a list of objects I'd like to upload.

Thanks

TransferUtility Class | AWS SDK for .NET V3

TransferUtility Class

SleepWellPupper

S

SleepWellPupper•2/6/25, 4:56 PM

Since is ing up the

TransferUtility

TransferUtility

, it owns its lifetime. Therefore, you should either implement

IDisposable

IDisposable

on , or move ownership by injecting

TransferUtility

TransferUtility

instead of .

MODiX

M

MODiX•2/6/25, 6:40 PM

Sorry @C@NYON

ONL!NE your message contained blocked content and has been removed!

Canyon

C

CanyonOP•2/6/25, 6:40 PM

Hmmm

Canyon

C

CanyonOP•2/6/25, 6:41 PM

let me try messaging in parts

MODiX

M

MODiX•2/6/25, 6:41 PM

Sorry @C@NYON

ONL!NE your message contained blocked content and has been removed!

Canyon

C

CanyonOP•2/6/25, 6:42 PM

IDK why my message is blocked

MODiX

M

MODiX•2/6/25, 6:43 PM

Sorry @C@NYON

ONL!NE your message contained blocked content and has been removed!

Canyon

C

CanyonOP•2/6/25, 6:43 PM

Whatever

Sehra

S

Sehra•2/6/25, 7:07 PM

$paste

Sehra

MODiX

M

MODiX•2/6/25, 7:07 PM

If your code is too long, you can post to https://paste.mod.gg/, save, and copy the link into chat for others to see your shared code!

MODiX

M

MODiX•2/6/25, 7:18 PM

Sorry @C@NYON

ONL!NE your message contained blocked content and has been removed!

SleepWellPupper

S

SleepWellPupper•2/6/25, 7:18 PM

What're you trying to paste?

SleepWellPupper

SSleepWellPupper What're you trying to paste?

Canyon

C

CanyonOP•2/6/25, 7:19 PM

SleepWellPupper

S

SleepWellPupper•2/6/25, 7:20 PM

What I mean by "injecting TransferUtility instead of IAmazonS3" is that you replace your constructor parameter from to

TransferUtility

TransferUtility

and leave the disposal to whatever is creating your

Sehra

S

Sehra•2/6/25, 7:21 PM

you can add it as

SleepWellPupper

S

SleepWellPupper•2/6/25, 7:21 PM

if you resolve your service from a di container then that would be responsible for disposal.
Other than that, your

Dispose

Dispose

implementation is fine.

SleepWellPupper

SSleepWellPupper What I mean by "injecting TransferUtility instead of IAmazonS3" is that you repl...

Canyon

C

CanyonOP•2/6/25, 7:27 PM

okay with sehra's line of code i see what you mean. i use functions available in but not

TransferUtility

TransferUtility

in some of my implementation, particularly for listing buckets and keys in them, so i'll have to go with the

Dispose

Dispose

route i think

Canyon

CCanyon okay with sehra's line of code i see what you mean. i use functions available in...

SleepWellPupper

S

SleepWellPupper•2/6/25, 7:29 PM

yep, that makes sense. Still, you could inject both and

TransferUtility

TransferUtility

and not deal with disposal in your service.

Canyon

C

CanyonOP•2/6/25, 7:31 PM

that is tempting particularly because VS is warning me about which is approaching ends of the language i don't fully comprehend

SleepWellPupper

S

SleepWellPupper•2/6/25, 7:39 PM

forget about that
is fine if your disposable dependency (

_transferUtility

_transferUtility

) is managed (i.e. implements

IDisposable

IDisposable

itself).

SleepWellPupper

S

SleepWellPupper•2/6/25, 7:39 PM

It does, so you don't have to worry about the finalization stuff.

TeBeCo

T

TeBeCo•2/6/25, 9:30 PM

you'll care about it a jen you'll have to deal with lifetime of unmanaged object where you own these

here it's not the case

TeBeCo

T

TeBeCo•2/6/25, 9:31 PM

$close

TeBeCo

MODiX

M

MODiX•2/6/25, 9:31 PM

If you have no further questions, please use /close to mark the forum thread as answered