Github Action push failure on bluefin-lts{-dx,-hwe,-dx-hwe}
could someone help me out with the github actions on bluefin-lts?
51 Replies
i really dont know what to do here
this is the last blocker to getting -hwe and -dx working on this
@p5 friendly ping since i believe this might be of your interest
OH MY GOD I GOT IT
its doign
lts-amd64 without like any reason to do so
it should be just :lts@tulip It needs to push the images to lts-<arch>
The images are pushed first to the registry under that tag, then they are tagged with just lts in the manifest job
it doesnt seem to have pushed the images properly :( i think i brome something
check this out
OH
thats why then!!!
it got pushed like this
Yeah. That's normal
man so this really makes me wonder then, why dont the other ones work...
So to summarise:
1. Create a matrix JSON from the required architectures
2. Build, rechunk and push to lts-<arch> in matrix
3. Collect all outputs from builds and push a single manifest, with the required end-user facing labels and tags
Is something not working?
i changed the first step, i just put a matrix directly there
pretty sure that broke it.
Oh, main branch is broken? I can take a look
yuuup...
sorry for the trouble tho
you used the
include: thing to get the matrix going, with the -hwe + -dx suffixes that would mean like 8(?) includes? (+ some weird logic)
so i just put the matrix there thinking nothing would break ðŸ˜Nope. At that time, I wasn't aware of plans to use -hwe and -dx.
What I'm going to do is turn it into a reusable workflow, then have separate YAML files that call the reusable build for each
What I'm going to do is turn it into a reusable workflow, then have separate YAML files that call the reusable build for each
ooh! why do we do that tho?
like, does the matrix thing not work for that?
tbh, same?
@p5 you might want to revert my changes then btw: https://github.com/ublue-os/bluefin-lts/pull/216
the logic on the
build step is fine tho, fixed it later on a separate commitGitHub
bluefin-lts/.github/workflows/build-image.yml at 02ee360352d2f0033f...
Bluefin LTS, built on CentOS Stream with bootc. Contribute to ublue-os/bluefin-lts development by creating an account on GitHub.
https://github.com/ublue-os/bluefin-lts/pull/219/files
Does this approach look okay?
like, does the matrix thing not work for that?Nope. The matrix on the build step itself doesn't work since this will then try and put all 8 images inside a single manifest, which won't work. bluefin:lts would contain hwe, dx, non-dx, non-hwe etc. We need to call the workflow separately for each image because we need to make a single manifest for each image
Depending on how GITHUB_ENV is handled between different jobs, I may need to do something more
looks perfect to me! - the only thing is that like, we need
-hwe-dx too
dunno if that handles that
its kinda like the current bluefin workflows
ooooooooooh thats why oh my god 😠i would never figure that outI've not changed your build logic, so that should just be a new file with hwe-dx passed in as an input
perfect then!
we can add that as a follow up
ill merge this
is that ok?
LGTM tho
Not yet! I'm researching if I need to handle the IMAGE_NAME logic in the manifest step too
ooh okok
Going to change the image name to a test one and try a full build + push
the IMAGE_NAME gets changed on the build workflow
so it might just work
i think we should put that as a separate step too, will do that with the -hwe-dx follow up.
@p5 since ur doing this will apply a few suggestions i made on this one https://github.com/ublue-os/bluefin-lts/pull/215/
GitHub
chore: replace x86_64-only Flatpaks with amd64 alternatives by p5 ·...
I'm not too sure how the overrides work, so please give this a good review :)
This replaces Firefox with Chromium (the next best option for a browser).
And removes Thunderbird, since it&...
OH you are already doing stuff there!
oh nvm i just read it wrong
Okay, I'm happy with the workflow now.
Haven't tested it end-to-end, but that's what production is for 🙂 Tulip - are you able to confirm the image names are still what you were expecting?
Haven't tested it end-to-end, but that's what production is for 🙂 Tulip - are you able to confirm the image names are still what you were expecting?
HAHAHA hell yeah!!!!!
lets DO IT in prod!
as always :)
ok so - i believe so!
i just didnt want to publish new packages for no reason
-hwe-dx already exists on bluefin, but dx-hwe doesnt
oh
i think i got it mixed up LOL
lemme see
its dx-hwe.Cool. I'll push an update
Can I check if you wanted to introduce a new Bluefin LTS skew (like bluefin-lts-surface), would you know how with the new changes? I want to make sure I'm not the only person who undertands the workflow
id just add a
bluefin-lts-surface on the workflows
id just copy any of the existing files and put that there
changing the metadata where appropriateAwesome! Yeah.
So copy and paste the build-whatever.yml files, then add one of your
So copy and paste the build-whatever.yml files, then add one of your
if conditions to pass the correct info to the Justfilehell yeah!!!
this is simple enough anyone can figure it out if necessary
But sorry about the first workflow not being as accessible. Should have done this from the start
absolutely no problem
you shouldnt even begin to say sorry about anything
everyone is HYPED UP because you did that
amazing job with the arm stuff
Oh. Rechunk is broken. Need to figure that out
oh no LOL
it seems to be fine tho
GitHub
chore: replace x86_64-only Flatpaks with amd64 alternatives by p5 ·...
I'm not too sure how the overrides work, so please give this a good review :)
This replaces Firefox with Chromium (the next best option for a browser).
And removes Thunderbird, since it&...
this seems really happy
oh....
true
Hmm.. Maybe there's not anything wrong with rechunk? I'm confused
merged that one PR
lets see what happens
OH! We need to give the repo permissions to push to that tag
Rechunk may be fine
omg.
@j0rge
I'm doing it 🙂
but like doesnt the repo already have perms tho?
oh ok then LOL
This is what I'm doing. The lts repo didn't have any permissions previously, so I'm providing write
perfect then!!!
didnt know that we had to do that LOL
SO WE ARE DONE THEN LES GOOOOO