ThoughtSpot For Developers•2d ago

Geovane - [Simple New config request]Hello TS...

[Simple New config request] Hello TS team 👋 I am taking a deeper look at the source code and one small change would offer a huge improvement for us. If you check the src > embed > liveboard.ts, we have: <attached_screenshot> On it, we have a single config (fullHeight) performing two distinct actions (they kind of feel that shouldn't be in a single config per the name, at least I couldn't guess only by the name fullHeight). Can we have it broken into two? Motivation: Right now we need to keep the fullHeight = true.... but we also need to fetch visualizations incrementally as users scroll the page... As it is already there, I feel we could easily create a new one. Note: In the future with more people running the lazy load, it may also reduce the load on TS servers too 😇 Example:

   /**
     * If set to true, the embedded object container dynamically resizes
     * according to the height of the Liveboard.
     *
   */
   fullHeight?: boolean;
   /**
     * It loads all visualizations on the Liveboard
     * simultaneously, which results in multiple warehouse
     * queries and potentially a longer wait for the topmost
     * visualizations to display on the screen.
     * Setting `incrementalLoad` to `true` fetches visualizations
     * incrementally as users scroll the page to view the charts and tables.
   */
   incrementalLoad?: boolean; // <--------- The new one

   /**
     * If set to true, the embedded object container dynamically resizes
     * according to the height of the Liveboard.
     *
   */
   fullHeight?: boolean;
   /**
     * It loads all visualizations on the Liveboard
     * simultaneously, which results in multiple warehouse
     * queries and potentially a longer wait for the topmost
     * visualizations to display on the screen.
     * Setting `incrementalLoad` to `true` fetches visualizations
     * incrementally as users scroll the page to view the charts and tables.
   */
   incrementalLoad?: boolean; // <--------- The new one

Let me know if you have any questions. Thanks! 🙌

6 Replies

shikharTS•2d ago

Thanks @Geovane we will look into it. cc @utsav.kapoor @yuichirio_ha

utsav.kapoor•2d ago

@Geovane - Can you also open a community idea for this. I will add this in roadmap. The ask is valid here and we have been thinking on how to achieve this. Will keep you updated on this @prateekagr98 - Lets discuss this between the both of us

GeovaneOP•12h ago

Thank you so much @utsav.kapoor @shikharTS @prateekagr98 . I will create the ticket and post here.

prateekagr98•12h ago

@utsav.kapoor Definitely

GeovaneOP•11h ago

Here is @prateekagr98 @shikharTS @utsav.kapoor Case: 00383805 Let me know if I should have posted it somewhere else too 🙂

utsav.kapoor•5h ago

@Geovane - Can you post it on thoughtspot community as an idea. We use cases for bugs.

Gaming

Programming

Geovane - [Simple New config request]Hello TS...

Did you find this page helpful?