C#•2w ago

✅ Get bytes and append to List c#

public class ByteWriter {
    public MemoryStream Stream = new MemoryStream();
    public BinaryWriter Writer;

    public ByteWriter() {
        Writer = new BinaryWriter(Stream);
    }

    public void Write<T>(T value) {
        Writer.Write(value);
    }
}

public class ByteWriter {
    public MemoryStream Stream = new MemoryStream();
    public BinaryWriter Writer;

    public ByteWriter() {
        Writer = new BinaryWriter(Stream);
    }

    public void Write<T>(T value) {
        Writer.Write(value);
    }
}

im trying to write a method that will append the bytes for value to the stream Stream, T will be a variable amount of bytes so im taking it in as a generic type, but Write doesnt have a generic overload any ideas what i can do?

20 Replies

Joreyk ( IXLLEGACYIXL )•2w ago

you have 2 stages 1. convert to byte and write 2. map T to a writer that knows how to convert T to bytes eg something like this pseudo code https://gist.github.com/IXLLEGACYIXL/9f65b0ebc2ff38a22b0d779e0c92fd59

Gist

t.cs

GitHub Gist: instantly share code, notes, and snippets.

Joreyk ( IXLLEGACYIXL )•2w ago

@mynarco

prxxssOP•2w ago

got it, thank you, ill try to get this working what exactly is Converter?

Joreyk ( IXLLEGACYIXL )•2w ago

that thing who knows the plan to convert T to bytes for example you have a Vector3 then you will need some sort of converter who knows how to convert Vector3 to bytes and read Vector3 from bytes

prxxssOP•2w ago

like this?

class Converter {
    public byte[] ConvertToBytes(int value) {

    }

    public byte[] ConvertToBytes(ushort value) {
        
    }
}

class Converter {
    public byte[] ConvertToBytes(int value) {

    }

    public byte[] ConvertToBytes(ushort value) {
        
    }
}

wait no i still have no idea how it works i cant reallyt understand how the psuedocode works? Any way you can provide a working example? Its fine if it only converts 1 type just need an idea of how to add a type conversion

Joreyk ( IXLLEGACYIXL )•2w ago

@mynarco ive updated the gist at the bottom is a sample or top whereever it is for you

prxxssOP•2w ago

ok looking now

Joreyk ( IXLLEGACYIXL )•2w ago

so you jump from converter to converter until you can convert it to bytes and your primtive converters are used for determing the endless chain forget about the generic context for now

prxxssOP•2w ago

ok got that down, but how do i define the dictionary then? because Converter takes in a generic..

Joreyk ( IXLLEGACYIXL )•2w ago

make foreach converter a non generic class which is capable of instantiating the converter from a Type parameter with activate instance so your helper is a factory of converters you can source gen that and your converters

Joreyk ( IXLLEGACYIXL )•2w ago

https://gist.github.com/IXLLEGACYIXL/b8b501f1fb3600d99a4fc72c14f8b8c8

Gist

gist:b8b501f1fb3600d99a4fc72c14f8b8c8

GitHub Gist: instantly share code, notes, and snippets.

Joreyk ( IXLLEGACYIXL )•2w ago

this is how it could look, or atleast thats my source gened code that implements what i tell you

prxxssOP•2w ago

got it, thanks

Joreyk ( IXLLEGACYIXL )•2w ago

this is maybe more complex than you need it as i wanted ful generic compatibility if you want it fixed like system.text.json then you dont need to worry about all of that too much, generating the extension method would be fine allready depends what you want

prxxssOP•2w ago

i got it thanks :)

ero•2w ago

Does T need to be any type? Or are blittable types enough? The suggestions are (no offense) ridiculous either way If the types can be blittable, just include CommunityToolkit.HighPerformance and use its StreamExtensions You can just use Stream.Write<T> on the MemoryStream then, no need to implement anything yourself If T should be any type that you defined yourself, I recommend implementing an interface over creating converters:

interface ISerializable<TSelf>
  where TSelf : ISerializable<TSelf>
{
  static abstract void Serialize(Stream stream, TSelf value);
}

interface IDeserializable<TSelf>
  where TSelf : IDeserializable<TSelf>
{
  static abstract TSelf Deserialize(Stream stream);
}

interface ISerializable<TSelf>
  where TSelf : ISerializable<TSelf>
{
  static abstract void Serialize(Stream stream, TSelf value);
}

interface IDeserializable<TSelf>
  where TSelf : IDeserializable<TSelf>
{
  static abstract TSelf Deserialize(Stream stream);
}

prxxssOP•2w ago

thank you that works well. i appreciate it :), T is just a number, like byte, ushort, uint, and ulong

ero•2w ago

Yeah then don't overcomplicate it and just use what's already there As a side note, in your original code (ByteWriter), you should consider if those fields really need to be public. .NET recommends fields to always be private or protected, properties should be public $close

MODiX•2w ago

If you have no further questions, please use /close to mark the forum thread as answered

prxxssOP•2w ago

Of course. I really appreciate it

Gaming

Programming

✅ Get bytes and append to List c#