B
blendOSβ€’2mo ago
autumn (CIPG)

user/blend broken stuff tracking

I'm just digging through the user and blend code and am noticing many issues, so I'm gonna track them here.
6 Replies
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’2mo ago
okie dokie
autumn (CIPG)
autumn (CIPG)OPβ€’2mo ago
Okay so first of all, the containers are out of date, Fedora 39 literally goes EOL in 5 days. Instead of updating the containers manually all the time, we could do something like this: fedora:taggoeshere -> registry.fedoraproject.org/fedora-toolbox:taggoeshere and also, the recent Ubuntu 24.04 change does not follow the convention set by Ubuntu 22.04; -lts is added to the end of its tag:
'ubuntu-22.04': 'quay.io/toolbx/ubuntu-toolbox:22.04',
'ubuntu-24.04-lts': 'quay.io/toolbx/ubuntu-toolbox:24.04',
'ubuntu-22.04': 'quay.io/toolbx/ubuntu-toolbox:22.04',
'ubuntu-24.04-lts': 'quay.io/toolbx/ubuntu-toolbox:24.04',
autumn (CIPG)
autumn (CIPG)OPβ€’2mo ago
Also, user has a separate distro list, which is out of date compared to the list in blend, and its default distro is incorrect. I just sent over a PR to fix both of these issues. @Rudra https://github.com/blend-os/blend/pull/12
GitHub
Fix supported distro checking and handling by askiiart Β· Pull Reque...
Previously, distros were checked in both blend and user, which led to user's distro list being forgotten about and severely out of date, not to mention incorrect in the first place; it&...
autumn (CIPG)
autumn (CIPG)OPβ€’2mo ago
And associate_binary is duplicated for dissociate and associate, presumably Rudra forgot to update it when copy-pasting. This may work fine for the CLI, and is definitely broken in the GUI, so presumably associations currently can't be removed via the GUI. I've got a diff here to fix this, but this may need to be updated as I don't know if its click.argument is right, and we may want to have dissociation messages be separate from association messages (association_msg)
autumn (CIPG)
autumn (CIPG)OPβ€’2mo ago
also, there was some other stuff referencing distros in the distro map that no longer exist/have changed, so i fixed those, and cleaned up a few small bits of code i noticed - those are in the misc-fixes branch of my fork, now, i'll send them over in a bit, and i can split those two up if that's preferred update: eepy still haven't sent it over
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’2mo ago
eepy
Want results from more Discord servers?
Add your server