Efficiency Checker Mod - pipe bug
Hey @Marcio <Checkers/Copier/WallSup> I've been using your incredible Efficiency Checker Mod and for some reason I can't get the pipe checker to work on Dark Matter Residue and Excited Photonic Matter.
Those 2 always show red/blank on the injected input. The required output works fine.
Reproducible with the simplest possible setup: 1 Converter producing Photonic Matter going into a Quantum Encoder.
Seems like a but to me. Wondering if anyone else has the same problem?
29 Replies
I have to got into that endgame stuff yet, so I didn't go the chance to check 😅
^^
Want my save to test it?
I have the simplest case setup right as you load, and I do have other mods installed but nothing that should matter™
I will have a look when I can
everything seens fine 🤔
hmm... looks like a bug in the pipe checker itself 🤔
huh interesting
I hadn't even considered the hand tool because of the FOV issue but good to know as a workaround
I see what it is, now
The building also has some bug when you try to use it after a pipe has been dismantled. I am no longer receiving the event in my code, and eventually the list it has cached become invalid, and it crashes 🤔
I'm not sure I see what you mean by that but I've had a couple of crashes related to the pipe wall checker, nothing reproducible though. Sometimes if I interact with it immediately after placing it on a wall, without any pipes, instant crash.
It happens if you have dismantled a pipe before, after you loaded the save
Hmm seems to work just fine for me doing that but idk maybe I'm doing it wrong
For me it crashes all the time, but that depends on order of stuff
If I dismantle a pipe and replace right after, and place that checker on THAT pipe = crash
because it is the last on an internal list, but the one that was dismantled came before and got destroyed, but my code no longer knows about it, and while looking through the list, it crashes
The wall checker, I mean. The inline one works differrent and don't rely on that internal list
ahh I see, well sometimes it crashes when I click on the checker before I have ever connected any pipe to it though. Not sure if it checks through the list even if nothing is connected..
The way it is right now, it goes throug ALL the pipes to see witch one passes through it. It was a very old method, before I learn how to get Actors in a line or in a volume. I will change that for the next version
So, since it has to go through ALL the pipes it colected in the load and later on while you were building, it keeps them there to be checked every single time. And if one of those get dismantled, it will crash if it tries to pass throught it
So, for the time being, the hand tool is safer, it does not do any of that
I do receibe notifications of "new building placed", and I catch and see if it is a belt or pipe, and store it. But I am no longer receiving the notification of "building has been dismantled" ☹️
And about why the checker itself does not actually report the inject input, I found out why and have already fixed
Oh wow that explains it then. Yeah alright. Can't help with the dismantle event sadly.
Okay great work! Why didn't it display though, if you don't mind? Because I tested it on water and nitrogen and those worked fine. Was it related to the new "gases" or smth else?
The new logic must have filled in the input fluid with zero quantity. The hand tool does that. The checker building does not. I am not sure of what exactly happen, but that kinda 'filter out" the inputs, only considering the outputs, and the input returns as Zero
It is a very complex logic, sometimes a single change on a specific part makes it all fall appart 😅
Really seems like you should make the buildings work the same way the hand tool does ^^ but I'm sure there's a good reason.
BTW I found another couple bugs:
1. I think the inline pipeline checker does not notice a MK1 pipe if it is 1 or more segments away. The hand tool does consider all pipe segments along the way.
2. Neither the inline nor the hand tool considers valves for throughput, no matter where I put the valve and where I check it doesn't realize that I have limited the pipe lower than max.
^^^^ Valve is at 200/m
Got it. I think I found what was wrong
The hand checker got it by pure chance , in the left one. If it was measuring by the right of that checker, it would display the same
in the end it wasn't it, it was the fact that I was not determining if it was a liquid or a gas 😅
Solution
See if the new version works, now
Okay certainly the throughput and wall checker are working great now! The input for the new gases also "works" but I still found some inconsistencies, not sure if you would consider these bugs but I'm gonna describe them anyway.
For some reason the injected input for the new gases seems to only update once the pipe is filled meaning it doesn't check what the machine is set to it just shows red. But the required output does show correctly.
Meanwhile the hand tool is completely lost. Once the pipe actually contains some Dark Matter Residue it works fine, but if I stop production and flush the pipe - back to nothing.
For other normal liquids the inline checker works fine in the same situation, but the hand tool is still lost until the pipe gets filled.
Anyway once the pipes are filled everything is working so I'm gonna say good work and thanks for responding so quickly.
It relies on an information the pipes have to see wich element is in there. Empty pipes = no info, so it does not know what is being injected
But that's not how the inline checker works with water or alumina solution or Nitrogen etc. It shows the numbers even with empty pipes and unpowered machines. Except only for the 2 new gases it doesn't show. (Pic 1)
NVM you mean the hand tool right? Okay so that's intended then. Still leaves the inconsistency with the inline checker..
Fluids area very troublesome to make it right, because they are bi-directional, it is really hard to measure the troughput limit
Right that's true