Draft: feat: Add featured apps configura...
i did put in this PR for KDE discover. we'll see if it ends up being accepted. but if it does, thats one less thing to have to rely on
yafti for so it can be streamlinedGitLab
Draft: feat: Add featured apps configurable URL (!933) · Merge requ...
Add function to check config for featured URL closes
27 Replies
creating thread in case its helpful 🙂
@𝓯𝓻𝓮𝓪𝓴onomist sorry i should use the thread i created
yeah i eventually saw it
i agree with your idea
ill updoot
requiring each downstream distro to have to build it themselves is not great
@jardon
seems rational and reasonable to me
it seems like a weird thing to worry about modification of the featured list. i mean it doesnt have any impact on software sources ya know?
"i think youre failing to consider" is maybe a little accusative towards president of kde
lmao
i should chill a bit but yeah
i think your idea is better
ya the first part is the least chill. the two paragraphs after are at least really grounded in fact
yeah i posted
i honestly didnt know he was the president 💀
i am a yapping machine
thanks for weighing in. hopefully it helps
there are so many things that a user process could override easily in KDE
like
that's just how KConfig works
readable plain text files
if that's somehow a problem then why offer any settings at all :pepelaugh:
the joys of collaboration
idk if theres a .kcfgc file u would need to add it to
idk how discover does it
looks like it does it in a weird way
i wonder if hes worried more about the desktop vs mobile configs and it featuring very not optimized desktop apps on mobile
That is whoever sets the file's problem
I don't disagree
@jardon well now your solution is getting code reviewed
Lol
i just saw that!
t e a m w o r k
you have any thoughts on his feedback?
im really not sure why he's so worried about the featured list like messing with it is going to install malware
@𝓯𝓻𝓮𝓪𝓴onomist
Yeah not a huge deal
i still dont like the compromise, but maybe i should just take what i can get
if it works then great
its not like i even like kde
I like kde
also nate the pull request beast himself agrees with your idea instead
Do you have the ability to build and test my PR? I don't have a environment set up for it and the in-laws are in town
not right now
@jardon let Mr president eat his dinner lmao
It will get merged soon
I'm tired of rebasing 🥺
He can do it
That's what usually happens anyway