Can we make akshara run 'grub-mkconfig' only if grub is installed?

I have a deep deep seething hatred for grub that started back in the opensolaris days. I run systemd-boot or refind on all my machines. Can we make the exec call to grub-mkconfig in akshara be configurable based on the presence of grub packages in the expanded system.yaml or perhaps run as a hook? I am a python developer and would be happy to code this up and send over an MR.
45 Replies
Asterisk
Asterisk2mo ago
why ask? though I'd recommend testing your edit first to see if blend can actually work with other bootloaders
Zezengorri
Zezengorri2mo ago
Thanks for the quick reply! I thought I should be polite I suppose. And I know what it's like to have a dev or architect make demands on a project without learning about the people working on it or how things are done.
Valkyrja
Valkyrja2mo ago
ム丂イ乇尺ノ丂ズ received a thank you Jao!
Zezengorri
Zezengorri2mo ago
I would be happy to write a test for it. Is pytest OK for the units? Maybe serverspec for the build?
Asterisk
Asterisk2mo ago
not what I meant I mean get a VM and test your fork test alternate bootloaders instructions for testing are in the akshara README
Zezengorri
Zezengorri2mo ago
Should I create a login on this instance and fork into my own namespace? I'm running systemd-boot with refind right now.
Asterisk
Asterisk2mo ago
yes, if that's possible on blendOS?
Zezengorri
Zezengorri2mo ago
Yep. The EFI partition id needed to be fixed but that's in the installer. That is up to the gitlab admin. I will send in a request for a login.
Asterisk
Asterisk2mo ago
that's getting replaced soon anyway shit he didn't remove that I thought he did
Zezengorri
Zezengorri2mo ago
Excellent.
Asterisk
Asterisk2mo ago
Rudra isn't very active so it might be a while @Rudra in the meantime you can clone and edit locally then just change the origin later only gitlab admin :P
Zezengorri
Zezengorri2mo ago
No worries. I was a Chef configuration engineer and a gitlab admin in another life as well. I can help with that too if y'all want.
Asterisk
Asterisk2mo ago
team members only :( obv wouldn't grant a nobody admin if that's what you mean by help
Zezengorri
Zezengorri2mo ago
That's what I mean and I am glad you wouldn't just give a rando admin access to your gitlab instance. We can talk later if y'all need help and you decide to trust me. I will request access on gitlab and build/test/deploy locally in my fork for now.
Asterisk
Asterisk2mo ago
we have CI if you need however akshara doesn't need building the speed improvements are minimal
Zezengorri
Zezengorri2mo ago
A gitlab-runner would be nice for running automated tests.
Asterisk
Asterisk2mo ago
we have 2 3 actually, but the third one is exclusively for ISO builds
Zezengorri
Zezengorri2mo ago
Excellent. Is there a project with a gitlab-ci.yml I could look at? Wait. I see one in image-builder.
Zezengorri
Zezengorri2mo ago
Thanks.
Valkyrja
Valkyrja2mo ago
You're thanking too much ó_ò
Zezengorri
Zezengorri2mo ago
I'm in. User is 5y1vn. Looks like I need to wait for an admin to allow me to create projects in my namespace.
No description
Asterisk
Asterisk2mo ago
again, @Rudra we gotta remove that gitlab's permission system isn't granular enough for a "trusted" role or allowing people to only fork apparently
Zezengorri
Zezengorri2mo ago
No worries. I'll get coding tonight.
Rudra
Rudra2mo ago
Oh I thought I disabled that, I'll have a look at it real quick! Just updated your project limit, let me know if it doesn't work!
Zezengorri
Zezengorri2mo ago
Thanks for your help! I am getting a different error now. It says:
Limit reached You've reached your limit of 100 projects created. Contact your GitLab administrator.
Limit reached You've reached your limit of 100 projects created. Contact your GitLab administrator.
No description
Valkyrja
Valkyrja2mo ago
@Zezengorri, you've gained the level 1 rs2009 received a thank you Jao!
Asterisk
Asterisk4w ago
fixed I hope
Zezengorri
Zezengorri4w ago
Same error.
No description
Asterisk
Asterisk4w ago
I love gitlab @Zezengorri logout and back in Then try again
Zezengorri
Zezengorri4w ago
It worked! OK. Quick question. For testing, do y'all use blend-inst with a config.json to build your VM disk image?
Asterisk
Asterisk4w ago
that's to install the end distro the ISO is built with archiso
Asterisk
Asterisk4w ago
gotcha I'll remove the notice
Zezengorri
Zezengorri4w ago
end distro?
Asterisk
Asterisk4w ago
USB/DVD -> disk end user install we don't have premade VM images
Zezengorri
Zezengorri4w ago
Perfect. That's what I need. I just wanted to make sure I was using the tools that the end users use.
Asterisk
Asterisk4w ago
the sample config.json is still outdated I think from v3 and it'll be replaced with calamares in v5
Zezengorri
Zezengorri4w ago
I am building one now. Yeah, I noticed that a few required keys were missing. Do you know if blend-postinst is used as well? Is this being worked on now? Calamares would be easier to build images.
Asterisk
Asterisk4w ago
privately yes not sure what that does
Zezengorri
Zezengorri4w ago
Found some info. I think it saves what you enter in the base gnome setup after initial install. https://blendos.co/reference/utils/blend-inst/
blend-inst - blendOS
Reference for our installer
Zezengorri
Zezengorri4w ago
I think I'm all set. I will get a MR over soon.
Asterisk
Asterisk3w ago
I haven't seen any commits on your fork
Zezengorri
Zezengorri3w ago
My WIP for akshara is in there. I will be happy to remove the debug logger if it comes up in code review. I need to finish testing the changes in my VM.
Want results from more Discord servers?
Add your server