B
blendOSβ€’3mo ago
Zezengorri

Can we make akshara run 'grub-mkconfig' only if grub is installed?

I have a deep deep seething hatred for grub that started back in the opensolaris days. I run systemd-boot or refind on all my machines. Can we make the exec call to grub-mkconfig in akshara be configurable based on the presence of grub packages in the expanded system.yaml or perhaps run as a hook? I am a python developer and would be happy to code this up and send over an MR.
45 Replies
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
why ask? though I'd recommend testing your edit first to see if blend can actually work with other bootloaders
Zezengorri
ZezengorriOPβ€’3mo ago
Thanks for the quick reply! I thought I should be polite I suppose. And I know what it's like to have a dev or architect make demands on a project without learning about the people working on it or how things are done.
Valkyrja
Valkyrjaβ€’3mo ago
οΎ‘δΈ‚ο½²δΉ‡ε°ΊοΎ‰δΈ‚γ‚Ί received a thank you Jao!
Zezengorri
ZezengorriOPβ€’3mo ago
I would be happy to write a test for it. Is pytest OK for the units? Maybe serverspec for the build?
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
not what I meant I mean get a VM and test your fork test alternate bootloaders instructions for testing are in the akshara README
Zezengorri
ZezengorriOPβ€’3mo ago
Should I create a login on this instance and fork into my own namespace? I'm running systemd-boot with refind right now.
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
yes, if that's possible on blendOS?
Zezengorri
ZezengorriOPβ€’3mo ago
Yep. The EFI partition id needed to be fixed but that's in the installer. That is up to the gitlab admin. I will send in a request for a login.
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
that's getting replaced soon anyway shit he didn't remove that I thought he did
Zezengorri
ZezengorriOPβ€’3mo ago
Excellent.
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
Rudra isn't very active so it might be a while @Rudra in the meantime you can clone and edit locally then just change the origin later only gitlab admin :P
Zezengorri
ZezengorriOPβ€’3mo ago
No worries. I was a Chef configuration engineer and a gitlab admin in another life as well. I can help with that too if y'all want.
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
team members only :( obv wouldn't grant a nobody admin if that's what you mean by help
Zezengorri
ZezengorriOPβ€’3mo ago
That's what I mean and I am glad you wouldn't just give a rando admin access to your gitlab instance. We can talk later if y'all need help and you decide to trust me. I will request access on gitlab and build/test/deploy locally in my fork for now.
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
we have CI if you need however akshara doesn't need building the speed improvements are minimal
Zezengorri
ZezengorriOPβ€’3mo ago
A gitlab-runner would be nice for running automated tests.
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
we have 2 3 actually, but the third one is exclusively for ISO builds
Zezengorri
ZezengorriOPβ€’3mo ago
Excellent. Is there a project with a gitlab-ci.yml I could look at? Wait. I see one in image-builder.
Zezengorri
ZezengorriOPβ€’3mo ago
Thanks.
Valkyrja
Valkyrjaβ€’3mo ago
You're thanking too much Γ³_Γ²
Zezengorri
ZezengorriOPβ€’3mo ago
I'm in. User is 5y1vn. Looks like I need to wait for an admin to allow me to create projects in my namespace.
No description
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
again, @Rudra we gotta remove that gitlab's permission system isn't granular enough for a "trusted" role or allowing people to only fork apparently
Zezengorri
ZezengorriOPβ€’3mo ago
No worries. I'll get coding tonight.
Rudra
Rudraβ€’3mo ago
Oh I thought I disabled that, I'll have a look at it real quick! Just updated your project limit, let me know if it doesn't work!
Zezengorri
ZezengorriOPβ€’3mo ago
Thanks for your help! I am getting a different error now. It says:
Limit reached You've reached your limit of 100 projects created. Contact your GitLab administrator.
Limit reached You've reached your limit of 100 projects created. Contact your GitLab administrator.
No description
Valkyrja
Valkyrjaβ€’3mo ago
@Zezengorri, you've gained the level 1 rs2009 received a thank you Jao!
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
fixed I hope
Zezengorri
ZezengorriOPβ€’3mo ago
Same error.
No description
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
I love gitlab @Zezengorri logout and back in Then try again
Zezengorri
ZezengorriOPβ€’3mo ago
It worked! OK. Quick question. For testing, do y'all use blend-inst with a config.json to build your VM disk image?
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
that's to install the end distro the ISO is built with archiso
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
gotcha I'll remove the notice
Zezengorri
ZezengorriOPβ€’3mo ago
end distro?
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
USB/DVD -> disk end user install we don't have premade VM images
Zezengorri
ZezengorriOPβ€’3mo ago
Perfect. That's what I need. I just wanted to make sure I was using the tools that the end users use.
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
the sample config.json is still outdated I think from v3 and it'll be replaced with calamares in v5
Zezengorri
ZezengorriOPβ€’3mo ago
I am building one now. Yeah, I noticed that a few required keys were missing. Do you know if blend-postinst is used as well? Is this being worked on now? Calamares would be easier to build images.
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
privately yes not sure what that does
Zezengorri
ZezengorriOPβ€’3mo ago
Found some info. I think it saves what you enter in the base gnome setup after initial install. https://blendos.co/reference/utils/blend-inst/
blend-inst - blendOS
Reference for our installer
Zezengorri
ZezengorriOPβ€’3mo ago
I think I'm all set. I will get a MR over soon.
πŸŽ„ Asterisk
πŸŽ„ Asteriskβ€’3mo ago
I haven't seen any commits on your fork
Zezengorri
ZezengorriOPβ€’3mo ago
My WIP for akshara is in there. I will be happy to remove the debug logger if it comes up in code review. I need to finish testing the changes in my VM.
Want results from more Discord servers?
Add your server