Why does no-body even react to my tiny bugfix? Is it wrong?
I created a super tiny bugfix for an issue with the types in one of the packages, but nobody even gave any feedback in nearly a month - I don't understand why.
https://github.com/prisma/prisma/pull/24916
GitHub
fix(migrate): correct types import path in @prisma/migrate by bored...
The actual package only contains the types in dist/migrate/src, but the package.json types pointed to a file that doesn't exist.
2 Replies
Hi @boredland 👋
Thank you for raising this.
I have shared it with the team.
Hi @boredland, Thank you for your contribution! Just a quick note regarding community pull requests: We typically don't respond immediately, so it's perfectly normal if you don't hear back from us within a few days or even weeks. We have an internal process where we review community PRs during our sprints and then assign them to team members for a thorough review.
In the meantime, could you please let us know if this PR addresses a critical issue or is particularly urgent for you? If so, we’d like to be aware of that and prioritize it accordingly.
Hi! It impacts any typescript usage of
@prisma/migrate
, as the compiler doesn't find the appropriate files. You can work around by providing either you own declarations or live with a ts-ignore
and no types - we do the latter. I just thought, hoped, that this would be a big enough issue with a small enough solution (the definitions are already there, just the path is pointing to the wrong file), that it would at least warrant someone taking a look in ~a month.