Hello I'm having trouble using the "

Hello I'm having trouble using the "present" feature when embedding a liveboard. I keep receiving an error: Error: Fullscreen API is not enabled We are using the react components and the sdk
25 Replies
utsav.kapoor
utsav.kapoor6mo ago
Hi @mdoyle-fleetio - I have been debugging this internally and it is working and we are able to show fullscreen for embed mode in other clusters. Can you check if somehow your code has an iframe inside an iframe ? Happy to debug more this with you
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
Hi @utsav.kapoor thanks for looking into this. From what I can tell there are no iframes in the liveboard embeds ancestor chain
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
No description
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
after the dom is loaded - the first instance of an <iframe> element is the TS embed
utsav.kapoor
utsav.kapoor6mo ago
Are you using viz embed or this is a full liveboard embed ?
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
<LiveboardEmbed />
utsav.kapoor
utsav.kapoor6mo ago
I am checking a few things. Will reply back ion an hour or so
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
sounds good, thank you!
utsav.kapoor
utsav.kapoor6mo ago
I have put this as a potential fix: https://github.com/thoughtspot/visual-embed-sdk/pull/1186/ I will be publishing this tomorrow/Monday as a patch for 1.32. If you can upgrade your SDK and check again. While you do this, ill continue looking into this
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
sounds good - i will update our sdk version on monday and let you know what I find thank you so much! hi there - I've tried updating to the latest 1.32.0 release but I'm still experiencing the same behavior. Is there a different SDK version I should be using?
utsav.kapoor
utsav.kapoor6mo ago
@mdoyle-fleetio - We havent deployed the fix to the new version. I will update you on this thread today EOD on the delivery of the patch
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
ok that sounds good - thank you
utsav.kapoor
utsav.kapoor6mo ago
Deployed the fix to 1.32.1 Can you check with that ? Otherwise lets have a call to debug this together.
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
I'm looking into this now. I'll report my findings shortly using 1.32.1 on my localhost - presentation mode works correctly on Safari but still not on Chrome. On chrome I'm experiencing the same issue as before i am experiencing a totally new issue with the latest version of the SDK also which I'm working on writing up. For whatever reason when I deploy to a review app and our Javascript gets bundled together with esbuild - I receive a syntax error from the SDK library
utsav.kapoor
utsav.kapoor6mo ago
@mdoyle-fleetio - Can you check on Mozilla also ? I will check if there is some setting on Chrome. Can you also try to see if this is happening on your laptop chrome ? Can you send me the error in bundling ? Which bundler do you use ?
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
- On sdk version 1.32.1 - Fullscreen is working on Mozilla on localhost (after i changed some settings to get around a 403) - When I try to deploy to a review app to test - I receive the following JS error:
SyntaxError: missing ) after argument list
SyntaxError: missing ) after argument list
in all browsers - We are using esbuild v0.20.2
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
No description
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
i think esbuild does some minification on \n new line characters that could be causing an issue https://esbuild.github.io/faq/#minified-newlines
utsav.kapoor
utsav.kapoor6mo ago
Let me propose a working session through the SRE team. We can work on resolving both issues: 1. Fullscreen Not working on chrome 2. Esbuild bundling error I am also checking why this would not work on chrome so if we can get this to work before the call, we can cancel it
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
ok that sounds good - how should I go about scheduling the working session?
utsav.kapoor
utsav.kapoor6mo ago
I have asked the SRE team to facilitate the working session
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
👍 I've figured out the issue on chrome with the latest SDK. The document embedding the the iframe must have correct values for the Feature-Policy header in addition to the Permissions-Policy header. In the example below I've spoofed allowing any origin * for fullscreen and it allows chrome to go into full screen presentation mode
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
I will update the support ticket as it will be on us to update these headers if we want to support full screen mode
No description
utsav.kapoor
utsav.kapoor6mo ago
Cool. Great that this is resolved. Now we can focus on build issue
mdoyle-fleetio
mdoyle-fleetioOP6mo ago
👍 thanks for you help

Did you find this page helpful?