Flow•2y ago

Giovanni S | Flow (2024-07-25)

I'm getting some weird errors running a

load<@AnyResource>

load<@AnyResource>

in the latest pre-release CLI

Needle

N

Needle•7/25/24, 5:57 PM

I've created a thread for your message. Please continue any relevant discussion in this thread.

You can rename this thread using

If this is a technical question that others may benefit from, considering also asking it on Stackoverflow: https://stackoverflow.com/questions/ask?tags=onflow-cadence

Giovanni S

G

Giovanni SOP•7/25/24, 5:57 PM

The test here - https://github.com/onflow/hybrid-custody/actions/runs/10086158860/job/27888252177?pr=170#step:5:73

Previously passed with the same code using , but fails with with the message:

The txn is failing on loading the resource as with this txn

Giovanni S

G

Giovanni SOP•7/25/24, 5:58 PM

The message line when trying to load is odd considering all other non-load test cases succeed

Giovanni S

G

Giovanni SOP•7/25/24, 6:04 PM

So looks like the txn succeeds in .27 but starts failing in .28 which had a Cadence update to Cadence .
I don't see anything in that version's release notes that would lead me to believe there's a significant change in load behavior.

Does this look like a bug? cc @turbolent @Supun

turbolent

T

turbolent•7/25/24, 6:51 PM

Hmm, that looks odd. Do you have this as a reproducer somewhere? (e.g. test in repo)

turbolent

T

turbolent•7/25/24, 6:54 PM

ah, sorry, I didn't see the link

turbolent

T

turbolent•7/25/24, 6:55 PM

could you please try with the versions in between, i.e. 28, 29, 30?

turbolent

T

turbolent•7/25/24, 6:55 PM

that way we can maybe better pinpoint where the regression was introduced

Giovanni S

G

Giovanni SOP•7/25/24, 7:54 PM

27 succeeds, 28, 29, 30, 31 all fail with the same output

Giovanni S

GGiovanni S 27 succeeds, 28, 29, 30, 31 all fail with the same output

turbolent

T

turbolent•7/25/24, 8:00 PM

great thanks!

turbolent

T

turbolent•7/25/24, 8:01 PM

I guess it should be possible to check out that branch locally and run the tests right?

turbolent

T

turbolent•7/25/24, 8:01 PM

I'll try to replace the Cadence version and see what changed

Giovanni S

G

Giovanni SOP•7/25/24, 8:03 PM

Made an issue here - https://github.com/onflow/cadence/issues/3491

turbolent

T

turbolent•7/25/24, 8:38 PM

@Giovanni S and I guess even

main

main

of https://github.com/onflow/hybrid-custody fails with the newer CLI/Cadence versions?

turbolent

Tturbolent @Giovanni S and I guess even `main` of https://github.com/onflow/hybrid-custody ...

Giovanni S

G

Giovanni SOP•7/25/24, 8:44 PM

Yes it does. I also rolled back CLI version in https://github.com/onflow/hybrid-custody/pull/170/commits/dced96ebdf964c0b0bd21a96b64779dcd6027ec1

and the successive CI run passed
https://github.com/onflow/hybrid-custody/actions/runs/10100835346/job/27933086660

Giovanni S

G

Giovanni SOP•7/25/24, 8:47 PM

Wa able to repro on migrationnet in transaction 55ac88fd65ed289e67d5aa960a1f6f3d4e8ab9b702f2687e3cab65b916d3e3e0

turbolent

T

turbolent•7/25/24, 10:18 PM

Supun already has a fix https://github.com/onflow/cadence/pull/3493

turbolent

Tturbolent Supun already has a fix https://github.com/onflow/cadence/pull/3493 🎉 👏

Giovanni S

G

Giovanni SOP•7/25/24, 11:02 PM

Awesome, thank you!

import "HybridCustody"
import "Burner"

transaction {
    prepare(acct: auth(Storage) &Account) {
        let m <- acct.storage.load<@AnyResource>(from: HybridCustody.ManagerStoragePath)
            ?? panic("no resource found in manager storage path")
        Burner.burn(<- m)
    }
}

import "HybridCustody"
import "Burner"

transaction {
    prepare(acct: auth(Storage) &Account) {
        let m <- acct.storage.load<@AnyResource>(from: HybridCustody.ManagerStoragePath)
            ?? panic("no resource found in manager storage path")
        Burner.burn(<- m)
    }
}