Missing favicons
When adding companies most of them get favicons, i.e. get a match in
https://favicon.twenty.com/<company>. But some don't. Is there a way to add to the main favicon image repository?15 Replies
its acutally dependend on the domain you entered for this record favicon.twenty just resolves & caches the favicons from the companies website (https://github.com/twentyhq/favicon)
GitHub
GitHub - twentyhq/favicon: 100% free and open-source favicon provider
100% free and open-source favicon provider. Contribute to twentyhq/favicon development by creating an account on GitHub.
Hey @Brendan ,I have the same issue as @thilles , what are the actual requirements of a favicon that twentyhq/favicon needs in order to find a site's favicon? I've spend hours digging through HTML/Meta between a working site and a not working site and I'm stumped
Yeah, I got that from the favicon repo. But what can be done if the cache doesn't have the specific records favicon?
it should be retrieved from the domain once you request it from the favicon server
GitHub
favicon/src/favicon/url-fetcher/html.url-fetcher.ts at 81024b6f5da8...
100% free and open-source favicon provider. Contribute to twentyhq/favicon development by creating an account on GitHub.
it queries for these components
Thank you @Brendan !
Okay. As far as I can tell it looks for a href in a link tag, from either of the attributes
link[rel=icon], link[rel="shortcut icon"], link[rel="apple-touch-icon"]' it finds.
Then it combines the baseurl with the href and pushes that to the favicon server.
From two of the failing records, I can see that they specify a full url in href. Making the faviconUrls consist of e.g. https://mycompany.com/https://images.squarespace-cdn.com/content/v1/56a7557442f552f59fe399aa/1453809627219-26RBJRYMD1F99XTA4NNS/favicon.ico
The other type of missing records have a href linking to a my_logo.svg file instead of a favicon.ico file@thilles could you provide the problematic domain name? If it's a new rule to add to favicon, we can do that for you π
Of course; nnd.no, lovenskiold.no, unibuss.no
ty! Could you create an issue on Github, we will assign it tomorrow π
GitHub
Issues Β· twentyhq/favicon
100% free and open-source favicon provider. Contribute to twentyhq/favicon development by creating an account on GitHub.
Thanks
GitHub
Missing favicons for some href's Β· Issue #28 Β· twentyhq/favicon
As discussed in https://discord.com/channels/1130383047699738754/1261068436419776644 Some hrefs found are not a relative link to a favicon.ico image, but instead a full url to a static asset, resul...
ty!
closing as this is tracked on Github π
@Gitstart Crew could you post an update here once this is merged